ubsan: crx: left shift cannot be represented in type 'int'

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

ubsan: crx: left shift cannot be represented in type 'int'

Alan Modra-3
        * crx-dis.c (match_opcode): Avoid shift left of signed value.

diff --git a/opcodes/crx-dis.c b/opcodes/crx-dis.c
index 18b6c6d9e6..011cd682fc 100644
--- a/opcodes/crx-dis.c
+++ b/opcodes/crx-dis.c
@@ -337,7 +337,7 @@ match_opcode (void)
   unsigned int mask;
 
   /* The instruction 'constant' opcode doewsn't exceed 32 bits.  */
-  unsigned int doubleWord = (words[1] + (words[0] << 16)) & 0xffffffff;
+  unsigned int doubleWord = words[1] + ((unsigned) words[0] << 16);
 
   /* Start searching from end of instruction table.  */
   instruction = &crx_instruction[NUMOPCODES - 2];

--
Alan Modra
Australia Development Lab, IBM