tar ball patch for cygwin based on sid-20060218.tar.bz2

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

tar ball patch for cygwin based on sid-20060218.tar.bz2

Rex Sung-Tien Cho(卓松田)
This patch is tested only for ARM target on cygwin with gcc 3.4.4, binutils 2.16.91.
I'd like to check in this patch to cvs, but somehow connection timeout every time.
Could anyone do me this favor?

There is to issues within this tarball:
1. the "PIC" issue (libiberty/)
        "PICFLAG = -fPIC" instead of "PICFLAG =",
        otherwise some dependency errors appeared.
        this issue need someone to take care of dependency stuff.

2. the "dllexport" issue (sid/component/)
        -extern const component_library audio_component_library;
        +DLLEXPORT extern const component_library audio_component_library;
 
        -const component_library audio_component_library DLLEXPORT =
        +const component_library audio_component_library =

        it seems that there is still room for gcc improvement.

        btw, the two lines source code could be condensed as

                DLLEXPORT extern const component_library audio_component_library =
        refer to http://www.cygwin.com/ml/cygwin/2003-11/msg00672.html

Have fun~

sid-20060218-patch.diff (31K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: tar ball patch for cygwin based on sid-20060218.tar.bz2

Frank Ch. Eigler
Hi -

> There is to issues within this tarball:
> 1. the "PIC" issue (libiberty/)
> "PICFLAG = -fPIC" instead of "PICFLAG =",
> otherwise some dependency errors appeared.
> this issue need someone to take care of dependency stuff.

This part will need to be passed to the libiberty maintainers over via
the GCC development mailing list.  I expect that the -fPIC part will
need to be made conditional via an autoconf test.


> 2. the "dllexport" issue (sid/component/)
> -extern const component_library audio_component_library;
> +DLLEXPORT extern const component_library audio_component_library;
>  
> -const component_library audio_component_library DLLEXPORT =
> +const component_library audio_component_library =
> [...]

I will apply this part of the patch.


> Have fun~

Done, thanks!


- FChE