[pushed] gdb, gdbserver: make stopped_pids global variables static

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[pushed] gdb, gdbserver: make stopped_pids global variables static

Sourceware - gdb-patches mailing list
I noticed that my IDE was confusing the two stopped_pids variables.
There is one in GDB and one in GDBserver.  They should be static, make
them so.

gdb/ChangeLog:

        * linux-nat.c (stopped_pids): Make static.

gdbserver/ChangeLog:

        * linux-low.cc (stopped_pids): Make static.

Change-Id: If4a2bdcd45d32eb3a732d266a0f686a4e4c23672
---
 gdb/ChangeLog          | 4 ++++
 gdb/linux-nat.c        | 2 +-
 gdbserver/ChangeLog    | 4 ++++
 gdbserver/linux-low.cc | 2 +-
 4 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e6202de248a6..b15a3a4e25f4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-07-21  Simon Marchi  <[hidden email]>
+
+ * linux-nat.c (stopped_pids): Make static.
+
 2020-07-21  Simon Marchi  <[hidden email]>
 
  PR ada/26235
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 6a78735018c1..20b03bc2ba95 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -204,7 +204,7 @@ struct simple_pid_list
   int status;
   struct simple_pid_list *next;
 };
-struct simple_pid_list *stopped_pids;
+static struct simple_pid_list *stopped_pids;
 
 /* Whether target_thread_events is in effect.  */
 static int report_thread_events;
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index 9d615870d177..d924e7231f45 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2020-07-21  Simon Marchi  <[hidden email]>
+
+ * linux-low.cc (stopped_pids): Make static.
+
 2020-07-17  Andrew Burgess  <[hidden email]>
 
  * tdesc.cc (allocate_target_description): Add header comment.
diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
index 9684922d1a10..e45493339d25 100644
--- a/gdbserver/linux-low.cc
+++ b/gdbserver/linux-low.cc
@@ -206,7 +206,7 @@ struct simple_pid_list
   /* Next in chain.  */
   struct simple_pid_list *next;
 };
-struct simple_pid_list *stopped_pids;
+static struct simple_pid_list *stopped_pids;
 
 /* Trivial list manipulation functions to keep track of a list of new
    stopped processes.  */
--
2.26.2