punt sys/io.h for superh

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

punt sys/io.h for superh

Mike Frysinger
is it just me or does the superh port wrongly include the io.h header ?  the
architecture doesnt actually implement any of the functions
(ioperm/out*/in*/etc...)

should just `cvs rm -f sysdeps/unix/sysv/linux/sh/sys/io.h`
-mike

attachment0 (844 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: punt sys/io.h for superh

Kaz Kojima
Mike Frysinger <[hidden email]> wrote:
> is it just me or does the superh port wrongly include the io.h header ?  the
> architecture doesnt actually implement any of the functions
> (ioperm/out*/in*/etc...)
>
> should just `cvs rm -f sysdeps/unix/sysv/linux/sh/sys/io.h`

Ugh.  Thanks for catching this.  I'd like to propose an obvious
patch below.

Regards,
        kaz
--
2006-12-03  Kaz Kojima  <[hidden email]>

        * sysdeps/unix/sysv/linux/sh/sys/io.h: Removed.

diff -uprN ORIG/libc/sysdeps/unix/sysv/linux/sh/sys/io.h LOCAL/libc/sysdeps/unix/sysv/linux/sh/sys/io.h
--- ORIG/libc/sysdeps/unix/sysv/linux/sh/sys/io.h 2001-07-06 13:56:20.000000000 +0900
+++ LOCAL/libc/sysdeps/unix/sysv/linux/sh/sys/io.h 1970-01-01 09:00:00.000000000 +0900
@@ -1,48 +0,0 @@
-/* Copyright (C) 1996, 1998, 1999, 2000 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, write to the Free
-   Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
-   02111-1307 USA.  */
-
-#ifndef _SYS_IO_H
-
-#define _SYS_IO_H 1
-#include <features.h>
-
-__BEGIN_DECLS
-
-/* If TURN_ON is TRUE, request for permission to do direct i/o on the
-   port numbers in the range [FROM,FROM+NUM-1].  Otherwise, turn I/O
-   permission off for that range.  This call requires root privileges.  */
-extern int ioperm (unsigned long int __from, unsigned long int __num,
-   int __turn_on) __THROW;
-
-/* Set the I/O privilege level to LEVEL.  If LEVEL is nonzero,
-   permission to access any I/O port is granted.  This call requires
-   root privileges. */
-extern int iopl (int __level) __THROW;
-
-/* The functions that actually perform reads and writes.  */
-extern unsigned char inb (unsigned long int port) __THROW;
-extern unsigned short int inw (unsigned long int port) __THROW;
-extern unsigned long int inl (unsigned long int port) __THROW;
-
-extern void outb (unsigned char value, unsigned long int port) __THROW;
-extern void outw (unsigned short value, unsigned long int port) __THROW;
-extern void outl (unsigned long value, unsigned long int port) __THROW;
-
-__END_DECLS
-
-#endif /* _SYS_IO_H */
Reply | Threaded
Open this post in threaded view
|

Re: punt sys/io.h for superh

Mike Frysinger
On Saturday 02 December 2006, Kaz Kojima wrote:
> Mike Frysinger <[hidden email]> wrote:
> > is it just me or does the superh port wrongly include the io.h header ?
> > the architecture doesnt actually implement any of the functions
> > (ioperm/out*/in*/etc...)
> >
> > should just `cvs rm -f sysdeps/unix/sysv/linux/sh/sys/io.h`
>
> Ugh.  Thanks for catching this.  I'd like to propose an obvious
> patch below.

mmm i think we need the attached as well ?
-mike

2007-02-10  Mike Frysinger  <[hidden email]>

        * sysdeps/unix/sysv/linux/sh/Makefile: Remove sys/io.h
        from sysdep_headers.

--- libc/sysdeps/unix/sysv/linux/sh/Makefile
+++ libc/sysdeps/unix/sysv/linux/sh/Makefile
@@ -2,10 +2,6 @@ ifeq ($(subdir),io)
 sysdep_routines += pipe
 endif
 
-ifeq ($(subdir),misc)
-sysdep_headers += sys/io.h
-endif
-
 ifeq ($(subdir),stdlib)
 gen-as-const-headers += ucontext_i.sym
 endif

attachment0 (844 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: punt sys/io.h for superh

Kaz Kojima
Mike Frysinger <[hidden email]> wrote:
> mmm i think we need the attached as well ?

Thanks for pointing this out.  Ulrich, could you please approve
this patch?

Regards,
        kaz