[patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host

Sandra Loosemore
This is yet another testsuite fix to clean up results on remote Windows
host.

For this testcase, I did consider trying to fix it rather than just
disabling it for remote host, but it looked like it was going to be an
awful lot of work and trial-and-error (it has almost no comments to
explain what it is trying to test, or how it is getting there).  I think
it is at least an incremental improvement to document that it isn't
expected to work as-is on remote host.  And disabling it does get rid of
33 completely bogus FAILs.  :-P

OK?

-Sandra

dw2-dir-file-name.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host

Simon Marchi-4
On 2019-08-13 6:29 p.m., Sandra Loosemore wrote:

> This is yet another testsuite fix to clean up results on remote Windows
> host.
>
> For this testcase, I did consider trying to fix it rather than just
> disabling it for remote host, but it looked like it was going to be an
> awful lot of work and trial-and-error (it has almost no comments to
> explain what it is trying to test, or how it is getting there).  I think
> it is at least an incremental improvement to document that it isn't
> expected to work as-is on remote host.  And disabling it does get rid of
> 33 completely bogus FAILs.  :-P
>
> OK?
>
> -Sandra
>

> +# This test has hard-wired assumptions that host and build filenames are
> +# the same, and assumes POSIX pathname syntax.
> +if { [is_remote host] || [ishost *-*-mingw*] } {
> +    return 0
> +}
> +

Should we use "untested" or "unsupported" before returning, to have at least a status
in the logs?  The definition of "unsupported" seems appropriate for this case:

    Declares that a test case depends on some facility that does not exist in the
    testing environment.

From: https://www.gnu.org/software/dejagnu/manual/unsupported-procedure.html

Simon
Reply | Threaded
Open this post in threaded view
|

Re: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host

Sandra Loosemore
On 8/14/19 9:12 PM, Simon Marchi wrote:

> On 2019-08-13 6:29 p.m., Sandra Loosemore wrote:
>> This is yet another testsuite fix to clean up results on remote Windows
>> host.
>>
>> For this testcase, I did consider trying to fix it rather than just
>> disabling it for remote host, but it looked like it was going to be an
>> awful lot of work and trial-and-error (it has almost no comments to
>> explain what it is trying to test, or how it is getting there).  I think
>> it is at least an incremental improvement to document that it isn't
>> expected to work as-is on remote host.  And disabling it does get rid of
>> 33 completely bogus FAILs.  :-P
>>
>> OK?
>>
>> -Sandra
>>
>
>> +# This test has hard-wired assumptions that host and build filenames are
>> +# the same, and assumes POSIX pathname syntax.
>> +if { [is_remote host] || [ishost *-*-mingw*] } {
>> +    return 0
>> +}
>> +
>
> Should we use "untested" or "unsupported" before returning, to have at least a status
> in the logs?  The definition of "unsupported" seems appropriate for this case:
>
>      Declares that a test case depends on some facility that does not exist in the
>      testing environment.
>
> From: https://www.gnu.org/software/dejagnu/manual/unsupported-procedure.html
>
> Simon
>

I did consider that, but the existing previous bit in that file is just

# This test can only be run on targets which support DWARF-2 and use gas.
if {![dwarf2_support]} {
     return 0
}

(which also appears in almost all the other gdb.dwarf2/*.exp files) so I
thought it would be locally consistent to just return quietly.  Is the
policy to use "untested" for host issues but not target properties,
maybe?  I'll do whatever conforms to recommended practice here, of course.

-Sandra
Reply | Threaded
Open this post in threaded view
|

Re: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host

Simon Marchi-4
On 2019-08-15 10:37 a.m., Sandra Loosemore wrote:
>
> I did consider that, but the existing previous bit in that file is just
>
> # This test can only be run on targets which support DWARF-2 and use gas.
> if {![dwarf2_support]} {
>     return 0
> }
>
> (which also appears in almost all the other gdb.dwarf2/*.exp files) so I thought it would be locally consistent to just return quietly.  Is the policy to use "untested" for host issues but not target properties, maybe?  I'll do whatever conforms to recommended practice here, of course.

Personally, any time a test is skipped for whatever reason, I'd like to see some "UNTESTED"
or "UNSUPPORTED" in the .sum file, to at least know the test existed and was skipped (along
with the reason), rather than just it being omitted.

I don't know if we have an "official" recommended practice here, this is just my opinion.
The patch LGTM in both cases, so I'll let you choose :).

Simon