[patch libiberty include gcc]: PR debug/28047 DWARF output_file_names should really understand DOS pathnames

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch libiberty include gcc]: PR debug/28047 DWARF output_file_names should really understand DOS pathnames

Kai Tietz-2
Hello,

For this PR (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28047) most
things are already fixed.
Just one point isn't handled correct for DOS-filesystem. As
DOS-filesystem normally uses
case-insensitive path/file-names and backslash/slash as
path-separators, a comparision of
file/path-names via strcmp/strncmp isn't suitable.
I found in libiberty, that there is alread the filename_cmp function,
which handles it proper. As in
source also strncmp is used, I added to libiberty the new function
filename_ncmp, which is for
none-DOS file-systems just the strncmp function, and for DOS-case an
implementation of
strncasecmp with special handling for the path-separators.

ChangeLog gcc/

2011-02-24  Kai Tietz

        PR debug/28047
        * dwarf2out.c (file_table_eq): Use filename_cmp instead of strcmp.
        * dwarf2out.c (lookup_filename): Likewise.
        * final.c (remap_debug_filename): Use filename_ncmp instead of
        strncmp.

ChangeLog /include

2011-02-24  Kai Tietz

        * filenames.h (filename_ncmp): New prototype.

ChangeLog /libiberty

2011-02-24  Kai Tietz

        * filename_cmp.c (filename_ncmp): New function.
        * functions.texi: Regenerated.

Tested for i686-pc-mingw32, x86_64-w64-mingw32, and regression-tested
for x86_64-pc-linux-gnu. Ok for apply?

Regards,
Kai

pr28047.txt (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [patch libiberty include gcc]: PR debug/28047 DWARF output_file_names should really understand DOS pathnames

Jason Merrill
OK (but you'll need to get a release manager to sign off if you want it
in 4.6, since it isn't a regression).

Jason
Reply | Threaded
Open this post in threaded view
|

Re: [patch libiberty include gcc]: PR debug/28047 DWARF output_file_names should really understand DOS pathnames

Kai Tietz-2
2011/2/24 Jason Merrill <[hidden email]>:
> OK (but you'll need to get a release manager to sign off if you want it in
> 4.6, since it isn't a regression).
>
> Jason
>

Hi Richard,

I would like to get this patch into 4.6. The outstanding issues about
file/path-name comparsion in other places of gcc will be something for
4.7. But I would like to have the libiberty changes in as soon as
possible, as those are of interest for some adjustments in binutils,
too.
So I want to ask if patch is ok for gcc, too?

Regards,
Kai
Reply | Threaded
Open this post in threaded view
|

Re: [patch libiberty include gcc]: PR debug/28047 DWARF output_file_names should really understand DOS pathnames

Richard Biener
On Sat, Feb 26, 2011 at 11:35 AM, Kai Tietz <[hidden email]> wrote:

> 2011/2/24 Jason Merrill <[hidden email]>:
>> OK (but you'll need to get a release manager to sign off if you want it in
>> 4.6, since it isn't a regression).
>>
>> Jason
>>
>
> Hi Richard,
>
> I would like to get this patch into 4.6. The outstanding issues about
> file/path-name comparsion in other places of gcc will be something for
> 4.7. But I would like to have the libiberty changes in as soon as
> possible, as those are of interest for some adjustments in binutils,
> too.
> So I want to ask if patch is ok for gcc, too?

I cannot comment about the libiberty pieces, those should get review
by a libiberty maintainer which should decide whether they are ok for 4.6.
If Jason is fine with the C++ changes I am, too.

Richard.

> Regards,
> Kai
>
Reply | Threaded
Open this post in threaded view
|

Re: [patch libiberty include gcc]: PR debug/28047 DWARF output_file_names should really understand DOS pathnames

Kai Tietz-2
2011/2/26 Richard Guenther <[hidden email]>:

> On Sat, Feb 26, 2011 at 11:35 AM, Kai Tietz <[hidden email]> wrote:
>> 2011/2/24 Jason Merrill <[hidden email]>:
>>> OK (but you'll need to get a release manager to sign off if you want it in
>>> 4.6, since it isn't a regression).
>>>
>>> Jason
>>>
>>
>> Hi Richard,
>>
>> I would like to get this patch into 4.6. The outstanding issues about
>> file/path-name comparsion in other places of gcc will be something for
>> 4.7. But I would like to have the libiberty changes in as soon as
>> possible, as those are of interest for some adjustments in binutils,
>> too.
>> So I want to ask if patch is ok for gcc, too?
>
> I cannot comment about the libiberty pieces, those should get review
> by a libiberty maintainer which should decide whether they are ok for 4.6.
> If Jason is fine with the C++ changes I am, too.
>
> Richard.
>
>> Regards,
>> Kai
>>
>

Hello DJ,

any comments about the libiberty part of this patch?

Thanks in advance,
Kai
Reply | Threaded
Open this post in threaded view
|

Re: [patch libiberty include gcc]: PR debug/28047 DWARF output_file_names should really understand DOS pathnames

DJ Delorie-2
In reply to this post by Richard Biener

The libiberty parts are OK
Reply | Threaded
Open this post in threaded view
|

Re: [patch libiberty include gcc]: PR debug/28047 DWARF output_file_names should really understand DOS pathnames

Kai Tietz-2
2011/2/28 DJ Delorie <[hidden email]>:
>
> The libiberty parts are OK
>

Applied at rev. 170570.

Regards,
Kai