[patch] fix building of powerpc/linuxthreads with gcc-4.1.0

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch] fix building of powerpc/linuxthreads with gcc-4.1.0

Mike Frysinger
nptl and trunk saw this fix last year, but linuxthreads was neglected
http://sourceware.org/ml/libc-alpha/2005-08/msg00002.html

ive quoted Dwayne as the author in the ChangeLog seeing as how he diagnosed
and fixed the real issue
-mike

2005-08-03  Dwayne Grant McConnell  <[hidden email]>

        * sysdeps/powerpc/Makefile (CFLAGS-initfini.s):
        Use +=, not =, to append.  Remove duplicate flags.

--- linuxthreads/sysdeps/powerpc/Makefile
+++ linuxthreads/sysdeps/powerpc/Makefile
@@ -1,6 +1,6 @@
 ifeq ($(subdir):$(elf),linuxthreads:yes)
 # See CFLAGS-initfini.s above; this is the same code.
-CFLAGS-pt-initfini.s = -g0 -fpic -O1
+CFLAGS-pt-initfini.s += -fpic -O1
 endif
 ifeq ($(subdir),csu)
 gen-as-const-headers += tcb-offsets.sym
Reply | Threaded
Open this post in threaded view
|

Re: [patch] fix building of powerpc/linuxthreads with gcc-4.1.0

Mike Frysinger
On Tuesday 14 March 2006 18:52, Mike Frysinger wrote:
> nptl and trunk saw this fix last year, but linuxthreads was neglected
> http://sourceware.org/ml/libc-alpha/2005-08/msg00002.html
>
> ive quoted Dwayne as the author in the ChangeLog seeing as how he diagnosed
> and fixed the real issue

blah, looks like the ports page still hasnt been updated with Steve's new
e-mail address
-mike
Reply | Threaded
Open this post in threaded view
|

Re: [patch] fix building of powerpc/linuxthreads with gcc-4.1.0

Steven Munroe
Mike Frysinger wrote:

>On Tuesday 14 March 2006 18:52, Mike Frysinger wrote:
>  
>
>>nptl and trunk saw this fix last year, but linuxthreads was neglected
>>http://sourceware.org/ml/libc-alpha/2005-08/msg00002.html
>>
>>ive quoted Dwayne as the author in the ChangeLog seeing as how he diagnosed
>>and fixed the real issue
>>    
>>
>
>blah, looks like the ports page still hasnt been updated with Steve's new
>e-mail address
>-mike
>  
>
Ok, I did not recognize it because Dwayne submitted the patch. Looks
like Dwayne's patch was committed to cvs trunc and fedora-branch, but
not to glibc-2.3.5-branch.

The patch in final form was:

http://sources.redhat.com/ml/libc-alpha/2005-08/msg00010.html
Reply | Threaded
Open this post in threaded view
|

Re: [patch] fix building of powerpc/linuxthreads with gcc-4.1.0

Daniel Jacobowitz-2
On Wed, Mar 15, 2006 at 12:36:45PM -0600, Steven Munroe wrote:
> >On Tuesday 14 March 2006 18:52, Mike Frysinger wrote:
> >>nptl and trunk saw this fix last year, but linuxthreads was neglected
> >>http://sourceware.org/ml/libc-alpha/2005-08/msg00002.html
> >>
> >>ive quoted Dwayne as the author in the ChangeLog seeing as how he
> >>diagnosed
> >>and fixed the real issue

He didn't fix LinuxThreads, though.  So it's your patch.

> Ok, I did not recognize it because Dwayne submitted the patch. Looks
> like Dwayne's patch was committed to cvs trunc and fedora-branch, but
> not to glibc-2.3.5-branch.

I don't know about that, but LinuxThreads needed the fix everywhere.
I've committed the patch (for trunk only).

--
Daniel Jacobowitz
CodeSourcery