[patch] Fix weakref testsuite failures under hppa hpux.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch] Fix weakref testsuite failures under hppa hpux.

John David Anglin-4
The enclosed patch fixes the weakref testsuite failures reported
in gas/1879.  Mostly the changes are to adopt to the querks of
gas on the PA.  I had to remove --no-sort because sometimes the
order of the symbol output differs from that on other systems.
I'm not sure why that is.

Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.

Ok?

Dave
--
J. David Anglin                                  [hidden email]
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)

2005-11-20  John David Anglin  <[hidden email]>

        Bug gas/1879
        * testsuite/gas/all/weakref1.d: Check for "$CODE$" as well as ".text".
        * testsuite/gas/all/weakref1.s: Indent "-ld1 = l".
        * testsuite/gas/all/weakref1g.d: Remove --no-sort option.
        * testsuite/gas/all/weakref1l.d: Likewise.
        * testsuite/gas/all/weakref1u.d: Likewise.  Sort expected results.
        * testsuite/gas/all/weakref1w.d: Likewise.
        * testsuite/gas/all/weakref2.s: Indent directives.
        * testsuite/gas/all/weakref3.s: Likewise.

Index: testsuite/gas/all/weakref1.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/weakref1.d,v
retrieving revision 1.2
diff -u -3 -p -r1.2 weakref1.d
--- testsuite/gas/all/weakref1.d 4 Nov 2005 19:45:25 -0000 1.2
+++ testsuite/gas/all/weakref1.d 20 Nov 2005 19:03:57 -0000
@@ -6,7 +6,7 @@
 #not-target: alpha*-*-osf* *-*-ecoff pdp11-*-aout
 
 #...
-RELOCATION RECORDS FOR \[\.text\]:
+RELOCATION RECORDS FOR \[(\.text|\$CODE\$)\]:
 OFFSET +TYPE +VALUE *
 # the rest of this file is generated with the following script:
 # # script begin
Index: testsuite/gas/all/weakref1.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/weakref1.s,v
retrieving revision 1.3
diff -u -3 -p -r1.3 weakref1.s
--- testsuite/gas/all/weakref1.s 16 Nov 2005 22:00:31 -0000 1.3
+++ testsuite/gas/all/weakref1.s 20 Nov 2005 19:03:57 -0000
@@ -189,7 +189,7 @@ l:
 /* d# target symbol definitions */
  .weakref Wld1, ld1
  .long Wld1
-ld1 = l
+ ld1 = l
 
  .weakref Wld2, ld2
  .long Wld2
Index: testsuite/gas/all/weakref1g.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/weakref1g.d,v
retrieving revision 1.1
diff -u -3 -p -r1.1 weakref1g.d
--- testsuite/gas/all/weakref1g.d 24 Oct 2005 17:51:42 -0000 1.1
+++ testsuite/gas/all/weakref1g.d 20 Nov 2005 19:03:57 -0000
@@ -1,4 +1,4 @@
-#nm: --defined-only --extern-only --no-sort
+#nm: --defined-only --extern-only
 #name: weakref tests, global syms
 #source: weakref1.s
 # see weakref1.d for comments on the not-targets
Index: testsuite/gas/all/weakref1l.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/weakref1l.d,v
retrieving revision 1.2
diff -u -3 -p -r1.2 weakref1l.d
--- testsuite/gas/all/weakref1l.d 4 Nov 2005 19:45:25 -0000 1.2
+++ testsuite/gas/all/weakref1l.d 20 Nov 2005 19:03:57 -0000
@@ -1,4 +1,4 @@
-#nm: --defined-only --no-sort
+#nm: --defined-only
 #name: weakref tests, local syms
 #source: weakref1.s
 # aix drops local symbols
Index: testsuite/gas/all/weakref1u.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/weakref1u.d,v
retrieving revision 1.2
diff -u -3 -p -r1.2 weakref1u.d
--- testsuite/gas/all/weakref1u.d 4 Nov 2005 19:45:25 -0000 1.2
+++ testsuite/gas/all/weakref1u.d 20 Nov 2005 19:03:57 -0000
@@ -1,4 +1,4 @@
-#nm: --undefined-only --no-sort
+#nm: --undefined-only
 #name: weakref tests, strong undefined syms
 #source: weakref1.s
 # aout turns undefined into *ABS* symbols.
@@ -39,11 +39,11 @@
 #...
 .* U uc9
 #...
-.* U um5
+.* U ud5
 #...
 .* U uh8
 #...
 .* U uh9
 #...
-.* U ud5
+.* U um5
 #pass
Index: testsuite/gas/all/weakref1w.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/weakref1w.d,v
retrieving revision 1.2
diff -u -3 -p -r1.2 weakref1w.d
--- testsuite/gas/all/weakref1w.d 4 Nov 2005 19:45:25 -0000 1.2
+++ testsuite/gas/all/weakref1w.d 20 Nov 2005 19:03:57 -0000
@@ -1,4 +1,4 @@
-#nm: --undefined-only --no-sort
+#nm: --undefined-only
 #name: weakref tests, weak undefined syms
 #source: weakref1.s
 # see weakref1.d for comments on the not-targets
@@ -16,41 +16,41 @@
 #...
 .* w wc1
 #...
-.* w ww1
+.* w wh2
 #...
-.* w ww2
+.* w wh3
 #...
-.* w ww3
+.* w wh4
 #...
-.* w ww4
+.* w wh5
 #...
-.* w ww5
+.* w wh6
 #...
-.* w ww6
+.* w wh7
 #...
-.* w ww7
+.* w wm6
 #...
-.* w ww8
+.* w wm7
 #...
-.* w ww9
+.* w wm8
 #...
-.* w ww10
+.* w ww1
 #...
-.* w wm6
+.* w ww10
 #...
-.* w wm7
+.* w ww2
 #...
-.* w wm8
+.* w ww3
 #...
-.* w wh2
+.* w ww4
 #...
-.* w wh3
+.* w ww5
 #...
-.* w wh4
+.* w ww6
 #...
-.* w wh5
+.* w ww7
 #...
-.* w wh6
+.* w ww8
 #...
-.* w wh7
+.* w ww9
 #pass
Index: testsuite/gas/all/weakref2.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/weakref2.s,v
retrieving revision 1.1
diff -u -3 -p -r1.1 weakref2.s
--- testsuite/gas/all/weakref2.s 24 Oct 2005 17:51:42 -0000 1.1
+++ testsuite/gas/all/weakref2.s 20 Nov 2005 19:03:57 -0000
@@ -1,5 +1,5 @@
-.weakref a,b
-.weakref b,c
-.weakref c,d
-.weakref d,e
-.weakref e,a
+ .weakref a,b
+ .weakref b,c
+ .weakref c,d
+ .weakref d,e
+ .weakref e,a
Index: testsuite/gas/all/weakref3.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/weakref3.s,v
retrieving revision 1.1
diff -u -3 -p -r1.1 weakref3.s
--- testsuite/gas/all/weakref3.s 24 Oct 2005 17:51:42 -0000 1.1
+++ testsuite/gas/all/weakref3.s 20 Nov 2005 19:03:57 -0000
@@ -1,5 +1,5 @@
-.weakref e,a
-.weakref d,e
-.weakref c,d
-.weakref b,c
-.weakref a,b
+ .weakref e,a
+ .weakref d,e
+ .weakref c,d
+ .weakref b,c
+ .weakref a,b
Reply | Threaded
Open this post in threaded view
|

Re: [patch] Fix weakref testsuite failures under hppa hpux.

Alan Modra
On Sun, Nov 20, 2005 at 02:52:22PM -0500, John David Anglin wrote:
> The enclosed patch fixes the weakref testsuite failures reported
> in gas/1879.  Mostly the changes are to adopt to the querks of
> gas on the PA.  I had to remove --no-sort because sometimes the
> order of the symbol output differs from that on other systems.
> I'm not sure why that is.
>
> Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.

This is fine.  Every so often, we need a reminder that pseudo ops can't
start in the first column for LABELS_WITHOUT_COLONS targets.

--
Alan Modra
IBM OzLabs - Linux Technology Centre