new systemtap snapshot available

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

new systemtap snapshot available

fche
A new automated systemtap CVS snapshot is available.
ftp://sources.redhat.com/pub/systemtap/snapshots/systemtap-20051105.tar.bz2
328848 bytes
Reply | Threaded
Open this post in threaded view
|

RE: new systemtap snapshot available

bibo,mao-2
When I compile profile.stp in EM64T and IA64 machine, maybe in PPC64 it has the same problem, but I have no PPC64 Box:).  There will be such warning information that it can not compile.
        /tmp/stapsOq5Wi/stap_19359.c: In function `function_accumulate':
        /tmp/stapsOq5Wi/stap_19359.c:382: warning: cast from pointer to integer of different size.
And by the error information, I find the line:
         l->__tmp3 = (((int)_stp_map_get_is (global_command, l->__tmp2))
And in runtime/map-gen.c function KEYSYM(_stp_map_get) return value type should be VALTYPE. It is int64_t.
So I modify translate.cxx,as follows:
          string exists (vector<tmpvar> const & indices) const
  {
    return "(((int64_t)" + call_prefix("get", indices) + ")) != 0)";
  }
And it will compile and run ok in my IA32, EM64T and IA64 box.

>-----Original Message-----
>From: [hidden email] [mailto:[hidden email]]
>On Behalf Of [hidden email]
>Sent: 2005年11月5日 22:27
>To: [hidden email]
>Subject: new systemtap snapshot available
>
>A new automated systemtap CVS snapshot is available.
>ftp://sources.redhat.com/pub/systemtap/snapshots/systemtap-20051105.tar.bz2
>328848 bytes
Reply | Threaded
Open this post in threaded view
|

Re: new systemtap snapshot available

Frank Ch. Eigler
"Mao, Bibo" <[hidden email]> writes:

> [...]
> /tmp/stapsOq5Wi/stap_19359.c: In function `function_accumulate':
> /tmp/stapsOq5Wi/stap_19359.c:382: warning: cast from pointer to integer =
> [...]
> So I modify translate.cxx,as follows: [...]
> And it will compile and run ok in my IA32, EM64T and IA64 box.

Thank you for your patch, now committed.  I'm also adding the following
blurb to the HACKING guidelines:

   As far as practicable, changes should be accompanied by test cases
-  to prevent future regressions.
+  to prevent future regressions.  Tests should be run on at least
+  x86, and ideally also on some 64-bit platform.

- FChE