hppa build broken

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

hppa build broken

Florian Weimer-5
In file included from tst-mutex5.c:27:
tst-mutex5.c: In function ‘do_test_clock’:
tst-mutex5.c:76:19: error: implicit declaration of function ‘pthread_mutex_clocklock’; did you mean ‘pthread_mutex_unlock’? [-Werror=implicit-function-declaration]
   76 |     TEST_COMPARE (pthread_mutex_clocklock (&m, clockid, &ts_timeout),
      |                   ^~~~~~~~~~~~~~~~~~~~~~~
../support/check.h:103:28: note: in definition of macro ‘TEST_COMPARE’
  103 |     typedef __typeof__ (+ (left)) __left_type;                          \
      |                            ^~~~

I think this is because the hppa copy of pthread.h wasn't updated for
the recent nptl changes.

I will fix this tomorrow if no one else steps in before that.

Thanks,
Florian
Reply | Threaded
Open this post in threaded view
|

Re: hppa build broken

Mike Crowe
On Tuesday 16 July 2019 at 22:45:04 +0200, Florian Weimer wrote:

> In file included from tst-mutex5.c:27:
> tst-mutex5.c: In function ‘do_test_clock’:
> tst-mutex5.c:76:19: error: implicit declaration of function ‘pthread_mutex_clocklock’; did you mean ‘pthread_mutex_unlock’? [-Werror=implicit-function-declaration]
>    76 |     TEST_COMPARE (pthread_mutex_clocklock (&m, clockid, &ts_timeout),
>       |                   ^~~~~~~~~~~~~~~~~~~~~~~
> ../support/check.h:103:28: note: in definition of macro ‘TEST_COMPARE’
>   103 |     typedef __typeof__ (+ (left)) __left_type;                          \
>       |                            ^~~~
>
> I think this is because the hppa copy of pthread.h wasn't updated for
> the recent nptl changes.

Proposed fix at https://sourceware.org/ml/libc-alpha/2019-07/msg00354.html

Mike.
Reply | Threaded
Open this post in threaded view
|

Re: hppa build broken

Adhemerval Zanella-2
In reply to this post by Florian Weimer-5


On 16/07/2019 17:45, Florian Weimer wrote:

> In file included from tst-mutex5.c:27:
> tst-mutex5.c: In function ‘do_test_clock’:
> tst-mutex5.c:76:19: error: implicit declaration of function ‘pthread_mutex_clocklock’; did you mean ‘pthread_mutex_unlock’? [-Werror=implicit-function-declaration]
>    76 |     TEST_COMPARE (pthread_mutex_clocklock (&m, clockid, &ts_timeout),
>       |                   ^~~~~~~~~~~~~~~~~~~~~~~
> ../support/check.h:103:28: note: in definition of macro ‘TEST_COMPARE’
>   103 |     typedef __typeof__ (+ (left)) __left_type;                          \
>       |                            ^~~~
>
> I think this is because the hppa copy of pthread.h wasn't updated for
> the recent nptl changes.
>
> I will fix this tomorrow if no one else steps in before that.
>
> Thanks,
> Florian
>

Sorry about that, my build testing only checked the glibc build itself
on hppa. Next time I will add a full build including tests as well.