[gas][aarch64] Turn on SVE when using f32mm or f64mm extensions

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[gas][aarch64] Turn on SVE when using f32mm or f64mm extensions

Matthew Malcomson-2
There are no instructions under these matrix multiply extensions that
can be used without having SVE enabled.
Since these extensions require SVE, we make that explicit in the options
table.

Tested on aarch64-none-elf without regressions.

gas/ChangeLog:

2020-01-13  Matthew Malcomson  <[hidden email]>

        * config/tc-aarch64.c (f64mm, f32mm): Add sve as a feature
        dependency.



###############     Attachment also inlined for ease of reply    ###############
                Inline version does not contain generated files


diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 8fa8657afcda44983dd21a7aea0b986904f62d6a..4f9c6030c560841527d007429ef1f11bac02330a 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -9063,9 +9063,9 @@ static const struct aarch64_option_cpu_value_table aarch64_features[] = {
   {"i8mm", AARCH64_FEATURE (AARCH64_FEATURE_I8MM, 0),
  AARCH64_ARCH_NONE},
   {"f32mm", AARCH64_FEATURE (AARCH64_FEATURE_F32MM, 0),
- AARCH64_ARCH_NONE},
+ AARCH64_FEATURE (AARCH64_FEATURE_SVE, 0)},
   {"f64mm", AARCH64_FEATURE (AARCH64_FEATURE_F64MM, 0),
- AARCH64_ARCH_NONE},
+ AARCH64_FEATURE (AARCH64_FEATURE_SVE, 0)},
   {NULL, AARCH64_ARCH_NONE, AARCH64_ARCH_NONE},
 };
 


feature-dependencies.patch (980 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [gas][aarch64] Turn on SVE when using f32mm or f64mm extensions

Nick Clifton
Hi Matthew,

> 2020-01-13  Matthew Malcomson  <[hidden email]>
>
> * config/tc-aarch64.c (f64mm, f32mm): Add sve as a feature
> dependency.

Approved - please apply.

Cheers
  Nick