[cygwin] testsuite failure: FAIL: i386 displacement (Intel mode)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[cygwin] testsuite failure: FAIL: i386 displacement (Intel mode)

Christian Joensson-2
Windows XP Pro/SP3 cygwin Intel Core2 Duo T9600@2.80GHz system with packages:

binutils             2.19.51-1      2.19.51.20090704
bison                2.3-1          2.3
cloog-ppl            0.15.3-1
cygwin               1.7.0-61
dejagnu              20021217-2     1.4.2.x
expect               20030128-1     5.26
gcc-ada              3.4.4-999
gcc-core             3.4.4-999
gcc-g++              3.4.4-999
gmp                  4.3.1-3
libcloog-devel       0.15.3-1
libgmp-devel         4.3.1-3
libmpfr-devel        2.4.1-4
libppl               0.10.2-1
make                 3.81-2
mpfr                 2.4.1-4
ppl                  0.10.2-1
ppl-devel            0.10.2-1
tcltk                20080420-1     8.4
w32api               3.13-1

LAST_UPDATED: Tue Sep 15 03:58:02 UTC 2009

../as-new  --32  -o dump.o
/usr/local/src/trunk/src/gas/testsuite/gas/i386/disp.s
Executing on host: sh -c {../as-new  --32  -o dump.o
/usr/local/src/trunk/src/gas/testsuite/gas/i386/disp.s 2>&1}
/dev/null gas.out (timeout = 300)
spawn [open ...]

/usr/local/src/trunk/objdir-binutils/gas/testsuite/../../binutils/objdump
 -dw -Mintel dump.o
Executing on host: sh -c
{/usr/local/src/trunk/objdir-binutils/gas/testsuite/../../binutils/objdump
 -dw -Mintel dump.o >dump.out 2>gas.stderr}  /dev/null  (timeout =
300)
spawn [open ...]

regexp_diff match failure
regexp "^[ ]*[a-f0-9]+: 8b 98 00 00 00 80     mov    ebx,DWORD PTR
\[eax-0x80000000\]$"
line   "   6: 8b 98 00 00 00 80     mov    ebx,DWORD PTR [eax--0x80000000]"
regexp_diff match failure
regexp "^[ ]*[a-f0-9]+: 8b 98 00 00 00 80     mov    ebx,DWORD PTR
\[eax-0x80000000\]$"
line   "   c: 8b 98 00 00 00 80     mov    ebx,DWORD PTR [eax--0x80000000]"
FAIL: i386 displacement (Intel mode)


--
Cheers,

/ChJ
Reply | Threaded
Open this post in threaded view
|

Re: [cygwin] testsuite failure: FAIL: i386 displacement (Intel mode)

H.J. Lu-30
On Mon, Sep 14, 2009 at 9:05 PM, Christian Joensson
<[hidden email]> wrote:

> /usr/local/src/trunk/objdir-binutils/gas/testsuite/../../binutils/objdump
>  -dw -Mintel dump.o
> Executing on host: sh -c
> {/usr/local/src/trunk/objdir-binutils/gas/testsuite/../../binutils/objdump
>  -dw -Mintel dump.o >dump.out 2>gas.stderr}  /dev/null  (timeout =
> 300)
> spawn [open ...]
>
> regexp_diff match failure
> regexp "^[      ]*[a-f0-9]+:    8b 98 00 00 00 80       mov    ebx,DWORD PTR
> \[eax-0x80000000\]$"
> line   "   6:   8b 98 00 00 00 80       mov    ebx,DWORD PTR [eax--0x80000000]"
> regexp_diff match failure
> regexp "^[      ]*[a-f0-9]+:    8b 98 00 00 00 80       mov    ebx,DWORD PTR
> \[eax-0x80000000\]$"
> line   "   c:   8b 98 00 00 00 80       mov    ebx,DWORD PTR [eax--0x80000000]"
> FAIL: i386 displacement (Intel mode)
>

The problem is when disp == -disp, we added extra '-'. This patch
fixed it.

--
H.J.
---

2009-09-15  H.J. Lu  <[hidden email]>

        * i386-dis.c (OP_E_memory): Don't print '-' in Intel mode if
        disp == -disp.

Index: i386-dis.c
===================================================================
--- i386-dis.c (revision 6828)
+++ i386-dis.c (working copy)
@@ -11107,7 +11107,7 @@ OP_E_memory (int bytemode, int sizeflag)
   *obufp++ = '+';
   *obufp = '\0';
  }
-      else if (modrm.mod != 1)
+      else if (modrm.mod != 1 && disp != -disp)
  {
   *obufp++ = '-';
   *obufp = '\0';
Reply | Threaded
Open this post in threaded view
|

Re: [cygwin] testsuite failure: FAIL: i386 displacement (Intel mode)

Christian Joensson-2
2009/9/15 H.J. Lu <[hidden email]>:

> The problem is when disp == -disp, we added extra '-'. This patch
> fixed it.

indeed it does, thanks.

--
Cheers,

/ChJ