[committed][gdb/testsuite] Handle callq -> call disassembly change

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[committed][gdb/testsuite] Handle callq -> call disassembly change

Tom de Vries
Hi,

We're currently running into:
...
FAIL: gdb.trace/entry-values.exp: disassemble bar
...

Since commit 36938cabf0 "x86: avoid attaching suffixes to unambiguous insns",
"callq" is disassembled as "call", and the test-case expects "callq".

Fix this by expecting "call" instead.

Tested on x86_64-linux.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Handle callq -> call disassembly change

gdb/testsuite/ChangeLog:

2020-07-15  Tom de Vries  <[hidden email]>

        * gdb.trace/entry-values.exp: Expect "call" instead of "callq" if
        is_amd64_regs_target.

---
 gdb/testsuite/gdb.trace/entry-values.exp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gdb/testsuite/gdb.trace/entry-values.exp b/gdb/testsuite/gdb.trace/entry-values.exp
index 8822950826..f647f3ca09 100644
--- a/gdb/testsuite/gdb.trace/entry-values.exp
+++ b/gdb/testsuite/gdb.trace/entry-values.exp
@@ -62,8 +62,6 @@ if { [istarget "arm*-*-*"] || [istarget "aarch64*-*-*"] } {
     # returns.  The only exception is JALRC, in which case execution
     # resumes from `insn1' instead.
     set call_insn {jalrc|[jb]al[sxr]*[ \t][^\r\n]+\r\n}
-} elseif [is_amd64_regs_target] {
-    set call_insn "callq"
 } else {
     set call_insn "call"
 }