[binutils-gdb] remote: multiple remote_arch_state instances per arch

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] remote: multiple remote_arch_state instances per arch

sergiodj+buildbot-2
*** TEST RESULTS FOR COMMIT 9d6eea31325e4027b5f035e941864fa6d780a8ca ***

Author: Pedro Alves <[hidden email]>
Branch: master
Commit: 9d6eea31325e4027b5f035e941864fa6d780a8ca

remote: multiple remote_arch_state instances per arch

Currently, we associate gdbarch-related remote protocol state on a
per-gdbarch data object.  Things like the size of the g/G packet, and
the max remote packet size.  If we'll support being connected to
different remote servers at the same time, then we need to cope with
each having their own packet sizes, even if they are each debugging
programs of the same architecture.  I.e., a single instance of
remote_arch_state per arch is not sufficient.

This patch moves the remote_arch_state object to a map of
gdbarch-to-remote_arch_state saved in the remote_state structure.
Usually there will only be one entry in the map, though we may see
more with stubs that support multi-process and/or archs with multiple
ABIs (e.g, one remote_arch_state for 64-bit inferiors and another for
32-bit inferiors).

gdb/ChangeLog:
2018-05-22  Pedro Alves  <[hidden email]>

        * remote.c: Include <unordered_map>.
        (remote_state): Now a class.
        (remote_state) <get_remote_arch_state>: Declare method.
        <get_remote_arch_state>: New field.
        (remote_arch_state) <remote_arch_state>: Declare ctor.
        <regs>: Now a unique_ptr.
        (remote_gdbarch_data_handle): Delete.
        (get_remote_arch_state): Delete.
        (remote_state::get_remote_arch_state): New.
        (get_remote_state): Adjust to call remote_state's
        get_remote_arch_state method.
        (init_remote_state): Delete, bits factored out to ...
        (remote_arch_state::remote_arch_state): ... this new method.
        (get_remote_packet_size, get_memory_packet_size)
        (process_g_packet, remote_target::fetch_registers)
        (remote_target::prepare_to_store, store_registers_using_G)
        (remote_target::store_registers, remote_target::get_trace_status):
        Adjust to call remote_state's method.
        (_initialize_remote): Remove reference to
        remote_gdbarch_data_handle.
Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-s390x-m64, branch master

sergiodj+buildbot-2
Buildslave:
        marist-fedora-s390x

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/8590>

Commit(s) tested:
        9d6eea31325e4027b5f035e941864fa6d780a8ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        remote: multiple remote_arch_state instances per arch

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/9d/9d6eea31325e4027b5f035e941864fa6d780a8ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-s390x-m64/xfails/master/xfail?id=b916c04>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-s390x-m64/xfails/master/xfail.table?id=b916c04>



Reply | Threaded
Open this post in threaded view
|

Failures on Debian-s390x-m64, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        debian-jessie-s390x-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Debian-s390x-m64/builds/5394>

Commit(s) tested:
        9d6eea31325e4027b5f035e941864fa6d780a8ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        remote: multiple remote_arch_state instances per arch

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Debian-s390x-m64/9d/9d6eea31325e4027b5f035e941864fa6d780a8ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail?id=6c960dc>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail.table?id=6c960dc>



Reply | Threaded
Open this post in threaded view
|

Failures on Debian-s390x-native-extended-gdbserver-m64, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        debian-jessie-s390x-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Debian-s390x-native-extended-gdbserver-m64/builds/5588>

Commit(s) tested:
        9d6eea31325e4027b5f035e941864fa6d780a8ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        remote: multiple remote_arch_state instances per arch

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Debian-s390x-native-extended-gdbserver-m64/9d/9d6eea31325e4027b5f035e941864fa6d780a8ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-extended-gdbserver-m64/xfails/master/xfail?id=203280d>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-extended-gdbserver-m64/xfails/master/xfail.table?id=203280d>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-i686, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-3

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/9808>

Commit(s) tested:
        9d6eea31325e4027b5f035e941864fa6d780a8ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        remote: multiple remote_arch_state instances per arch

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-i686/9d/9d6eea31325e4027b5f035e941864fa6d780a8ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail?id=b24bdf1>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail.table?id=b24bdf1>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-4

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/9813>

Commit(s) tested:
        9d6eea31325e4027b5f035e941864fa6d780a8ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        remote: multiple remote_arch_state instances per arch

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/9d/9d6eea31325e4027b5f035e941864fa6d780a8ca/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/info-os.exp: continue to breakpoint: Set breakpoint here
PASS -> FAIL: gdb.base/info-os.exp: get shared memory key
PASS -> FAIL: gdb.base/info-os.exp: get shared memory ID
PASS -> FAIL: gdb.base/info-os.exp: get semaphore key
PASS -> FAIL: gdb.base/info-os.exp: get semaphore ID
PASS -> FAIL: gdb.base/info-os.exp: get message queue key
PASS -> FAIL: gdb.base/info-os.exp: get message queue ID
PASS -> FAIL: gdb.base/info-os.exp: get socket port number
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail?id=d3d9c05>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table?id=d3d9c05>



Reply | Threaded
Open this post in threaded view
|

*** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE ***

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-4

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32/builds/1721>

Commit(s) tested:
        9d6eea31325e4027b5f035e941864fa6d780a8ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        remote: multiple remote_arch_state instances per arch

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-w64-mingw32/9d/9d6eea31325e4027b5f035e941864fa6d780a8ca/>

*** Failed to compiled GDB.  ***
============================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

../../binutils-gdb/bfd/bfd.c:1167:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_construct_extended_name_table':
../../binutils-gdb/bfd/archive.c:1685:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_archive_bsd44_construct_extended_name_table':
../../binutils-gdb/bfd/archive.c:1729:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/bfd.c: In function 'bfd_assert':
../../binutils-gdb/bfd/bfd.c:1418:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_generic_write_ar_hdr':
../../binutils-gdb/bfd/archive.c:1741:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/bfd.c: In function '_bfd_abort':
../../binutils-gdb/bfd/bfd.c:1438:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_bsd44_write_ar_hdr':
../../binutils-gdb/bfd/archive.c:1784:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_noarchive_write_ar_hdr':
../../binutils-gdb/bfd/archive.c:1790:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/bfd.c: In function '_bfd_get_gp_value':
../../binutils-gdb/bfd/bfd.c:1612:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/bfd.c: In function '_bfd_set_gp_value':
../../binutils-gdb/bfd/bfd.c:1628:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function 'bfd_generic_stat_arch_elt':
../../binutils-gdb/bfd/archive.c:1963:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function 'bfd_dont_truncate_arname':
../../binutils-gdb/bfd/archive.c:2000:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function 'bfd_bsd_truncate_arname':
../../binutils-gdb/bfd/archive.c:2023:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function 'bfd_gnu_truncate_arname':
../../binutils-gdb/bfd/archive.c:2060:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_noarchive_truncate_arname':
../../binutils-gdb/bfd/archive.c:2067:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_write_archive_contents':
../../binutils-gdb/bfd/archive.c:2226:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_compute_and_write_armap':
../../binutils-gdb/bfd/archive.c:2382:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_bsd_write_armap':
../../binutils-gdb/bfd/archive.c:2538:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
cc1: all warnings being treated as errors
../../binutils-gdb/bfd/archive.c: In function '_bfd_archive_bsd_update_armap_timestamp':
../../binutils-gdb/bfd/archive.c:2593:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
make[4]: *** [Makefile:1501: bfd.lo] Error 1
../../binutils-gdb/bfd/archive.c: In function '_bfd_coff_write_armap':
../../binutils-gdb/bfd/archive.c:2746:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_noarchive_write_armap':
../../binutils-gdb/bfd/archive.c:2757:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
../../binutils-gdb/bfd/archive.c: In function '_bfd_archive_close_and_cleanup':
../../binutils-gdb/bfd/archive.c:2815:1: error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]
 }
 ^
cc1: all warnings being treated as errors
make[4]: *** [Makefile:1501: archive.lo] Error 1
make[4]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-mingw32/build/bfd'
make[3]: *** [Makefile:1544: all-recursive] Error 1
make[3]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-mingw32/build/bfd'
make[2]: *** [Makefile:1077: all] Error 2
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-mingw32/build/bfd'
make[1]: *** [Makefile:2696: all-bfd] Error 2
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-mingw32/build'
make: *** [Makefile:857: all] Error 2
============================



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-cc-with-index, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-2

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/9722>

Commit(s) tested:
        9d6eea31325e4027b5f035e941864fa6d780a8ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        remote: multiple remote_arch_state instances per arch

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/9d/9d6eea31325e4027b5f035e941864fa6d780a8ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail?id=6ab5eec>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table?id=6ab5eec>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m64, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/9827>

Commit(s) tested:
        9d6eea31325e4027b5f035e941864fa6d780a8ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        remote: multiple remote_arch_state instances per arch

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/9d/9d6eea31325e4027b5f035e941864fa6d780a8ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail?id=370beeb>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail.table?id=370beeb>