[binutils-gdb] [gdb/testsuite] Clean up stale exec in gdb_compile_pascal

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] [gdb/testsuite] Clean up stale exec in gdb_compile_pascal

gdb-buildbot
*** TEST RESULTS FOR COMMIT d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28 ***

commit d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28
Author:     Tom de Vries <[hidden email]>
AuthorDate: Tue Aug 20 17:18:09 2019 +0200
Commit:     Tom de Vries <[hidden email]>
CommitDate: Tue Aug 20 17:18:09 2019 +0200

    [gdb/testsuite] Clean up stale exec in gdb_compile_pascal
   
    When running a pascal test with the stabs target board:
    ...
    $ test=gdb.pascal/case-insensitive-symbols.exp
    $ cd build/gdb/testsuite
    $ make check RUNTESTFLAGS="$test --target_board=stabs"
    ...
    we get:
    ...
    nr of untested testcases         1
    nr of unsupported tests          1
    ...
    due to:
    ...
    Error: Illegal parameter: -gstabs+^M
    Error: /usr/bin/ppcx64 returned an error exitcode^M
    ...
   
    OTOH, when running the same pascal test without the stabs target board:
    ...
    $ make check RUNTESTFLAGS="$test"
    ...
    we get:
    ...
    nr of expected passes            20
    ...
   
    But when subsequently again running with the stabs target board:
    ...
    $ make check RUNTESTFLAGS="$test --target_board=stabs"
    ...
    we now get:
    ...
    nr of expected passes            20
    ...
   
    The problem is that gdb_compile_pascal determines success based on existence
    of the exec after compilation:
    ...
        if ![file exists $destfile] {
            unsupported "Pascal compilation failed: $result"
            return "Pascal compilation failed."
        }
    ...
    without removing the exec before compilation, which allows a stale exec to
    make it seem as if compilation has succeeded.
   
    Fix this by removing the stale exec before compilation.
   
    gdb/testsuite/ChangeLog:
   
    2019-08-20  Tom de Vries  <[hidden email]>
   
            * lib/pascal.exp (gdb_compile_pascal): Remove $destfile before
            compilation.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index edf7d17801..5bc5f77ba0 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-20  Tom de Vries  <[hidden email]>
+
+ * lib/pascal.exp (gdb_compile_pascal): Remove $destfile before
+ compilation.
+
 2019-08-16  Tom de Vries  <[hidden email]>
 
  * gdb.base/compare-sections.exp ("after run to main"): Allow
diff --git a/gdb/testsuite/lib/pascal.exp b/gdb/testsuite/lib/pascal.exp
index 796c2a781e..dcdbb8d1f9 100644
--- a/gdb/testsuite/lib/pascal.exp
+++ b/gdb/testsuite/lib/pascal.exp
@@ -153,6 +153,8 @@ proc gdb_compile_pascal {source destfile type options} {
  pascal_init
     }
 
+    file delete $destfile
+
     if { $pascal_compiler_is_fpc == 1 } {
         set result [fpc_compile $source $destfile $type $options]
     } elseif { $pascal_compiler_is_gpc == 1 } {
Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

gdb-buildbot
Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/5/builds/547

Author:
        Tom de Vries <[hidden email]>

Commit tested:
        d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28

Subject of commit:
        [gdb/testsuite] Clean up stale exec in gdb_compile_pascal

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28/

*** Diff to previous build ***
==============================================
new UNRESOLVED: gdb.threads/create-fail.exp: iteration 5: delete all breakpoints in delete_breakpoints
new UNRESOLVED: gdb.threads/fork-plus-threads.exp: detach-on-fork=on: can't run to main
new UNRESOLVED: gdb.threads/fork-plus-threads.exp: detach-on-fork=on: delete all breakpoints in delete_breakpoints
new UNRESOLVED: gdb.threads/forking-threads-plus-breakpoint.exp: cond_bp_target=1: detach_on_fork=on: displaced=off: can't run to main
new FAIL: gdb.threads/forking-threads-plus-breakpoint.exp: cond_bp_target=1: detach_on_fork=on: displaced=on: can't run to main
new UNRESOLVED: gdb.threads/step-bg-decr-pc-switch-thread.exp: delete all breakpoints in delete_breakpoints
new UNRESOLVED: gdb.threads/thread-specific.exp: delete all breakpoints in delete_breakpoints
new UNRESOLVED: gdb.threads/thread-specific.exp: setting breakpoint at 39
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-i686, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/18/builds/616

Author:
        Tom de Vries <[hidden email]>

Commit tested:
        d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28

Subject of commit:
        [gdb/testsuite] Clean up stale exec in gdb_compile_pascal

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/options.exp: test-print: cmd complete "frame apply 1 print "
PASS -> FAIL: gdb.base/options.exp: test-print: tab complete "frame apply 1 print "
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-1

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/3/builds/638

Author:
        Tom de Vries <[hidden email]>

Commit tested:
        d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28

Subject of commit:
        [gdb/testsuite] Clean up stale exec in gdb_compile_pascal

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-2

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/24/builds/613

Author:
        Tom de Vries <[hidden email]>

Commit tested:
        d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28

Subject of commit:
        [gdb/testsuite] Clean up stale exec in gdb_compile_pascal

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/2/builds/614

Author:
        Tom de Vries <[hidden email]>

Commit tested:
        d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28

Subject of commit:
        [gdb/testsuite] Clean up stale exec in gdb_compile_pascal

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28/

*** Diff to previous build ***
==============================================
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/d7/d7a11d1383a2d0cdffc8c08e46b0cf5a66b3ce28//xfail.table.gz>