[binutils-gdb] gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

sergiodj+buildbot-2
*** TEST RESULTS FOR COMMIT 71d378ae60a4f072ce392046878d471255f6c8a1 ***

Author: Pedro Alves <[hidden email]>
Branch: master
Commit: 71d378ae60a4f072ce392046878d471255f6c8a1

gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

As Maciej reported at
<https://sourceware.org/ml/gdb-patches/2017-12/msg00212.html>, this
commit:

 commit d930703d68ae160ddfe8ebe5fdcf416fb6090e1e
 Date: Thu Nov 16 18:44:43 2017 +0000
 Subject: Don't ever Quit out of resume

caused regressions on software single-set targets, specifically:

 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw on: single-step breakpoint is not left behind
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: step in ro region (cannot insert hw break)
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: single-step breakpoint is not left behind
 FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw on: single-step breakpoint is not left behind

and indeed detailed logs indicate a breakpoint is left lingering, e.g.:

 (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
 maint info breakpoints 0
 Num     Type           Disp Enb Address    What
 0       sw single-step keep y   0x00400774 in main at [...]/gdb/testsuite/gdb.base/breakpoint-in-ro-region.c:24 inf 1 thread 1
         stop only in thread 1
 (gdb) FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind

vs:

 (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
 maint info breakpoints 0
 No breakpoint or watchpoint matching '0'.
 (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind

as at commit d930703d68ae^.

Before commit d930703d68ae, we had a cleanup installed in 'resume'
that would delete single-step breakpoints on error:

  /* Resuming.  */

  /* Things to clean up if we QUIT out of resume ().  */
  static void
  resume_cleanups (void *ignore)
  {
    if (!ptid_equal (inferior_ptid, null_ptid))
     delete_single_step_breakpoints (inferior_thread ());

    normal_stop ();
  }

That whole function was removed by d930703d68ae mainly to eliminate
the normal_stop call:

~~~~
    Note that the exception called from within resume ends up calling
    normal_stop via resume_cleanups.  That's very borked though, because
    normal_stop is going to re-handle whatever was the last reported
    event, possibly even re-running a hook stop...
~~~~

But as the regression shows, removing resume_cleanups completely went
a bit too far, as the delete_single_step_breakpoints call is still
necessary.

So fix the regression by reinstating the
delete_single_step_breakpoints call on error.  However, since we're
trying to eliminate cleanups, restore it in a different form (using
TRY/CATCH).

Tested on x86-64 GNU/Linux both top of master and on top of a series
that implements software single-step on x86.

gdb/ChangeLog:
2018-01-11  Pedro Alves  <[hidden email]>

        PR gdb/22583
        * infrun.c (resume): Rename to ...
        (resume_1): ... this.
        (resume): Reimplement as wrapper around resume_1.
Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-3

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/8501>

Commit(s) tested:
        71d378ae60a4f072ce392046878d471255f6c8a1

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m32/71/71d378ae60a4f072ce392046878d471255f6c8a1/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail;hb=4a056df>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail.table;hb=4a056df>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-cc-with-index, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-4

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/8450>

Commit(s) tested:
        71d378ae60a4f072ce392046878d471255f6c8a1

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/71/71d378ae60a4f072ce392046878d471255f6c8a1/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.arch/amd64-disp-step-avx.exp: vex2: xmm0 has expected value before
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail;hb=3e07033>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table;hb=3e07033>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-i686, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/8536>

Commit(s) tested:
        71d378ae60a4f072ce392046878d471255f6c8a1

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-i686/71/71d378ae60a4f072ce392046878d471255f6c8a1/>

*** Diff to previous build ***
============================
new FAIL: gdb.gdb/complaints.exp: breakpoint in captured_command_loop
new FAIL: gdb.gdb/complaints.exp: run until breakpoint at captured_command_loop
new FAIL: gdb.gdb/observer.exp: breakpoint in captured_main
new FAIL: gdb.gdb/observer.exp: run until breakpoint at captured_main
new FAIL: gdb.gdb/python-interrupts.exp: breakpoint in captured_command_loop
new FAIL: gdb.gdb/python-interrupts.exp: run until breakpoint at captured_command_loop
new FAIL: gdb.gdb/python-selftest.exp: breakpoint in captured_command_loop
new FAIL: gdb.gdb/python-selftest.exp: run until breakpoint at captured_command_loop
new FAIL: gdb.gdb/selftest.exp: breakpoint in captured_main
new FAIL: gdb.gdb/selftest.exp: run until breakpoint at captured_main
PASS -> FAIL: gdb.linespec/cpls-abi-tag.exp: test_abi_tag: completion: at tag: tab complete "b test_abi_tag_function[abi:"
PASS -> FAIL: gdb.linespec/cpls-abi-tag.exp: test_abi_tag: completion: at tag: cmd complete "b test_abi_tag_function[abi:"
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-i686/xfails/master/xfail;hb=e3bd253>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-i686/xfails/master/xfail.table;hb=e3bd253>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m32, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-2

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/8512>

Commit(s) tested:
        71d378ae60a4f072ce392046878d471255f6c8a1

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/71/71d378ae60a4f072ce392046878d471255f6c8a1/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-m32/xfails/master/xfail;hb=93edd57>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-m32/xfails/master/xfail.table;hb=93edd57>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-3

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/8540>

Commit(s) tested:
        71d378ae60a4f072ce392046878d471255f6c8a1

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/71/71d378ae60a4f072ce392046878d471255f6c8a1/>

*** Diff to previous build ***
============================
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail;hb=f51a767>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table;hb=f51a767>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-4

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/8495>

Commit(s) tested:
        71d378ae60a4f072ce392046878d471255f6c8a1

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/71/71d378ae60a4f072ce392046878d471255f6c8a1/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail;hb=d5466a1>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table;hb=d5466a1>



Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-AArch64-m64, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        ubuntu-aarch64-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-m64/builds/3950>

Commit(s) tested:
        71d378ae60a4f072ce392046878d471255f6c8a1

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Ubuntu-AArch64-m64/71/71d378ae60a4f072ce392046878d471255f6c8a1/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/callfuncs.exp: noproto: finish after stop in call dummy preserves register contents
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-m64/xfails/master/xfail;hb=a85ec42>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-m64/xfails/master/xfail.table;hb=a85ec42>



Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        ubuntu-trusty-aarch32-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-extended-gdbserver-m32/builds/2536>

Commit(s) tested:
        71d378ae60a4f072ce392046878d471255f6c8a1

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-extended-gdbserver-m32/71/71d378ae60a4f072ce392046878d471255f6c8a1/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=2: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=6: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=16: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=17: wait for stops
new FAIL: gdb.threads/sigstep-threads.exp: continue
new FAIL: gdb.threads/sigstep-threads.exp: step 39
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.



Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        ubuntu-trusty-aarch32-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/2518>

Commit(s) tested:
        71d378ae60a4f072ce392046878d471255f6c8a1

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/71/71d378ae60a4f072ce392046878d471255f6c8a1/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>



Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-AArch32-m32, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        ubuntu-trusty-aarch32-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-m32/builds/2537>

Commit(s) tested:
        71d378ae60a4f072ce392046878d471255f6c8a1

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-m32/71/71d378ae60a4f072ce392046878d471255f6c8a1/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-m32/xfails/master/xfail;hb=>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-m32/xfails/master/xfail.table;hb=>