*** TEST RESULTS FOR COMMIT fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49 ***
commit fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49 Author: Simon Marchi <[hidden email]> AuthorDate: Tue Jun 23 15:26:36 2020 -0400 Commit: Simon Marchi <[hidden email]> CommitDate: Tue Jun 23 15:34:45 2020 -0400 gdb: add empty lines in loc.c I always found that some switch statements in this file were a bit too packed. I think having empty lines between each case helps with reading. I'm pushing this as obvious, I hope it won't be too controversial. gdb/ChangeLog: * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty lines. (dwarf2_find_location_expression): Likewise. (call_site_parameter_matches): Likewise. (dwarf2_compile_expr_to_ax): Likewise. (disassemble_dwarf_expression): Likewise. (loclist_describe_location): Likewise. Change-Id: I381366a0468ff1793faa612c46ef48a9d4773192 diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1219f65b5a..6b21c19272 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,13 @@ +2020-06-23 Simon Marchi <[hidden email]> + + * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty + lines. + (dwarf2_find_location_expression): Likewise. + (call_site_parameter_matches): Likewise. + (dwarf2_compile_expr_to_ax): Likewise. + (disassemble_dwarf_expression): Likewise. + (loclist_describe_location): Likewise. + 2020-06-23 Pedro Alves <[hidden email]> * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c index 400bb4d16f..732c41d1c8 100644 --- a/gdb/dwarf2/loc.c +++ b/gdb/dwarf2/loc.c @@ -271,36 +271,45 @@ decode_debug_loc_dwo_addresses (dwarf2_per_cu_data *per_cu, case DW_LLE_GNU_end_of_list_entry: *new_ptr = loc_ptr; return DEBUG_LOC_END_OF_LIST; + case DW_LLE_GNU_base_address_selection_entry: *low = 0; loc_ptr = gdb_read_uleb128 (loc_ptr, buf_end, &high_index); if (loc_ptr == NULL) return DEBUG_LOC_BUFFER_OVERFLOW; + *high = dwarf2_read_addr_index (per_cu, per_objfile, high_index); *new_ptr = loc_ptr; return DEBUG_LOC_BASE_ADDRESS; + case DW_LLE_GNU_start_end_entry: loc_ptr = gdb_read_uleb128 (loc_ptr, buf_end, &low_index); if (loc_ptr == NULL) return DEBUG_LOC_BUFFER_OVERFLOW; + *low = dwarf2_read_addr_index (per_cu, per_objfile, low_index); loc_ptr = gdb_read_uleb128 (loc_ptr, buf_end, &high_index); if (loc_ptr == NULL) return DEBUG_LOC_BUFFER_OVERFLOW; + *high = dwarf2_read_addr_index (per_cu, per_objfile, high_index); *new_ptr = loc_ptr; return DEBUG_LOC_START_END; + case DW_LLE_GNU_start_length_entry: loc_ptr = gdb_read_uleb128 (loc_ptr, buf_end, &low_index); if (loc_ptr == NULL) return DEBUG_LOC_BUFFER_OVERFLOW; + *low = dwarf2_read_addr_index (per_cu, per_objfile, low_index); if (loc_ptr + 4 > buf_end) return DEBUG_LOC_BUFFER_OVERFLOW; + *high = *low; *high += extract_unsigned_integer (loc_ptr, 4, byte_order); *new_ptr = loc_ptr + 4; return DEBUG_LOC_START_LENGTH; + default: return DEBUG_LOC_INVALID_ENTRY; } @@ -362,17 +371,21 @@ dwarf2_find_location_expression (struct dwarf2_loclist_baton *baton, case DEBUG_LOC_END_OF_LIST: *locexpr_length = 0; return NULL; + case DEBUG_LOC_BASE_ADDRESS: base_address = high + base_offset; continue; + case DEBUG_LOC_START_END: case DEBUG_LOC_START_LENGTH: case DEBUG_LOC_OFFSET_PAIR: break; + case DEBUG_LOC_BUFFER_OVERFLOW: case DEBUG_LOC_INVALID_ENTRY: error (_("dwarf2_find_location_expression: " "Corrupted DWARF expression.")); + default: gdb_assert_not_reached ("bad debug_loc_kind"); } @@ -1279,8 +1292,10 @@ call_site_parameter_matches (struct call_site_parameter *parameter, { case CALL_SITE_PARAMETER_DWARF_REG: return kind_u.dwarf_reg == parameter->u.dwarf_reg; + case CALL_SITE_PARAMETER_FB_OFFSET: return kind_u.fb_offset == parameter->u.fb_offset; + case CALL_SITE_PARAMETER_PARAM_OFFSET: return kind_u.param_cu_off == parameter->u.param_cu_off; } @@ -3085,38 +3100,47 @@ dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc, ax_const_l (expr, extract_unsigned_integer (op_ptr, 1, byte_order)); op_ptr += 1; break; + case DW_OP_const1s: ax_const_l (expr, extract_signed_integer (op_ptr, 1, byte_order)); op_ptr += 1; break; + case DW_OP_const2u: ax_const_l (expr, extract_unsigned_integer (op_ptr, 2, byte_order)); op_ptr += 2; break; + case DW_OP_const2s: ax_const_l (expr, extract_signed_integer (op_ptr, 2, byte_order)); op_ptr += 2; break; + case DW_OP_const4u: ax_const_l (expr, extract_unsigned_integer (op_ptr, 4, byte_order)); op_ptr += 4; break; + case DW_OP_const4s: ax_const_l (expr, extract_signed_integer (op_ptr, 4, byte_order)); op_ptr += 4; break; + case DW_OP_const8u: ax_const_l (expr, extract_unsigned_integer (op_ptr, 8, byte_order)); op_ptr += 8; break; + case DW_OP_const8s: ax_const_l (expr, extract_signed_integer (op_ptr, 8, byte_order)); op_ptr += 8; break; + case DW_OP_constu: op_ptr = safe_read_uleb128 (op_ptr, op_end, &uoffset); ax_const_l (expr, uoffset); break; + case DW_OP_consts: op_ptr = safe_read_sleb128 (op_ptr, op_end, &offset); ax_const_l (expr, offset); @@ -3233,6 +3257,7 @@ dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc, ax_simple (expr, aop_add); } break; + case DW_OP_bregx: { op_ptr = safe_read_uleb128 (op_ptr, op_end, ®); @@ -3246,6 +3271,7 @@ dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc, } } break; + case DW_OP_fbreg: { const gdb_byte *datastart; @@ -3295,7 +3321,7 @@ dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc, offset = *op_ptr++; ax_pick (expr, offset); break; - + case DW_OP_swap: ax_simple (expr, aop_swap); break; @@ -3941,45 +3967,54 @@ disassemble_dwarf_expression (struct ui_file *stream, data += 1; fprintf_filtered (stream, " %s", pulongest (ul)); break; + case DW_OP_const1s: l = extract_signed_integer (data, 1, gdbarch_byte_order (arch)); data += 1; fprintf_filtered (stream, " %s", plongest (l)); break; + case DW_OP_const2u: ul = extract_unsigned_integer (data, 2, gdbarch_byte_order (arch)); data += 2; fprintf_filtered (stream, " %s", pulongest (ul)); break; + case DW_OP_const2s: l = extract_signed_integer (data, 2, gdbarch_byte_order (arch)); data += 2; fprintf_filtered (stream, " %s", plongest (l)); break; + case DW_OP_const4u: ul = extract_unsigned_integer (data, 4, gdbarch_byte_order (arch)); data += 4; fprintf_filtered (stream, " %s", pulongest (ul)); break; + case DW_OP_const4s: l = extract_signed_integer (data, 4, gdbarch_byte_order (arch)); data += 4; fprintf_filtered (stream, " %s", plongest (l)); break; + case DW_OP_const8u: ul = extract_unsigned_integer (data, 8, gdbarch_byte_order (arch)); data += 8; fprintf_filtered (stream, " %s", pulongest (ul)); break; + case DW_OP_const8s: l = extract_signed_integer (data, 8, gdbarch_byte_order (arch)); data += 8; fprintf_filtered (stream, " %s", plongest (l)); break; + case DW_OP_constu: data = safe_read_uleb128 (data, end, &ul); fprintf_filtered (stream, " %s", pulongest (ul)); break; + case DW_OP_consts: data = safe_read_sleb128 (data, end, &l); fprintf_filtered (stream, " %s", plongest (l)); @@ -4262,6 +4297,7 @@ disassemble_dwarf_expression (struct ui_file *stream, ul = dwarf2_read_addr_index (per_cu, per_objfile, ul); fprintf_filtered (stream, " 0x%s", phex_nz (ul, addr_size)); break; + case DW_OP_GNU_const_index: data = safe_read_uleb128 (data, end, &ul); ul = dwarf2_read_addr_index (per_cu, per_objfile, ul); @@ -4583,19 +4619,23 @@ loclist_describe_location (struct symbol *symbol, CORE_ADDR addr, case DEBUG_LOC_END_OF_LIST: done = 1; continue; + case DEBUG_LOC_BASE_ADDRESS: base_address = high + base_offset; fprintf_filtered (stream, _(" Base address %s"), paddress (gdbarch, base_address)); continue; + case DEBUG_LOC_START_END: case DEBUG_LOC_START_LENGTH: case DEBUG_LOC_OFFSET_PAIR: break; + case DEBUG_LOC_BUFFER_OVERFLOW: case DEBUG_LOC_INVALID_ENTRY: error (_("Corrupted DWARF expression for symbol \"%s\"."), symbol->print_name ()); + default: gdb_assert_not_reached ("bad debug_loc_kind"); } |
Buildername:
Fedora-i686 Worker: fedora-x86-64-4 Full Build URL: https://gdb-buildbot.osci.io/#builders/18/builds/3553 Author: Simon Marchi <[hidden email]> Commit tested: fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49 Subject of commit: gdb: add empty lines in loc.c *** FAILED to build GDB -- compile gdb *** ============================================== +++ The full log is too big to be posted here. +++ These are the last 100 lines of it. CXX user-regs.o CXX utils.o CXX v850-tdep.o CXX valarith.o CXX valops.o CXX valprint.o CXX value.o CXX varobj.o CXX vax-nbsd-tdep.o CXX vax-tdep.o GEN stamp-version CXX windows-tdep.o CXX x86-linux-nat.o CXX x86-nat.o CXX x86-tdep.o CXX xcoffread.o GEN xml-builtin.c CXX xml-support.o CXX xml-syscall.o CXX xml-tdesc.o CXX xstormy16-tdep.o CXX xtensa-config.o CXX xtensa-linux-tdep.o CXX xtensa-tdep.o CXX gdb.o CXX aarch32-tdep.o CXX ada-exp.o CXX ada-lang.o CXX ada-tasks.o CXX ada-typeprint.o CXX ada-valprint.o CXX ada-varobj.o CXX addrmap.o CXX agent.o CXX alloc.o CXX annotate.o CXX arc-tdep.o CXX arch-utils.o CXX arch/aarch32.o CXX arch/arc.o CXX arch/arm-get-next-pcs.o CXX arch/arm-linux.o CXX arch/arm.o CXX arch/i386.o CXX arch/ppc-linux-common.o CXX arch/riscv.o CXX arm-bsd-tdep.o CXX arm-fbsd-tdep.o CXX arm-linux-tdep.o CXX arm-nbsd-tdep.o CXX arm-obsd-tdep.o CXX arm-pikeos-tdep.o CXX arm-symbian-tdep.o CXX arm-tdep.o CXX arm-wince-tdep.o CXX async-event.o CXX auto-load.o CXX auxv.o CXX avr-tdep.o CXX ax-gdb.o CXX ax-general.o CXX bcache.o CXX bfd-target.o CXX bfin-linux-tdep.o CXX bfin-tdep.o CXX block.o CXX blockframe.o CXX break-catch-sig.o CXX break-catch-syscall.o CXX break-catch-throw.o CXX breakpoint.o CXX bsd-uthread.o CXX btrace.o CXX build-id.o CXX buildsym-legacy.o CXX buildsym.o CXX c-exp.o CXX cp-name-parser.o CXX d-exp.o CXX f-exp.o CXX go-exp.o CXX m2-exp.o CXX p-exp.o CXX rust-exp.o CXX version.o CXX xml-builtin.o GEN init.c CXX init.o CXXLD gdb /usr/bin/ld: ../opcodes/libopcodes.a(riscv-dis.o): in function `parse_riscv_dis_option': /home/gdb-buildbot-2/fedora-x86-64-4/fedora-i686/build/opcodes/../../binutils-gdb/opcodes/riscv-dis.c:102: undefined reference to `riscv_get_priv_spec_class' collect2: error: ld returned 1 exit status make[2]: *** [Makefile:1861: gdb] Error 1 make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-i686/build/gdb' make[1]: *** [Makefile:10066: all-gdb] Error 2 make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-i686/build' make: *** [Makefile:854: all] Error 2 program finished with exit code 2 elapsedTime=460.290909 ============================================== |
In reply to this post by gdb-buildbot-2
Buildername:
Fedora-x86_64-cc-with-index Worker: fedora-x86-64-4 Full Build URL: https://gdb-buildbot.osci.io/#builders/20/builds/3501 Author: Simon Marchi <[hidden email]> Commit tested: fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49 Subject of commit: gdb: add empty lines in loc.c Testsuite logs (gdb.sum, gdb.log and others): https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49/ *** Diff to previous build *** ============================================== new KFAIL: gdb.base/step-over-syscall.exp: clone: displaced=on: single step over clone PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited ============================================== *** Complete list of XFAILs for this builder *** To obtain the list of XFAIL tests for this builder, go to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.gz> You can also see a pretty-printed version of the list, with more information about each XFAIL, by going to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.table.gz> |
In reply to this post by gdb-buildbot-2
Buildername:
Fedora-x86_64-m32 Worker: fedora-x86-64-3 Full Build URL: https://gdb-buildbot.osci.io/#builders/17/builds/3547 Author: Simon Marchi <[hidden email]> Commit tested: fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49 Subject of commit: gdb: add empty lines in loc.c Testsuite logs (gdb.sum, gdb.log and others): https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49/ *** Diff to previous build *** ============================================== new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Private-Anonymous: no binary: loading /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-private-anon.gcore new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Shared-Anonymous: loading /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited ============================================== *** Complete list of XFAILs for this builder *** To obtain the list of XFAIL tests for this builder, go to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.gz> You can also see a pretty-printed version of the list, with more information about each XFAIL, by going to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.table.gz> |
In reply to this post by gdb-buildbot-2
Buildername:
Fedora-x86_64-m64 Worker: fedora-x86-64-4 Full Build URL: https://gdb-buildbot.osci.io/#builders/3/builds/3610 Author: Simon Marchi <[hidden email]> Commit tested: fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49 Subject of commit: gdb: add empty lines in loc.c Testsuite logs (gdb.sum, gdb.log and others): https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49/ *** Diff to previous build *** ============================================== PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3 ============================================== *** Complete list of XFAILs for this builder *** To obtain the list of XFAIL tests for this builder, go to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.gz> You can also see a pretty-printed version of the list, with more information about each XFAIL, by going to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.table.gz> |
In reply to this post by gdb-buildbot-2
Buildername:
Fedora-x86_64-native-extended-gdbserver-m32 Worker: fedora-x86-64-3 Full Build URL: https://gdb-buildbot.osci.io/#builders/4/builds/3443 Author: Simon Marchi <[hidden email]> Commit tested: fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49 Subject of commit: gdb: add empty lines in loc.c Testsuite logs (gdb.sum, gdb.log and others): https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49/ *** Diff to previous build *** ============================================== PASS -> FAIL: gdb.fortran/vla-ptype.exp: ptype vla1 PASS -> FAIL: gdb.fortran/vla-value.exp: print member in non-allocated vla1 PASS -> FAIL: gdb.fortran/vla-value.exp: set member in non-allocated vla1 ============================================== *** Complete list of XFAILs for this builder *** To obtain the list of XFAIL tests for this builder, go to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.gz> You can also see a pretty-printed version of the list, with more information about each XFAIL, by going to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.table.gz> |
In reply to this post by gdb-buildbot-2
Buildername:
Fedora-x86_64-native-extended-gdbserver-m64 Worker: fedora-x86-64-4 Full Build URL: https://gdb-buildbot.osci.io/#builders/2/builds/3444 Author: Simon Marchi <[hidden email]> Commit tested: fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49 Subject of commit: gdb: add empty lines in loc.c Testsuite logs (gdb.sum, gdb.log and others): https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49/ *** Diff to previous build *** ============================================== UNRESOLVED -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited new FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: only inferior 1 left PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j ============================================== *** Complete list of XFAILs for this builder *** To obtain the list of XFAIL tests for this builder, go to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.gz> You can also see a pretty-printed version of the list, with more information about each XFAIL, by going to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.table.gz> |
In reply to this post by gdb-buildbot-2
Buildername:
Fedora-x86_64-native-gdbserver-m64 Worker: fedora-x86-64-4 Full Build URL: https://gdb-buildbot.osci.io/#builders/22/builds/3455 Author: Simon Marchi <[hidden email]> Commit tested: fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49 Subject of commit: gdb: add empty lines in loc.c Testsuite logs (gdb.sum, gdb.log and others): https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49/ *** Diff to previous build *** ============================================== PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: continue until exit PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: print re_run_var_2 PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print i PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print j PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3 PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited ============================================== *** Complete list of XFAILs for this builder *** To obtain the list of XFAIL tests for this builder, go to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.gz> You can also see a pretty-printed version of the list, with more information about each XFAIL, by going to: <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/fc/fc3ecb3e61fe5dcc16c206e4135b33cc1a32ba49//xfail.table.gz> |
Free forum by Nabble | Edit this page |