[binutils-gdb] gdb: Convert language la_printstr field to a method

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] gdb: Convert language la_printstr field to a method

Sourceware - gdb-testers mailing list
*** TEST RESULTS FOR COMMIT d711ee67aca06c9753f09dc154eb8c75cb4f58ef ***

commit d711ee67aca06c9753f09dc154eb8c75cb4f58ef
Author:     Andrew Burgess <[hidden email]>
AuthorDate: Wed Jun 3 16:44:05 2020 +0100
Commit:     Andrew Burgess <[hidden email]>
CommitDate: Tue Jun 23 13:34:11 2020 +0100

    gdb: Convert language la_printstr field to a method
   
    This commit changes the language_data::la_printstr function pointer
    member variable into a member function of language_defn.
   
    There should be no user visible changes after this commit.
   
    gdb/ChangeLog:
   
            * ada-lang.c (ada_language_data): Delete la_printstr initializer.
            (ada_language::printstr): New member function.
            * c-lang.c (c_language_data): Delete la_printstr initializer.
            (cplus_language_data): Likewise.
            (asm_language_data): Likewise.
            (minimal_language_data): Likewise.
            * d-lang.c (d_language_data): Likewise.
            * f-lang.c (f_printstr): Rename to f_language::printstr.
            (f_language_data): Delete la_printstr initializer.
            (f_language::printstr): New member function, implementation from
            f_printstr.
            * go-lang.c (go_language_data): Delete la_printstr initializer.
            * language.c (language_defn::printstr): Define new member
            function.
            (unk_lang_printstr): Delete.
            (unknown_language_data): Delete la_printstr initializer.
            (unknown_language::printstr): New member function.
            (auto_language_data): Delete la_printstr initializer.
            (auto_language::printstr): New member function.
            * language.h (language_data): Delete la_printstr field.
            (language_defn::printstr): Declare new member function.
            (LA_PRINT_STRING): Update call to printstr.
            * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
            (m2_language_data): Delete la_printstr initializer.
            (m2_language::printstr): New member function, implementation from
            m2_printstr.
            * objc-lang.c (objc_language_data): Delete la_printstr
            initializer.
            * opencl-lang.c (opencl_language_data): Likewise.
            * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
            (pascal_language_data): Delete la_printstr initializer.
            (pascal_language::printstr): New member function, implementation
            from pascal_printstr.
            * p-lang.h (pascal_printstr): Delete declaration.
            * rust-lang.c (rust_printstr): Update header comment.
            (rust_language_data): Delete la_printstr initializer.
            (rust_language::printstr): New member function.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8287719e93..e768e447f4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,43 @@
+2020-06-23  Andrew Burgess  <[hidden email]>
+
+ * ada-lang.c (ada_language_data): Delete la_printstr initializer.
+ (ada_language::printstr): New member function.
+ * c-lang.c (c_language_data): Delete la_printstr initializer.
+ (cplus_language_data): Likewise.
+ (asm_language_data): Likewise.
+ (minimal_language_data): Likewise.
+ * d-lang.c (d_language_data): Likewise.
+ * f-lang.c (f_printstr): Rename to f_language::printstr.
+ (f_language_data): Delete la_printstr initializer.
+ (f_language::printstr): New member function, implementation from
+ f_printstr.
+ * go-lang.c (go_language_data): Delete la_printstr initializer.
+ * language.c (language_defn::printstr): Define new member
+ function.
+ (unk_lang_printstr): Delete.
+ (unknown_language_data): Delete la_printstr initializer.
+ (unknown_language::printstr): New member function.
+ (auto_language_data): Delete la_printstr initializer.
+ (auto_language::printstr): New member function.
+ * language.h (language_data): Delete la_printstr field.
+ (language_defn::printstr): Declare new member function.
+ (LA_PRINT_STRING): Update call to printstr.
+ * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
+ (m2_language_data): Delete la_printstr initializer.
+ (m2_language::printstr): New member function, implementation from
+ m2_printstr.
+ * objc-lang.c (objc_language_data): Delete la_printstr
+ initializer.
+ * opencl-lang.c (opencl_language_data): Likewise.
+ * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
+ (pascal_language_data): Delete la_printstr initializer.
+ (pascal_language::printstr): New member function, implementation
+ from pascal_printstr.
+ * p-lang.h (pascal_printstr): Delete declaration.
+ * rust-lang.c (rust_printstr): Update header comment.
+ (rust_language_data): Delete la_printstr initializer.
+ (rust_language::printstr): New member function.
+
 2020-06-23  Andrew Burgess  <[hidden email]>
 
  * ada-lang.c (ada_language_data): Delete la_printchar initializer.
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index e69c3cbf50..62ea21a385 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -13681,7 +13681,6 @@ extern const struct language_data ada_language_data =
   macro_expansion_no,
   ada_extensions,
   &ada_exp_descriptor,
-  ada_printstr,                 /* Function to print string constant */
   ada_print_typedef,            /* Print a typedef using appropriate syntax */
   NULL,                         /* name_of_this */
   true,                         /* la_store_sym_names_in_linkage_form_p */
@@ -14122,6 +14121,17 @@ public:
     ada_printchar (ch, chtype, stream);
   }
 
+  /* See language.h.  */
+
+  void printstr (struct ui_file *stream, struct type *elttype,
+ const gdb_byte *string, unsigned int length,
+ const char *encoding, int force_ellipses,
+ const struct value_print_options *options) const override
+  {
+    ada_printstr (stream, elttype, string, length, encoding,
+  force_ellipses, options);
+  }
+
 protected:
   /* See language.h.  */
 
diff --git a/gdb/c-lang.c b/gdb/c-lang.c
index f7b1b80cd5..d6bbc025bc 100644
--- a/gdb/c-lang.c
+++ b/gdb/c-lang.c
@@ -889,7 +889,6 @@ extern const struct language_data c_language_data =
   macro_expansion_c,
   c_extensions,
   &exp_descriptor_c,
-  c_printstr, /* Function to print string constant */
   c_print_typedef, /* Print a typedef using appropriate syntax */
   NULL, /* name_of_this */
   true, /* la_store_sym_names_in_linkage_form_p */
@@ -993,7 +992,6 @@ extern const struct language_data cplus_language_data =
   macro_expansion_c,
   cplus_extensions,
   &exp_descriptor_c,
-  c_printstr, /* Function to print string constant */
   c_print_typedef, /* Print a typedef using appropriate syntax */
   "this",                       /* name_of_this */
   false, /* la_store_sym_names_in_linkage_form_p */
@@ -1194,7 +1192,6 @@ extern const struct language_data asm_language_data =
   macro_expansion_c,
   asm_extensions,
   &exp_descriptor_c,
-  c_printstr, /* Function to print string constant */
   c_print_typedef, /* Print a typedef using appropriate syntax */
   NULL, /* name_of_this */
   true, /* la_store_sym_names_in_linkage_form_p */
@@ -1253,7 +1250,6 @@ extern const struct language_data minimal_language_data =
   macro_expansion_c,
   NULL,
   &exp_descriptor_c,
-  c_printstr, /* Function to print string constant */
   c_print_typedef, /* Print a typedef using appropriate syntax */
   NULL, /* name_of_this */
   true, /* la_store_sym_names_in_linkage_form_p */
diff --git a/gdb/d-lang.c b/gdb/d-lang.c
index f76b74f18b..17ab38ee51 100644
--- a/gdb/d-lang.c
+++ b/gdb/d-lang.c
@@ -142,7 +142,6 @@ extern const struct language_data d_language_data =
   macro_expansion_no,
   d_extensions,
   &exp_descriptor_c,
-  c_printstr, /* Function to print string constant.  */
   c_print_typedef, /* Print a typedef using appropriate
    syntax.  */
   "this",
diff --git a/gdb/f-lang.c b/gdb/f-lang.c
index 68d0a4e6d0..67c2ea34b6 100644
--- a/gdb/f-lang.c
+++ b/gdb/f-lang.c
@@ -68,29 +68,6 @@ f_get_encoding (struct type *type)
   return encoding;
 }
 
-/* Print the character string STRING, printing at most LENGTH characters.
-   Printing stops early if the number hits print_max; repeat counts
-   are printed as appropriate.  Print ellipses at the end if we
-   had to stop before printing LENGTH characters, or if FORCE_ELLIPSES.
-   FIXME:  This is a copy of the same function from c-exp.y.  It should
-   be replaced with a true F77 version.  */
-
-static void
-f_printstr (struct ui_file *stream, struct type *type, const gdb_byte *string,
-    unsigned int length, const char *encoding, int force_ellipses,
-    const struct value_print_options *options)
-{
-  const char *type_encoding = f_get_encoding (type);
-
-  if (TYPE_LENGTH (type) == 4)
-    fputs_filtered ("4_", stream);
-
-  if (!encoding || !*encoding)
-    encoding = type_encoding;
-
-  generic_printstr (stream, type, string, length, encoding,
-    force_ellipses, '\'', 0, options);
-}
 
 
 /* Table of operators and their precedences for printing expressions.  */
@@ -536,7 +513,6 @@ extern const struct language_data f_language_data =
   macro_expansion_no,
   f_extensions,
   &exp_descriptor_f,
-  f_printstr, /* function to print string constant */
   f_print_typedef, /* Print a typedef using appropriate syntax */
   NULL,                     /* name_of_this */
   false, /* la_store_sym_names_in_linkage_form_p */
@@ -707,6 +683,25 @@ public:
     fputs_filtered ("'", stream);
   }
 
+  /* See language.h.  */
+
+  void printstr (struct ui_file *stream, struct type *elttype,
+ const gdb_byte *string, unsigned int length,
+ const char *encoding, int force_ellipses,
+ const struct value_print_options *options) const override
+  {
+    const char *type_encoding = f_get_encoding (elttype);
+
+    if (TYPE_LENGTH (elttype) == 4)
+      fputs_filtered ("4_", stream);
+
+    if (!encoding || !*encoding)
+      encoding = type_encoding;
+
+    generic_printstr (stream, elttype, string, length, encoding,
+      force_ellipses, '\'', 0, options);
+  }
+
 protected:
 
   /* See language.h.  */
diff --git a/gdb/go-lang.c b/gdb/go-lang.c
index 819780bc30..69f14b8c56 100644
--- a/gdb/go-lang.c
+++ b/gdb/go-lang.c
@@ -527,7 +527,6 @@ extern const struct language_data go_language_data =
   macro_expansion_no,
   NULL,
   &exp_descriptor_c,
-  c_printstr, /* Function to print string constant.  */
   c_print_typedef, /* Print a typedef using appropriate
    syntax.  */
   NULL, /* name_of_this */
diff --git a/gdb/language.c b/gdb/language.c
index 34990e040c..9867ac4b4b 100644
--- a/gdb/language.c
+++ b/gdb/language.c
@@ -669,6 +669,18 @@ language_defn::printchar (int ch, struct type *chtype,
   c_printchar (ch, chtype, stream);
 }
 
+/* See language.h.  */
+
+void
+language_defn::printstr (struct ui_file *stream, struct type *elttype,
+ const gdb_byte *string, unsigned int length,
+ const char *encoding, int force_ellipses,
+ const struct value_print_options *options) const
+{
+  c_printstr (stream, elttype, string, length, encoding, force_ellipses,
+      options);
+}
+
 /* The default implementation of the get_symbol_name_matcher_inner method
    from the language_defn class.  Matches with strncmp_iw.  */
 
@@ -734,16 +746,6 @@ default_is_string_type_p (struct type *type)
   return (type->code ()  == TYPE_CODE_STRING);
 }
 
-static void
-unk_lang_printstr (struct ui_file *stream, struct type *type,
-   const gdb_byte *string, unsigned int length,
-   const char *encoding, int force_ellipses,
-   const struct value_print_options *options)
-{
-  error (_("internal error - unimplemented "
-   "function unk_lang_printstr called."));
-}
-
 static const struct op_print unk_op_print_tab[] =
 {
   {NULL, OP_NULL, PREC_NULL, 0}
@@ -772,7 +774,6 @@ extern const struct language_data unknown_language_data =
   macro_expansion_no,
   NULL,
   &exp_descriptor_standard,
-  unk_lang_printstr,
   default_print_typedef, /* Print a typedef using appropriate syntax */
   "this",             /* name_of_this */
   true, /* store_sym_names_in_linkage_form_p */
@@ -857,6 +858,16 @@ public:
   {
     error (_("unimplemented unknown_language::printchar called"));
   }
+
+  /* See language.h.  */
+
+  void printstr (struct ui_file *stream, struct type *elttype,
+ const gdb_byte *string, unsigned int length,
+ const char *encoding, int force_ellipses,
+ const struct value_print_options *options) const override
+  {
+    error (_("unimplemented unknown_language::printstr called"));
+  }
 };
 
 /* Single instance of the unknown language class.  */
@@ -876,7 +887,6 @@ extern const struct language_data auto_language_data =
   macro_expansion_no,
   NULL,
   &exp_descriptor_standard,
-  unk_lang_printstr,
   default_print_typedef, /* Print a typedef using appropriate syntax */
   "this",        /* name_of_this */
   false, /* store_sym_names_in_linkage_form_p */
@@ -961,6 +971,16 @@ public:
   {
     error (_("unimplemented auto_language::printchar called"));
   }
+
+  /* See language.h.  */
+
+  void printstr (struct ui_file *stream, struct type *elttype,
+ const gdb_byte *string, unsigned int length,
+ const char *encoding, int force_ellipses,
+ const struct value_print_options *options) const override
+  {
+    error (_("unimplemented auto_language::printstr called"));
+  }
 };
 
 /* Single instance of the fake "auto" language.  */
diff --git a/gdb/language.h b/gdb/language.h
index fc9efd8993..a68b6dfdca 100644
--- a/gdb/language.h
+++ b/gdb/language.h
@@ -225,11 +225,6 @@ struct language_data
 
     const struct exp_descriptor *la_exp_desc;
 
-    void (*la_printstr) (struct ui_file * stream, struct type *elttype,
- const gdb_byte *string, unsigned int length,
- const char *encoding, int force_ellipses,
- const struct value_print_options *);
-
     /* Print a typedef using syntax appropriate for this language.
        TYPE is the underlying type.  NEW_SYMBOL is the symbol naming
        the type.  STREAM is the output stream on which to print.  */
@@ -547,6 +542,16 @@ struct language_defn : language_data
   virtual void printchar (int ch, struct type *chtype,
   struct ui_file * stream) const;
 
+/* Print the character string STRING, printing at most LENGTH characters.
+   Printing stops early if the number hits print_max; repeat counts
+   are printed as appropriate.  Print ellipses at the end if we
+   had to stop before printing LENGTH characters, or if FORCE_ELLIPSES.  */
+
+  virtual void printstr (struct ui_file *stream, struct type *elttype,
+ const gdb_byte *string, unsigned int length,
+ const char *encoding, int force_ellipses,
+ const struct value_print_options *options) const;
+
 protected:
 
   /* This is the overridable part of the GET_SYMBOL_NAME_MATCHER method.
@@ -651,8 +656,8 @@ extern enum language set_language (enum language);
 #define LA_PRINT_CHAR(ch, type, stream) \
   (current_language->printchar (ch, type, stream))
 #define LA_PRINT_STRING(stream, elttype, string, length, encoding, force_ellipses, options) \
-  (current_language->la_printstr(stream, elttype, string, length, \
- encoding, force_ellipses,options))
+  (current_language->printstr (stream, elttype, string, length, \
+       encoding, force_ellipses,options))
 #define LA_EMIT_CHAR(ch, type, stream, quoter) \
   (current_language->emitchar (ch, type, stream, quoter))
 
diff --git a/gdb/m2-lang.c b/gdb/m2-lang.c
index bdb1a460ae..b84a9a49f8 100644
--- a/gdb/m2-lang.c
+++ b/gdb/m2-lang.c
@@ -42,86 +42,6 @@ m2_printchar (int c, struct type *type, struct ui_file *stream)
   fputs_filtered ("'", stream);
 }
 
-/* Print the character string STRING, printing at most LENGTH characters.
-   Printing stops early if the number hits print_max; repeat counts
-   are printed as appropriate.  Print ellipses at the end if we
-   had to stop before printing LENGTH characters, or if FORCE_ELLIPSES.
-   FIXME:  This is a copy of the same function from c-exp.y.  It should
-   be replaced with a true Modula version.  */
-
-static void
-m2_printstr (struct ui_file *stream, struct type *type, const gdb_byte *string,
-     unsigned int length, const char *encoding, int force_ellipses,
-     const struct value_print_options *options)
-{
-  unsigned int i;
-  unsigned int things_printed = 0;
-  int in_quotes = 0;
-  int need_comma = 0;
-
-  if (length == 0)
-    {
-      fputs_filtered ("\"\"", gdb_stdout);
-      return;
-    }
-
-  for (i = 0; i < length && things_printed < options->print_max; ++i)
-    {
-      /* Position of the character we are examining
-         to see whether it is repeated.  */
-      unsigned int rep1;
-      /* Number of repetitions we have detected so far.  */
-      unsigned int reps;
-
-      QUIT;
-
-      if (need_comma)
- {
-  fputs_filtered (", ", stream);
-  need_comma = 0;
- }
-
-      rep1 = i + 1;
-      reps = 1;
-      while (rep1 < length && string[rep1] == string[i])
- {
-  ++rep1;
-  ++reps;
- }
-
-      if (reps > options->repeat_count_threshold)
- {
-  if (in_quotes)
-    {
-      fputs_filtered ("\", ", stream);
-      in_quotes = 0;
-    }
-  m2_printchar (string[i], type, stream);
-  fprintf_filtered (stream, " <repeats %u times>", reps);
-  i = rep1 - 1;
-  things_printed += options->repeat_count_threshold;
-  need_comma = 1;
- }
-      else
- {
-  if (!in_quotes)
-    {
-      fputs_filtered ("\"", stream);
-      in_quotes = 1;
-    }
-  LA_EMIT_CHAR (string[i], type, stream, '"');
-  ++things_printed;
- }
-    }
-
-  /* Terminate the quotes if necessary.  */
-  if (in_quotes)
-    fputs_filtered ("\"", stream);
-
-  if (force_ellipses || i < length)
-    fputs_filtered ("...", stream);
-}
-
 /* Return true if TYPE is a string.  */
 
 static bool
@@ -309,7 +229,6 @@ extern const struct language_data m2_language_data =
   macro_expansion_no,
   NULL,
   &exp_descriptor_modula2,
-  m2_printstr, /* function to print string constant */
   m2_print_typedef, /* Print a typedef using appropriate syntax */
   NULL,                /* name_of_this */
   false, /* la_store_sym_names_in_linkage_form_p */
@@ -433,6 +352,81 @@ public:
   {
     m2_printchar (ch, chtype, stream);
   }
+
+  /* See language.h.  */
+
+  void printstr (struct ui_file *stream, struct type *elttype,
+ const gdb_byte *string, unsigned int length,
+ const char *encoding, int force_ellipses,
+ const struct value_print_options *options) const override
+  {
+    unsigned int i;
+    unsigned int things_printed = 0;
+    int in_quotes = 0;
+    int need_comma = 0;
+
+    if (length == 0)
+      {
+ fputs_filtered ("\"\"", gdb_stdout);
+ return;
+      }
+
+    for (i = 0; i < length && things_printed < options->print_max; ++i)
+      {
+ /* Position of the character we are examining
+   to see whether it is repeated.  */
+ unsigned int rep1;
+ /* Number of repetitions we have detected so far.  */
+ unsigned int reps;
+
+ QUIT;
+
+ if (need_comma)
+  {
+    fputs_filtered (", ", stream);
+    need_comma = 0;
+  }
+
+ rep1 = i + 1;
+ reps = 1;
+ while (rep1 < length && string[rep1] == string[i])
+  {
+    ++rep1;
+    ++reps;
+  }
+
+ if (reps > options->repeat_count_threshold)
+  {
+    if (in_quotes)
+      {
+ fputs_filtered ("\", ", stream);
+ in_quotes = 0;
+      }
+    m2_printchar (string[i], elttype, stream);
+    fprintf_filtered (stream, " <repeats %u times>", reps);
+    i = rep1 - 1;
+    things_printed += options->repeat_count_threshold;
+    need_comma = 1;
+  }
+ else
+  {
+    if (!in_quotes)
+      {
+ fputs_filtered ("\"", stream);
+ in_quotes = 1;
+      }
+    LA_EMIT_CHAR (string[i], elttype, stream, '"');
+    ++things_printed;
+  }
+      }
+
+    /* Terminate the quotes if necessary.  */
+    if (in_quotes)
+      fputs_filtered ("\"", stream);
+
+    if (force_ellipses || i < length)
+      fputs_filtered ("...", stream);
+  }
 };
 
 /* Single instance of the M2 language.  */
diff --git a/gdb/objc-lang.c b/gdb/objc-lang.c
index 736c868452..95c6c0a1fc 100644
--- a/gdb/objc-lang.c
+++ b/gdb/objc-lang.c
@@ -337,7 +337,6 @@ extern const struct language_data objc_language_data =
   macro_expansion_c,
   objc_extensions,
   &exp_descriptor_standard,
-  c_printstr,       /* Function to print string constant */
   c_print_typedef, /* Print a typedef using appropriate syntax */
   "self",        /* name_of_this */
   false, /* la_store_sym_names_in_linkage_form_p */
diff --git a/gdb/opencl-lang.c b/gdb/opencl-lang.c
index d66f3f8aec..765202aac0 100644
--- a/gdb/opencl-lang.c
+++ b/gdb/opencl-lang.c
@@ -1016,7 +1016,6 @@ extern const struct language_data opencl_language_data =
   macro_expansion_c,
   NULL,
   &exp_descriptor_opencl,
-  c_printstr, /* Function to print string constant */
   c_print_typedef, /* Print a typedef using appropriate syntax */
   NULL,                         /* name_of_this */
   false, /* la_store_sym_names_in_linkage_form_p */
diff --git a/gdb/p-lang.c b/gdb/p-lang.c
index b8c99c4650..1c6aea90b6 100644
--- a/gdb/p-lang.c
+++ b/gdb/p-lang.c
@@ -202,106 +202,6 @@ pascal_printchar (int c, struct type *type, struct ui_file *stream)
     fputs_filtered ("'", stream);
 }
 
-/* Print the character string STRING, printing at most LENGTH characters.
-   Printing stops early if the number hits print_max; repeat counts
-   are printed as appropriate.  Print ellipses at the end if we
-   had to stop before printing LENGTH characters, or if FORCE_ELLIPSES.  */
-
-void
-pascal_printstr (struct ui_file *stream, struct type *type,
- const gdb_byte *string, unsigned int length,
- const char *encoding, int force_ellipses,
- const struct value_print_options *options)
-{
-  enum bfd_endian byte_order = type_byte_order (type);
-  unsigned int i;
-  unsigned int things_printed = 0;
-  int in_quotes = 0;
-  int need_comma = 0;
-  int width;
-
-  /* Preserve TYPE's original type, just set its LENGTH.  */
-  check_typedef (type);
-  width = TYPE_LENGTH (type);
-
-  /* If the string was not truncated due to `set print elements', and
-     the last byte of it is a null, we don't print that, in traditional C
-     style.  */
-  if ((!force_ellipses) && length > 0
- && extract_unsigned_integer (string + (length - 1) * width, width,
-     byte_order) == 0)
-    length--;
-
-  if (length == 0)
-    {
-      fputs_filtered ("''", stream);
-      return;
-    }
-
-  for (i = 0; i < length && things_printed < options->print_max; ++i)
-    {
-      /* Position of the character we are examining
-         to see whether it is repeated.  */
-      unsigned int rep1;
-      /* Number of repetitions we have detected so far.  */
-      unsigned int reps;
-      unsigned long int current_char;
-
-      QUIT;
-
-      if (need_comma)
- {
-  fputs_filtered (", ", stream);
-  need_comma = 0;
- }
-
-      current_char = extract_unsigned_integer (string + i * width, width,
-       byte_order);
-
-      rep1 = i + 1;
-      reps = 1;
-      while (rep1 < length
-     && extract_unsigned_integer (string + rep1 * width, width,
-  byte_order) == current_char)
- {
-  ++rep1;
-  ++reps;
- }
-
-      if (reps > options->repeat_count_threshold)
- {
-  if (in_quotes)
-    {
-      fputs_filtered ("', ", stream);
-      in_quotes = 0;
-    }
-  pascal_printchar (current_char, type, stream);
-  fprintf_filtered (stream, " %p[<repeats %u times>%p]",
-    metadata_style.style ().ptr (),
-    reps, nullptr);
-  i = rep1 - 1;
-  things_printed += options->repeat_count_threshold;
-  need_comma = 1;
- }
-      else
- {
-  if ((!in_quotes) && (PRINT_LITERAL_FORM (current_char)))
-    {
-      fputs_filtered ("'", stream);
-      in_quotes = 1;
-    }
-  pascal_one_char (current_char, stream, &in_quotes);
-  ++things_printed;
- }
-    }
-
-  /* Terminate the quotes if necessary.  */
-  if (in_quotes)
-    fputs_filtered ("'", stream);
-
-  if (force_ellipses || i < length)
-    fputs_filtered ("...", stream);
-}
 
 
 /* Table mapping opcodes into strings for printing operators
@@ -376,7 +276,6 @@ extern const struct language_data pascal_language_data =
   macro_expansion_no,
   p_extensions,
   &exp_descriptor_standard,
-  pascal_printstr, /* Function to print string constant */
   pascal_print_typedef, /* Print a typedef using appropriate syntax */
   "this",        /* name_of_this */
   false, /* la_store_sym_names_in_linkage_form_p */
@@ -499,6 +398,102 @@ public:
     pascal_printchar (ch, chtype, stream);
   }
 
+  /* See language.h.  */
+
+  void printstr (struct ui_file *stream, struct type *elttype,
+ const gdb_byte *string, unsigned int length,
+ const char *encoding, int force_ellipses,
+ const struct value_print_options *options) const override
+  {
+    enum bfd_endian byte_order = type_byte_order (elttype);
+    unsigned int i;
+    unsigned int things_printed = 0;
+    int in_quotes = 0;
+    int need_comma = 0;
+    int width;
+
+    /* Preserve ELTTYPE's original type, just set its LENGTH.  */
+    check_typedef (elttype);
+    width = TYPE_LENGTH (elttype);
+
+    /* If the string was not truncated due to `set print elements', and
+       the last byte of it is a null, we don't print that, in traditional C
+       style.  */
+    if ((!force_ellipses) && length > 0
+ && extract_unsigned_integer (string + (length - 1) * width, width,
+     byte_order) == 0)
+      length--;
+
+    if (length == 0)
+      {
+ fputs_filtered ("''", stream);
+ return;
+      }
+
+    for (i = 0; i < length && things_printed < options->print_max; ++i)
+      {
+ /* Position of the character we are examining
+   to see whether it is repeated.  */
+ unsigned int rep1;
+ /* Number of repetitions we have detected so far.  */
+ unsigned int reps;
+ unsigned long int current_char;
+
+ QUIT;
+
+ if (need_comma)
+  {
+    fputs_filtered (", ", stream);
+    need_comma = 0;
+  }
+
+ current_char = extract_unsigned_integer (string + i * width, width,
+ byte_order);
+
+ rep1 = i + 1;
+ reps = 1;
+ while (rep1 < length
+       && extract_unsigned_integer (string + rep1 * width, width,
+    byte_order) == current_char)
+  {
+    ++rep1;
+    ++reps;
+  }
+
+ if (reps > options->repeat_count_threshold)
+  {
+    if (in_quotes)
+      {
+ fputs_filtered ("', ", stream);
+ in_quotes = 0;
+      }
+    pascal_printchar (current_char, elttype, stream);
+    fprintf_filtered (stream, " %p[<repeats %u times>%p]",
+      metadata_style.style ().ptr (),
+      reps, nullptr);
+    i = rep1 - 1;
+    things_printed += options->repeat_count_threshold;
+    need_comma = 1;
+  }
+ else
+  {
+    if ((!in_quotes) && (PRINT_LITERAL_FORM (current_char)))
+      {
+ fputs_filtered ("'", stream);
+ in_quotes = 1;
+      }
+    pascal_one_char (current_char, stream, &in_quotes);
+    ++things_printed;
+  }
+      }
+
+    /* Terminate the quotes if necessary.  */
+    if (in_quotes)
+      fputs_filtered ("'", stream);
+
+    if (force_ellipses || i < length)
+      fputs_filtered ("...", stream);
+  }
 };
 
 /* Single instance of the Pascal language class.  */
diff --git a/gdb/p-lang.h b/gdb/p-lang.h
index 9ce6131876..3eaad015a6 100644
--- a/gdb/p-lang.h
+++ b/gdb/p-lang.h
@@ -56,10 +56,6 @@ extern int
 
 extern void pascal_printchar (int, struct type *, struct ui_file *);
 
-extern void pascal_printstr (struct ui_file *, struct type *, const gdb_byte *,
-     unsigned int, const char *, int,
-     const struct value_print_options *);
-
 extern struct type **const pascal_builtin_types[];
 
 /* These are in p-typeprint.c: */
diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c
index 36e26179f3..b13623fe61 100644
--- a/gdb/rust-lang.c
+++ b/gdb/rust-lang.c
@@ -281,7 +281,7 @@ rust_get_trait_object_pointer (struct value *value)
 
 
 
-/* la_printstr implementation for Rust.  */
+/* language_defn::printstr implementation for Rust.  */
 
 static void
 rust_printstr (struct ui_file *stream, struct type *type,
@@ -1953,7 +1953,6 @@ extern const struct language_data rust_language_data =
   macro_expansion_no,
   rust_extensions,
   &exp_descriptor_rust,
-  rust_printstr, /* Function to print string constant */
   rust_print_typedef, /* Print a typedef using appropriate syntax */
   NULL, /* name_of_this */
   false, /* la_store_sym_names_in_linkage_form_p */
@@ -2145,6 +2144,17 @@ public:
     LA_EMIT_CHAR (ch, chtype, stream, '\'');
     fputs_filtered ("'", stream);
   }
+
+  /* See language.h.  */
+
+  void printstr (struct ui_file *stream, struct type *elttype,
+ const gdb_byte *string, unsigned int length,
+ const char *encoding, int force_ellipses,
+ const struct value_print_options *options) const override
+  {
+    rust_printstr (stream, elttype, string, length, encoding,
+   force_ellipses, options);
+  }
 };
 
 /* Single instance of the Rust language class.  */
Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

Sourceware - gdb-testers mailing list
Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/5/builds/3142

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        d711ee67aca06c9753f09dc154eb8c75cb4f58ef

Subject of commit:
        gdb: Convert language la_printstr field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

Sourceware - gdb-testers mailing list
In reply to this post by Sourceware - gdb-testers mailing list
Buildername:
        Ubuntu-Aarch64-native-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/19/builds/3183

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        d711ee67aca06c9753f09dc154eb8c75cb4f58ef

Subject of commit:
        gdb: Convert language la_printstr field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

*** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE ***

gdb-buildbot-2
In reply to this post by Sourceware - gdb-testers mailing list
Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/18/builds/3547

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        d711ee67aca06c9753f09dc154eb8c75cb4f58ef

Subject of commit:
        gdb: Convert language la_printstr field to a method

*** FAILED to build GDB -- compile gdb ***
==============================================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    user-regs.o
  CXX    utils.o
  CXX    v850-tdep.o
  CXX    valarith.o
  CXX    valops.o
  CXX    valprint.o
  CXX    value.o
  CXX    varobj.o
  CXX    vax-nbsd-tdep.o
  CXX    vax-tdep.o
  GEN    stamp-version
  CXX    windows-tdep.o
  CXX    x86-linux-nat.o
  CXX    x86-nat.o
  CXX    x86-tdep.o
  CXX    xcoffread.o
  GEN    xml-builtin.c
  CXX    xml-support.o
  CXX    xml-syscall.o
  CXX    xml-tdesc.o
  CXX    xstormy16-tdep.o
  CXX    xtensa-config.o
  CXX    xtensa-linux-tdep.o
  CXX    xtensa-tdep.o
  CXX    gdb.o
  CXX    aarch32-tdep.o
  CXX    ada-exp.o
  CXX    ada-lang.o
  CXX    ada-tasks.o
  CXX    ada-typeprint.o
  CXX    ada-valprint.o
  CXX    ada-varobj.o
  CXX    addrmap.o
  CXX    agent.o
  CXX    alloc.o
  CXX    annotate.o
  CXX    arc-tdep.o
  CXX    arch-utils.o
  CXX    arch/aarch32.o
  CXX    arch/arc.o
  CXX    arch/arm-get-next-pcs.o
  CXX    arch/arm-linux.o
  CXX    arch/arm.o
  CXX    arch/i386.o
  CXX    arch/ppc-linux-common.o
  CXX    arch/riscv.o
  CXX    arm-bsd-tdep.o
  CXX    arm-fbsd-tdep.o
  CXX    arm-linux-tdep.o
  CXX    arm-nbsd-tdep.o
  CXX    arm-obsd-tdep.o
  CXX    arm-pikeos-tdep.o
  CXX    arm-symbian-tdep.o
  CXX    arm-tdep.o
  CXX    arm-wince-tdep.o
  CXX    async-event.o
  CXX    auto-load.o
  CXX    auxv.o
  CXX    avr-tdep.o
  CXX    ax-gdb.o
  CXX    ax-general.o
  CXX    bcache.o
  CXX    bfd-target.o
  CXX    bfin-linux-tdep.o
  CXX    bfin-tdep.o
  CXX    block.o
  CXX    blockframe.o
  CXX    break-catch-sig.o
  CXX    break-catch-syscall.o
  CXX    break-catch-throw.o
  CXX    breakpoint.o
  CXX    bsd-uthread.o
  CXX    btrace.o
  CXX    build-id.o
  CXX    buildsym-legacy.o
  CXX    buildsym.o
  CXX    c-exp.o
  CXX    cp-name-parser.o
  CXX    d-exp.o
  CXX    f-exp.o
  CXX    go-exp.o
  CXX    m2-exp.o
  CXX    p-exp.o
  CXX    rust-exp.o
  CXX    version.o
  CXX    xml-builtin.o
  GEN    init.c
  CXX    init.o
  CXXLD  gdb
/usr/bin/ld: ../opcodes/libopcodes.a(riscv-dis.o): in function `parse_riscv_dis_option':
/home/gdb-buildbot-2/fedora-x86-64-4/fedora-i686/build/opcodes/../../binutils-gdb/opcodes/riscv-dis.c:102: undefined reference to `riscv_get_priv_spec_class'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:1861: gdb] Error 1
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-i686/build/gdb'
make[1]: *** [Makefile:10066: all-gdb] Error 2
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-i686/build'
make: *** [Makefile:854: all] Error 2
program finished with exit code 2
elapsedTime=473.234062
==============================================

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-cc-with-index, branch master

gdb-buildbot-2
In reply to this post by Sourceware - gdb-testers mailing list
Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/20/builds/3495

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        d711ee67aca06c9753f09dc154eb8c75cb4f58ef

Subject of commit:
        gdb: Convert language la_printstr field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/options.exp: test-print: cmd complete "frame apply all print "
PASS -> FAIL: gdb.base/options.exp: test-print: tab complete "frame apply all print "
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m32, branch master

gdb-buildbot-2
In reply to this post by Sourceware - gdb-testers mailing list
Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/17/builds/3541

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        d711ee67aca06c9753f09dc154eb8c75cb4f58ef

Subject of commit:
        gdb: Convert language la_printstr field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Private-Anonymous: no binary: loading /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-private-anon.gcore
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Shared-Anonymous: loading /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
new KFAIL: gdb.base/step-over-syscall.exp: clone: displaced=on: single step over clone
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m64, branch master

gdb-buildbot-2
In reply to this post by Sourceware - gdb-testers mailing list
Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/3/builds/3604

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        d711ee67aca06c9753f09dc154eb8c75cb4f58ef

Subject of commit:
        gdb: Convert language la_printstr field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print j
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

gdb-buildbot-2
In reply to this post by Sourceware - gdb-testers mailing list
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/4/builds/3437

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        d711ee67aca06c9753f09dc154eb8c75cb4f58ef

Subject of commit:
        gdb: Convert language la_printstr field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.fortran/vla-ptype.exp: ptype vla1
PASS -> FAIL: gdb.fortran/vla-value.exp: print member in non-allocated vla1
PASS -> FAIL: gdb.fortran/vla-value.exp: set member in non-allocated vla1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 10: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 10: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 10: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 4: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 4: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 4: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 4: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 4: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: reset timer in the inferior
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

gdb-buildbot-2
In reply to this post by Sourceware - gdb-testers mailing list
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/2/builds/3438

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        d711ee67aca06c9753f09dc154eb8c75cb4f58ef

Subject of commit:
        gdb: Convert language la_printstr field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: print re_run_var_1
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
new FAIL: gdb.threads/attach-into-signal.exp: threaded: thread apply 2 print $_siginfo.si_signo
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

gdb-buildbot-2
In reply to this post by Sourceware - gdb-testers mailing list
Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/24/builds/3450

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        d711ee67aca06c9753f09dc154eb8c75cb4f58ef

Subject of commit:
        gdb: Convert language la_printstr field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

gdb-buildbot-2
In reply to this post by Sourceware - gdb-testers mailing list
Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/22/builds/3449

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        d711ee67aca06c9753f09dc154eb8c75cb4f58ef

Subject of commit:
        gdb: Convert language la_printstr field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: print re_run_var_2
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: setting breakpoint at all_started
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print j
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> FAIL: gdb.trace/mi-tsv-changed.exp: create delete modify: tvariable $tvar3 modified
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/d7/d711ee67aca06c9753f09dc154eb8c75cb4f58ef//xfail.table.gz>