[binutils-gdb] gdb: Convert language la_is_string_type_p field to a method

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] gdb: Convert language la_is_string_type_p field to a method

gdb-buildbot-2
*** TEST RESULTS FOR COMMIT 39e7eccae602562368438c955b31f1d0e37feaa5 ***

commit 39e7eccae602562368438c955b31f1d0e37feaa5
Author:     Andrew Burgess <[hidden email]>
AuthorDate: Thu Jun 18 22:01:33 2020 +0100
Commit:     Andrew Burgess <[hidden email]>
CommitDate: Tue Jun 23 13:34:11 2020 +0100

    gdb: Convert language la_is_string_type_p field to a method
   
    This commit changes the language_data::la_is_string_type_p function
    pointer member variable into a member function of language_defn.
   
    There should be no user visible changes after this commit.
   
    gdb/ChangeLog:
   
            * ada-lang.c (ada_language_data): Delete la_is_string_type_p
            initializer.
            (ada_language::is_string_type_p): New member function.
            * c-lang.c (c_language_data): Delete la_is_string_type_p
            initializer.
            (cplus_language_data): Likewise.
            (asm_language_data): Likewise.
            (minimal_language_data): Likewise.
            * d-lang.c (d_language_data): Likewise.
            * f-lang.c (f_is_string_type_p): Delete function, implementation
            moved to f_language::is_string_type_p.
            (f_language_data): Delete la_is_string_type_p initializer.
            (f_language::is_string_type_p): New member function,
            implementation from f_is_string_type_p.
            * go-lang.c (go_is_string_type_p): Delete function, implementation
            moved to go_language::is_string_type_p.
            (go_language_data): Delete la_is_string_type_p initializer.
            (go_language::is_string_type_p): New member function,
            implementation from go_is_string_type_p.
            * language.c (language_defn::is_string_type_p): Define new member
            function.
            (default_is_string_type_p): Make static, add comment copied from
            header file.
            (unknown_language_data): Delete la_is_string_type_p initializer.
            (unknown_language::is_string_type_p): New member function.
            (auto_language_data): Delete la_is_string_type_p initializer.
            (auto_language::is_string_type_p): New member function.
            * language.h (language_data): Delete la_is_string_type_p field.
            (language_defn::is_string_type_p): Declare new function.
            (default_is_string_type_p): Delete desclaration, move comment to
            definition.
            * m2-lang.c (m2_is_string_type_p): Delete function, implementation
            moved to m2_language::is_string_type_p.
            (m2_language_data): Delete la_is_string_type_p initializer.
            (m2_language::is_string_type_p): New member function,
            implementation from m2_is_string_type_p.
            * objc-lang.c (objc_language_data): Delete la_is_string_type_p
            initializer.
            * opencl-lang.c (opencl_language_data): Likewise.
            * p-lang.c (pascal_is_string_type_p): Delete function,
            implementation moved to pascal_language::is_string_type_p.
            (pascal_language_data): Delete la_is_string_type_p initializer.
            (pascal_language::is_string_type_p): New member function,
            implementation from pascal_is_string_type_p.
            * rust-lang.c (rust_is_string_type_p): Delete function,
            implementation moved to rust_language::is_string_type_p.
            (rust_language_data): Delete la_is_string_type_p initializer.
            (rust_language::is_string_type_p): New member function,
            implementation from rust_is_string_type_p.
            * valprint.c (val_print_scalar_or_string_type_p): Update call to
            is_string_type_p.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index de348bb477..af34af84e3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,57 @@
+2020-06-23  Andrew Burgess  <[hidden email]>
+
+ * ada-lang.c (ada_language_data): Delete la_is_string_type_p
+ initializer.
+ (ada_language::is_string_type_p): New member function.
+ * c-lang.c (c_language_data): Delete la_is_string_type_p
+ initializer.
+ (cplus_language_data): Likewise.
+ (asm_language_data): Likewise.
+ (minimal_language_data): Likewise.
+ * d-lang.c (d_language_data): Likewise.
+ * f-lang.c (f_is_string_type_p): Delete function, implementation
+ moved to f_language::is_string_type_p.
+ (f_language_data): Delete la_is_string_type_p initializer.
+ (f_language::is_string_type_p): New member function,
+ implementation from f_is_string_type_p.
+ * go-lang.c (go_is_string_type_p): Delete function, implementation
+ moved to go_language::is_string_type_p.
+ (go_language_data): Delete la_is_string_type_p initializer.
+ (go_language::is_string_type_p): New member function,
+ implementation from go_is_string_type_p.
+ * language.c (language_defn::is_string_type_p): Define new member
+ function.
+ (default_is_string_type_p): Make static, add comment copied from
+ header file.
+ (unknown_language_data): Delete la_is_string_type_p initializer.
+ (unknown_language::is_string_type_p): New member function.
+ (auto_language_data): Delete la_is_string_type_p initializer.
+ (auto_language::is_string_type_p): New member function.
+ * language.h (language_data): Delete la_is_string_type_p field.
+ (language_defn::is_string_type_p): Declare new function.
+ (default_is_string_type_p): Delete desclaration, move comment to
+ definition.
+ * m2-lang.c (m2_is_string_type_p): Delete function, implementation
+ moved to m2_language::is_string_type_p.
+ (m2_language_data): Delete la_is_string_type_p initializer.
+ (m2_language::is_string_type_p): New member function,
+ implementation from m2_is_string_type_p.
+ * objc-lang.c (objc_language_data): Delete la_is_string_type_p
+ initializer.
+ * opencl-lang.c (opencl_language_data): Likewise.
+ * p-lang.c (pascal_is_string_type_p): Delete function,
+ implementation moved to pascal_language::is_string_type_p.
+ (pascal_language_data): Delete la_is_string_type_p initializer.
+ (pascal_language::is_string_type_p): New member function,
+ implementation from pascal_is_string_type_p.
+ * rust-lang.c (rust_is_string_type_p): Delete function,
+ implementation moved to rust_language::is_string_type_p.
+ (rust_language_data): Delete la_is_string_type_p initializer.
+ (rust_language::is_string_type_p): New member function,
+ implementation from rust_is_string_type_p.
+ * valprint.c (val_print_scalar_or_string_type_p): Update call to
+ is_string_type_p.
+
 2020-06-23  Andrew Burgess  <[hidden email]>
 
  * ada-lang.c (ada_language_data): Delete la_print_typedef
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 752bf44cef..9b0c2efbfe 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -13687,7 +13687,6 @@ extern const struct language_data ada_language_data =
   0,                            /* c-style arrays */
   1,                            /* String lower bound */
   &ada_varobj_ops,
-  ada_is_string_type,
   "(...)" /* la_struct_too_deep_ellipsis */
 };
 
@@ -14139,6 +14138,14 @@ public:
     ada_print_typedef (type, new_symbol, stream);
   }
 
+  /* See language.h.  */
+
+  bool is_string_type_p (struct type *type) const override
+  {
+    return ada_is_string_type (type);
+  }
+
+
 protected:
   /* See language.h.  */
 
diff --git a/gdb/c-lang.c b/gdb/c-lang.c
index aca0d7a6bc..f29f2cef61 100644
--- a/gdb/c-lang.c
+++ b/gdb/c-lang.c
@@ -895,7 +895,6 @@ extern const struct language_data c_language_data =
   1, /* c-style arrays */
   0, /* String lower bound */
   &c_varobj_ops,
-  c_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
@@ -997,7 +996,6 @@ extern const struct language_data cplus_language_data =
   1, /* c-style arrays */
   0, /* String lower bound */
   &cplus_varobj_ops,
-  c_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
@@ -1196,7 +1194,6 @@ extern const struct language_data asm_language_data =
   1, /* c-style arrays */
   0, /* String lower bound */
   &default_varobj_ops,
-  c_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
@@ -1253,7 +1250,6 @@ extern const struct language_data minimal_language_data =
   1, /* c-style arrays */
   0, /* String lower bound */
   &default_varobj_ops,
-  c_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
diff --git a/gdb/d-lang.c b/gdb/d-lang.c
index b907dd750e..4ebb011ee9 100644
--- a/gdb/d-lang.c
+++ b/gdb/d-lang.c
@@ -148,7 +148,6 @@ extern const struct language_data d_language_data =
   1, /* C-style arrays.  */
   0, /* String lower bound.  */
   &default_varobj_ops,
-  c_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
diff --git a/gdb/f-lang.c b/gdb/f-lang.c
index 946d5bc25a..58b41d11d1 100644
--- a/gdb/f-lang.c
+++ b/gdb/f-lang.c
@@ -291,17 +291,6 @@ evaluate_subexp_f (struct type *expect_type, struct expression *exp,
   return nullptr;
 }
 
-/* Return true if TYPE is a string.  */
-
-static bool
-f_is_string_type_p (struct type *type)
-{
-  type = check_typedef (type);
-  return (type->code () == TYPE_CODE_STRING
-  || (type->code () == TYPE_CODE_ARRAY
-      && TYPE_TARGET_TYPE (type)->code () == TYPE_CODE_CHAR));
-}
-
 /* Special expression lengths for Fortran.  */
 
 static void
@@ -519,7 +508,6 @@ extern const struct language_data f_language_data =
   0, /* arrays are first-class (not c-style) */
   1, /* String lower bound */
   &default_varobj_ops,
-  f_is_string_type_p,
   "(...)" /* la_struct_too_deep_ellipsis */
 };
 
@@ -709,6 +697,16 @@ public:
     f_print_typedef (type, new_symbol, stream);
   }
 
+  /* See language.h.  */
+
+  bool is_string_type_p (struct type *type) const override
+  {
+    type = check_typedef (type);
+    return (type->code () == TYPE_CODE_STRING
+    || (type->code () == TYPE_CODE_ARRAY
+ && TYPE_TARGET_TYPE (type)->code () == TYPE_CODE_CHAR));
+  }
+
 protected:
 
   /* See language.h.  */
diff --git a/gdb/go-lang.c b/gdb/go-lang.c
index fa263997b1..cb42ef1b7c 100644
--- a/gdb/go-lang.c
+++ b/gdb/go-lang.c
@@ -131,16 +131,6 @@ go_classify_struct_type (struct type *type)
   return GO_TYPE_NONE;
 }
 
-/* Return true if TYPE is a string.  */
-
-static bool
-go_is_string_type_p (struct type *type)
-{
-  type = check_typedef (type);
-  return (type->code () == TYPE_CODE_STRUCT
-  && go_classify_struct_type (type) == GO_TYPE_STRING);
-}
-
 /* Subroutine of unpack_mangled_go_symbol to simplify it.
    Given "[foo.]bar.baz", store "bar" in *PACKAGEP and "baz" in *OBJECTP.
    We stomp on the last '.' to nul-terminate "bar".
@@ -533,7 +523,6 @@ extern const struct language_data go_language_data =
   1, /* C-style arrays.  */
   0, /* String lower bound.  */
   &default_varobj_ops,
-  go_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
@@ -638,6 +627,16 @@ public:
   {
     return go_parse (ps);
   }
+
+  /* See language.h.  */
+
+  bool is_string_type_p (struct type *type) const override
+  {
+    type = check_typedef (type);
+    return (type->code () == TYPE_CODE_STRUCT
+    && go_classify_struct_type (type) == GO_TYPE_STRING);
+  }
+
 };
 
 /* Single instance of the Go language class.  */
diff --git a/gdb/language.c b/gdb/language.c
index 5ae8c46879..c993cfc57a 100644
--- a/gdb/language.c
+++ b/gdb/language.c
@@ -690,6 +690,14 @@ language_defn::print_typedef (struct type *type, struct symbol *new_symbol,
   c_print_typedef (type, new_symbol, stream);
 }
 
+/* See language.h.  */
+
+bool
+language_defn::is_string_type_p (struct type *type) const
+{
+  return c_is_string_type_p (type);
+}
+
 /* The default implementation of the get_symbol_name_matcher_inner method
    from the language_defn class.  Matches with strncmp_iw.  */
 
@@ -741,9 +749,10 @@ language_defn::get_symbol_name_matcher_inner
   return default_symbol_name_matcher;
 }
 
-/* See language.h.  */
+/* Return true if TYPE is a string type, otherwise return false.  This
+   default implementation only detects TYPE_CODE_STRING.  */
 
-bool
+static bool
 default_is_string_type_p (struct type *type)
 {
   type = check_typedef (type);
@@ -789,7 +798,6 @@ extern const struct language_data unknown_language_data =
   1, /* c-style arrays */
   0, /* String lower bound */
   &default_varobj_ops,
-  default_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
@@ -884,6 +892,13 @@ public:
   {
     error (_("unimplemented unknown_language::print_typedef called"));
   }
+
+  /* See language.h.  */
+
+  bool is_string_type_p (struct type *type) const override
+  {
+    return default_is_string_type_p (type);
+  }
 };
 
 /* Single instance of the unknown language class.  */
@@ -909,7 +924,6 @@ extern const struct language_data auto_language_data =
   1, /* c-style arrays */
   0, /* String lower bound */
   &default_varobj_ops,
-  default_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
@@ -1004,6 +1018,13 @@ public:
   {
     error (_("unimplemented auto_language::print_typedef called"));
   }
+
+  /* See language.h.  */
+
+  bool is_string_type_p (struct type *type) const override
+  {
+    return default_is_string_type_p (type);
+  }
 };
 
 /* Single instance of the fake "auto" language.  */
diff --git a/gdb/language.h b/gdb/language.h
index 19cd820571..d2e5b73307 100644
--- a/gdb/language.h
+++ b/gdb/language.h
@@ -267,9 +267,6 @@ struct language_data
     /* Various operations on varobj.  */
     const struct lang_varobj_ops *la_varobj_ops;
 
-    /* Return true if TYPE is a string type.  */
-    bool (*la_is_string_type_p) (struct type *type);
-
     /* This string is used by the 'set print max-depth' setting.  When GDB
        replaces a struct or union (during value printing) that is "too
        deep" this string is displayed instead.  */
@@ -553,6 +550,9 @@ struct language_defn : language_data
   virtual void print_typedef (struct type *type, struct symbol *new_symbol,
       struct ui_file *stream) const;
 
+  /* Return true if TYPE is a string type.  */
+  virtual bool is_string_type_p (struct type *type) const;
+
 protected:
 
   /* This is the overridable part of the GET_SYMBOL_NAME_MATCHER method.
@@ -684,10 +684,6 @@ extern enum language set_language (enum language);
 
 extern int pointer_type (struct type *);
 
-/* Return true if TYPE is a string type, otherwise return false.  This
-   default implementation only detects TYPE_CODE_STRING.  */
-extern bool default_is_string_type_p (struct type *type);
-
 /* Error messages */
 
 extern void range_error (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
diff --git a/gdb/m2-lang.c b/gdb/m2-lang.c
index f0f7c22fb5..2c39359d28 100644
--- a/gdb/m2-lang.c
+++ b/gdb/m2-lang.c
@@ -42,27 +42,6 @@ m2_printchar (int c, struct type *type, struct ui_file *stream)
   fputs_filtered ("'", stream);
 }
 
-/* Return true if TYPE is a string.  */
-
-static bool
-m2_is_string_type_p (struct type *type)
-{
-  type = check_typedef (type);
-  if (type->code () == TYPE_CODE_ARRAY
-      && TYPE_LENGTH (type) > 0
-      && TYPE_LENGTH (TYPE_TARGET_TYPE (type)) > 0)
-    {
-      struct type *elttype = check_typedef (TYPE_TARGET_TYPE (type));
-
-      if (TYPE_LENGTH (elttype) == 1
-  && (elttype->code () == TYPE_CODE_INT
-      || elttype->code () == TYPE_CODE_CHAR))
- return true;
-    }
-
-  return false;
-}
-
 static struct value *
 evaluate_subexp_modula2 (struct type *expect_type, struct expression *exp,
  int *pos, enum noside noside)
@@ -235,7 +214,6 @@ extern const struct language_data m2_language_data =
   0, /* arrays are first-class (not c-style) */
   0, /* String lower bound */
   &default_varobj_ops,
-  m2_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
@@ -435,6 +413,25 @@ public:
     m2_print_typedef (type, new_symbol, stream);
   }
 
+  /* See language.h.  */
+
+  bool is_string_type_p (struct type *type) const override
+  {
+    type = check_typedef (type);
+    if (type->code () == TYPE_CODE_ARRAY
+ && TYPE_LENGTH (type) > 0
+ && TYPE_LENGTH (TYPE_TARGET_TYPE (type)) > 0)
+      {
+ struct type *elttype = check_typedef (TYPE_TARGET_TYPE (type));
+
+ if (TYPE_LENGTH (elttype) == 1
+    && (elttype->code () == TYPE_CODE_INT
+ || elttype->code () == TYPE_CODE_CHAR))
+  return true;
+      }
+
+    return false;
+  }
 };
 
 /* Single instance of the M2 language.  */
diff --git a/gdb/objc-lang.c b/gdb/objc-lang.c
index 0c952730a9..63cdac1b03 100644
--- a/gdb/objc-lang.c
+++ b/gdb/objc-lang.c
@@ -343,7 +343,6 @@ extern const struct language_data objc_language_data =
   1, /* C-style arrays */
   0, /* String lower bound */
   &default_varobj_ops,
-  c_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
diff --git a/gdb/opencl-lang.c b/gdb/opencl-lang.c
index 2431faed00..eccf1df962 100644
--- a/gdb/opencl-lang.c
+++ b/gdb/opencl-lang.c
@@ -1022,7 +1022,6 @@ extern const struct language_data opencl_language_data =
   1, /* c-style arrays */
   0, /* String lower bound */
   &default_varobj_ops,
-  c_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
diff --git a/gdb/p-lang.c b/gdb/p-lang.c
index 9fd823185b..07afbdda5b 100644
--- a/gdb/p-lang.c
+++ b/gdb/p-lang.c
@@ -152,16 +152,6 @@ is_pascal_string_type (struct type *type,int *length_pos,
   return 0;
 }
 
-/* This is a wrapper around IS_PASCAL_STRING_TYPE that returns true if TYPE
-   is a string.  */
-
-static bool
-pascal_is_string_type_p (struct type *type)
-{
-  return is_pascal_string_type (type, nullptr, nullptr, nullptr,
- nullptr, nullptr) > 0;
-}
-
 static void pascal_one_char (int, struct ui_file *, int *);
 
 /* Print the character C on STREAM as part of the contents of a literal
@@ -282,7 +272,6 @@ extern const struct language_data pascal_language_data =
   1, /* c-style arrays */
   0, /* String lower bound */
   &default_varobj_ops,
-  pascal_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
@@ -502,6 +491,13 @@ public:
     pascal_print_typedef (type, new_symbol, stream);
   }
 
+  /* See language.h.  */
+
+  bool is_string_type_p (struct type *type) const override
+  {
+    return is_pascal_string_type (type, nullptr, nullptr, nullptr,
+  nullptr, nullptr) > 0;
+  }
 };
 
 /* Single instance of the Pascal language class.  */
diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c
index 083b3f7327..d1efea19e9 100644
--- a/gdb/rust-lang.c
+++ b/gdb/rust-lang.c
@@ -226,26 +226,6 @@ rust_chartype_p (struct type *type)
   && TYPE_UNSIGNED (type));
 }
 
-/* Return true if TYPE is a string type.  */
-
-static bool
-rust_is_string_type_p (struct type *type)
-{
-  LONGEST low_bound, high_bound;
-
-  type = check_typedef (type);
-  return ((type->code () == TYPE_CODE_STRING)
-  || (type->code () == TYPE_CODE_PTR
-      && (TYPE_TARGET_TYPE (type)->code () == TYPE_CODE_ARRAY
-  && rust_u8_type_p (TYPE_TARGET_TYPE (TYPE_TARGET_TYPE (type)))
-  && get_array_bounds (TYPE_TARGET_TYPE (type), &low_bound,
-       &high_bound)))
-  || (type->code () == TYPE_CODE_STRUCT
-      && !rust_enum_p (type)
-      && rust_slice_type_p (type)
-      && strcmp (type->name (), "&str") == 0));
-}
-
 /* If VALUE represents a trait object pointer, return the underlying
    pointer with the correct (i.e., runtime) type.  Otherwise, return
    NULL.  */
@@ -1946,7 +1926,6 @@ extern const struct language_data rust_language_data =
   1, /* c-style arrays */
   0, /* String lower bound */
   &default_varobj_ops,
-  rust_is_string_type_p,
   "{...}" /* la_struct_too_deep_ellipsis */
 };
 
@@ -2152,6 +2131,25 @@ public:
     type_print (type, "", stream, 0);
     fprintf_filtered (stream, ";");
   }
+
+  /* See language.h.  */
+
+  bool is_string_type_p (struct type *type) const override
+  {
+    LONGEST low_bound, high_bound;
+
+    type = check_typedef (type);
+    return ((type->code () == TYPE_CODE_STRING)
+    || (type->code () == TYPE_CODE_PTR
+ && (TYPE_TARGET_TYPE (type)->code () == TYPE_CODE_ARRAY
+    && rust_u8_type_p (TYPE_TARGET_TYPE (TYPE_TARGET_TYPE (type)))
+    && get_array_bounds (TYPE_TARGET_TYPE (type), &low_bound,
+ &high_bound)))
+    || (type->code () == TYPE_CODE_STRUCT
+ && !rust_enum_p (type)
+ && rust_slice_type_p (type)
+ && strcmp (type->name (), "&str") == 0));
+  }
 };
 
 /* Single instance of the Rust language class.  */
diff --git a/gdb/valprint.c b/gdb/valprint.c
index 51c77c3e6d..db98ca2abc 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -298,7 +298,7 @@ val_print_scalar_or_string_type_p (struct type *type,
    const struct language_defn *language)
 {
   return (val_print_scalar_type_p (type)
-  || language->la_is_string_type_p (type));
+  || language->is_string_type_p (type));
 }
 
 /* See its definition in value.h.  */
Reply | Threaded
Open this post in threaded view
|

*** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE ***

gdb-buildbot-2
Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/18/builds/3549

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        39e7eccae602562368438c955b31f1d0e37feaa5

Subject of commit:
        gdb: Convert language la_is_string_type_p field to a method

*** FAILED to build GDB -- compile gdb ***
==============================================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    user-regs.o
  CXX    utils.o
  CXX    v850-tdep.o
  CXX    valarith.o
  CXX    valops.o
  CXX    valprint.o
  CXX    value.o
  CXX    varobj.o
  CXX    vax-nbsd-tdep.o
  CXX    vax-tdep.o
  GEN    stamp-version
  CXX    windows-tdep.o
  CXX    x86-linux-nat.o
  CXX    x86-nat.o
  CXX    x86-tdep.o
  CXX    xcoffread.o
  GEN    xml-builtin.c
  CXX    xml-support.o
  CXX    xml-syscall.o
  CXX    xml-tdesc.o
  CXX    xstormy16-tdep.o
  CXX    xtensa-config.o
  CXX    xtensa-linux-tdep.o
  CXX    xtensa-tdep.o
  CXX    gdb.o
  CXX    aarch32-tdep.o
  CXX    ada-exp.o
  CXX    ada-lang.o
  CXX    ada-tasks.o
  CXX    ada-typeprint.o
  CXX    ada-valprint.o
  CXX    ada-varobj.o
  CXX    addrmap.o
  CXX    agent.o
  CXX    alloc.o
  CXX    annotate.o
  CXX    arc-tdep.o
  CXX    arch-utils.o
  CXX    arch/aarch32.o
  CXX    arch/arc.o
  CXX    arch/arm-get-next-pcs.o
  CXX    arch/arm-linux.o
  CXX    arch/arm.o
  CXX    arch/i386.o
  CXX    arch/ppc-linux-common.o
  CXX    arch/riscv.o
  CXX    arm-bsd-tdep.o
  CXX    arm-fbsd-tdep.o
  CXX    arm-linux-tdep.o
  CXX    arm-nbsd-tdep.o
  CXX    arm-obsd-tdep.o
  CXX    arm-pikeos-tdep.o
  CXX    arm-symbian-tdep.o
  CXX    arm-tdep.o
  CXX    arm-wince-tdep.o
  CXX    async-event.o
  CXX    auto-load.o
  CXX    auxv.o
  CXX    avr-tdep.o
  CXX    ax-gdb.o
  CXX    ax-general.o
  CXX    bcache.o
  CXX    bfd-target.o
  CXX    bfin-linux-tdep.o
  CXX    bfin-tdep.o
  CXX    block.o
  CXX    blockframe.o
  CXX    break-catch-sig.o
  CXX    break-catch-syscall.o
  CXX    break-catch-throw.o
  CXX    breakpoint.o
  CXX    bsd-uthread.o
  CXX    btrace.o
  CXX    build-id.o
  CXX    buildsym-legacy.o
  CXX    buildsym.o
  CXX    c-exp.o
  CXX    cp-name-parser.o
  CXX    d-exp.o
  CXX    f-exp.o
  CXX    go-exp.o
  CXX    m2-exp.o
  CXX    p-exp.o
  CXX    rust-exp.o
  CXX    version.o
  CXX    xml-builtin.o
  GEN    init.c
  CXX    init.o
  CXXLD  gdb
/usr/bin/ld: ../opcodes/libopcodes.a(riscv-dis.o): in function `parse_riscv_dis_option':
/home/gdb-buildbot-2/fedora-x86-64-4/fedora-i686/build/opcodes/../../binutils-gdb/opcodes/riscv-dis.c:102: undefined reference to `riscv_get_priv_spec_class'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:1861: gdb] Error 1
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-i686/build/gdb'
make[1]: *** [Makefile:10066: all-gdb] Error 2
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-i686/build'
make: *** [Makefile:854: all] Error 2
program finished with exit code 2
elapsedTime=474.016690
==============================================

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m32, branch master

gdb-buildbot-2
In reply to this post by gdb-buildbot-2
Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/17/builds/3543

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        39e7eccae602562368438c955b31f1d0e37feaa5

Subject of commit:
        gdb: Convert language la_is_string_type_p field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/39/39e7eccae602562368438c955b31f1d0e37feaa5/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Private-Anonymous: no binary: loading /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-private-anon.gcore
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Shared-Anonymous: loading /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
PASS -> FAIL: gdb.base/options.exp: test-print: cmd complete "frame apply 1 print "
PASS -> FAIL: gdb.base/options.exp: test-print: tab complete "frame apply 1 print "
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m64, branch master

gdb-buildbot-2
In reply to this post by gdb-buildbot-2
Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/3/builds/3606

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        39e7eccae602562368438c955b31f1d0e37feaa5

Subject of commit:
        gdb: Convert language la_is_string_type_p field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/39/39e7eccae602562368438c955b31f1d0e37feaa5/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print z
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

gdb-buildbot-2
In reply to this post by gdb-buildbot-2
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/4/builds/3439

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        39e7eccae602562368438c955b31f1d0e37feaa5

Subject of commit:
        gdb: Convert language la_is_string_type_p field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/39/39e7eccae602562368438c955b31f1d0e37feaa5/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.fortran/vla-ptype.exp: ptype vla1
PASS -> FAIL: gdb.fortran/vla-value.exp: print member in non-allocated vla1
PASS -> FAIL: gdb.fortran/vla-value.exp: set member in non-allocated vla1
FAIL -> UNRESOLVED: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

gdb-buildbot-2
In reply to this post by gdb-buildbot-2
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/2/builds/3440

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        39e7eccae602562368438c955b31f1d0e37feaa5

Subject of commit:
        gdb: Convert language la_is_string_type_p field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/39/39e7eccae602562368438c955b31f1d0e37feaa5/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

gdb-buildbot-2
In reply to this post by gdb-buildbot-2
Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/24/builds/3452

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        39e7eccae602562368438c955b31f1d0e37feaa5

Subject of commit:
        gdb: Convert language la_is_string_type_p field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/39/39e7eccae602562368438c955b31f1d0e37feaa5/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: print re_run_var_1
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: setting breakpoint at all_started
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

gdb-buildbot-2
In reply to this post by gdb-buildbot-2
Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/22/builds/3451

Author:
        Andrew Burgess <[hidden email]>

Commit tested:
        39e7eccae602562368438c955b31f1d0e37feaa5

Subject of commit:
        gdb: Convert language la_is_string_type_p field to a method

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/39/39e7eccae602562368438c955b31f1d0e37feaa5/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: print re_run_var_1
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: setting breakpoint at all_started
new FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: continue until exit
new FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: print re_run_var_2
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/39/39e7eccae602562368438c955b31f1d0e37feaa5//xfail.table.gz>