[binutils-gdb] Some i18n fixes for the TUI

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] Some i18n fixes for the TUI

gdb-buildbot
*** TEST RESULTS FOR COMMIT 605dc2c21d145b9eeaa2456dd43512ef28e02dbd ***

commit 605dc2c21d145b9eeaa2456dd43512ef28e02dbd
Author:     Tom Tromey <[hidden email]>
AuthorDate: Sat Jul 13 15:45:14 2019 -0600
Commit:     Tom Tromey <[hidden email]>
CommitDate: Tue Aug 20 16:22:03 2019 -0600

    Some i18n fixes for the TUI
   
    The TUI has a few #defines that hold user-visible strings.  As these
    are only used in a single spot, this patch removes the defines,
    preferring direct use of the string where needed.  Furthermore, now
    the strings are wrapped in _(), which is friendlier for i18n purposes.
   
    gdb/ChangeLog
    2019-08-20  Tom Tromey  <[hidden email]>
   
            * tui/tui-source.h (struct tui_source_window): Update.
            * tui/tui-regs.c (tui_show_registers): Update.
            * tui/tui-disasm.h (struct tui_disasm_window): Update.
            * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
            (NO_REGS_STRING): Remove defines.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d9e676ac7c..c4a1179ce0 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2019-08-20  Tom Tromey  <[hidden email]>
+
+ * tui/tui-source.h (struct tui_source_window): Update.
+ * tui/tui-regs.c (tui_show_registers): Update.
+ * tui/tui-disasm.h (struct tui_disasm_window): Update.
+ * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
+ (NO_REGS_STRING): Remove defines.
+
 2019-08-20  Conrad Meyer  <[hidden email]>
 
  * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 7993c63937..0432a53750 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -103,9 +103,6 @@ public:
 
 /* Constant definitions.  */
 #define DEFAULT_TAB_LEN         8
-#define NO_SRC_STRING           "[ No Source Available ]"
-#define NO_DISASSEM_STRING      "[ No Assembly Available ]"
-#define NO_REGS_STRING          "[ Register Values Unavailable ]"
 #define NO_DATA_STRING          "[ No Data Values Displayed ]"
 #define SRC_NAME                "src"
 #define CMD_NAME                "cmd"
diff --git a/gdb/tui/tui-disasm.h b/gdb/tui/tui-disasm.h
index d989532248..bfddfa0183 100644
--- a/gdb/tui/tui-disasm.h
+++ b/gdb/tui/tui-disasm.h
@@ -50,7 +50,7 @@ struct tui_disasm_window : public tui_source_window_base
 
   void erase_source_content () override
   {
-    do_erase_source_content (NO_DISASSEM_STRING);
+    do_erase_source_content (_("[ No Assembly Available ]"));
   }
 
 protected:
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 36973ff51a..8fcb7bc46b 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -165,7 +165,7 @@ tui_show_registers (struct reggroup *group)
   else
     {
       TUI_DATA_WIN->current_group = 0;
-      TUI_DATA_WIN->erase_data_content (NO_REGS_STRING);
+      TUI_DATA_WIN->erase_data_content (_("[ Register Values Unavailable ]"));
     }
 }
 
diff --git a/gdb/tui/tui-source.h b/gdb/tui/tui-source.h
index 9c3013637b..a7002123c9 100644
--- a/gdb/tui/tui-source.h
+++ b/gdb/tui/tui-source.h
@@ -53,7 +53,7 @@ struct tui_source_window : public tui_source_window_base
 
   void erase_source_content () override
   {
-    do_erase_source_content (NO_SRC_STRING);
+    do_erase_source_content (_("[ No Source Available ]"));
   }
 
   void show_symtab_source (struct gdbarch *, struct symtab *,
Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

gdb-buildbot
Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/5/builds/552

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        605dc2c21d145b9eeaa2456dd43512ef28e02dbd

Subject of commit:
        Some i18n fixes for the TUI

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd/

*** Diff to previous build ***
==============================================
new UNRESOLVED: gdb.trace/trace-condition.exp: delete all breakpoints in delete_breakpoints
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-i686, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-2

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/18/builds/621

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        605dc2c21d145b9eeaa2456dd43512ef28e02dbd

Subject of commit:
        Some i18n fixes for the TUI

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/multi-forks.exp: info inferior 6
PASS -> FAIL: gdb.base/multi-forks.exp: run to exit 6
PASS -> FAIL: gdb.base/multi-forks.exp: run to exit 7
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/3/builds/643

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        605dc2c21d145b9eeaa2456dd43512ef28e02dbd

Subject of commit:
        Some i18n fixes for the TUI

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-1

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/17/builds/619

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        605dc2c21d145b9eeaa2456dd43512ef28e02dbd

Subject of commit:
        Some i18n fixes for the TUI

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/2/builds/619

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        605dc2c21d145b9eeaa2456dd43512ef28e02dbd

Subject of commit:
        Some i18n fixes for the TUI

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd/

*** Diff to previous build ***
==============================================
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-2

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/4/builds/618

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        605dc2c21d145b9eeaa2456dd43512ef28e02dbd

Subject of commit:
        Some i18n fixes for the TUI

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/corefile.exp: core-file warning-free
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/60/605dc2c21d145b9eeaa2456dd43512ef28e02dbd//xfail.table.gz>