[binutils-gdb] Remove tui_data_item_window::value

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] Remove tui_data_item_window::value

gdb-buildbot
*** TEST RESULTS FOR COMMIT 8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6 ***

commit 8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6
Author:     Tom Tromey <[hidden email]>
AuthorDate: Sat Jul 13 15:55:48 2019 -0600
Commit:     Tom Tromey <[hidden email]>
CommitDate: Tue Aug 20 16:22:05 2019 -0600

    Remove tui_data_item_window::value
   
    The field tui_data_item_window::value is not used, so remove it.
   
    gdb/ChangeLog
    2019-08-20  Tom Tromey  <[hidden email]>
   
            * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
            field.
            * tui/tui-regs.c (~tui_data_item_window): Update.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 346cc35d0b..b4108d90d2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2019-08-20  Tom Tromey  <[hidden email]>
+
+ * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
+ field.
+ * tui/tui-regs.c (~tui_data_item_window): Update.
+
 2019-08-20  Tom Tromey  <[hidden email]>
 
  * tui/tui-regs.c (tui_register_format, tui_get_register): Move
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 9ea6e72364..aebea49eff 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -103,7 +103,6 @@ tui_get_register (struct frame_info *frame,
 
 tui_data_item_window::~tui_data_item_window ()
 {
-  xfree (value);
   xfree (content);
 }
 
diff --git a/gdb/tui/tui-regs.h b/gdb/tui/tui-regs.h
index 7b0bb505a8..d54b556148 100644
--- a/gdb/tui/tui-regs.h
+++ b/gdb/tui/tui-regs.h
@@ -38,7 +38,6 @@ struct tui_data_item_window : public tui_gen_win_info
   const char *name = nullptr;
   /* The register number, or data display number.  */
   int item_no = -1;
-  void *value = nullptr;
   bool highlight = false;
   char *content = nullptr;
 };
Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

gdb-buildbot
Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/5/builds/555

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6

Subject of commit:
        Remove tui_data_item_window::value

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-i686, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/18/builds/624

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6

Subject of commit:
        Remove tui_data_item_window::value

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-cc-with-index, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/20/builds/624

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6

Subject of commit:
        Remove tui_data_item_window::value

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-1

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/17/builds/622

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6

Subject of commit:
        Remove tui_data_item_window::value

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-2

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/3/builds/646

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6

Subject of commit:
        Remove tui_data_item_window::value

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/4/builds/621

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6

Subject of commit:
        Remove tui_data_item_window::value

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/8e/8e114aab8bdab9a988dfc0afbb3fecc17e2d45b6//xfail.table.gz>