[binutils-gdb] Remove NULL check from tui_reg_command

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] Remove NULL check from tui_reg_command

gdb-buildbot
*** TEST RESULTS FOR COMMIT 0f8d8876d98305671a19b5bf88f125d4d02c7e0f ***

commit 0f8d8876d98305671a19b5bf88f125d4d02c7e0f
Author:     Tom Tromey <[hidden email]>
AuthorDate: Sat Jul 13 15:53:44 2019 -0600
Commit:     Tom Tromey <[hidden email]>
CommitDate: Tue Aug 20 16:22:04 2019 -0600

    Remove NULL check from tui_reg_command
   
    tui_reg_command has an unnecessary NULL check.  The preceding call to
    tui_reg_layout will ensure the window exists.  This patch removes the
    check.
   
    gdb/ChangeLog
    2019-08-20  Tom Tromey  <[hidden email]>
   
            * tui/tui-regs.c (tui_reg_command): Remove NULL check.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c4a1179ce0..ce64e7accc 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-08-20  Tom Tromey  <[hidden email]>
+
+ * tui/tui-regs.c (tui_reg_command): Remove NULL check.
+
 2019-08-20  Tom Tromey  <[hidden email]>
 
  * tui/tui-source.h (struct tui_source_window): Update.
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 8fcb7bc46b..b3c7ce627b 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -669,9 +669,7 @@ tui_reg_command (const char *args, int from_tty)
       if (TUI_DATA_WIN == NULL || !TUI_DATA_WIN->is_visible ())
  tui_reg_layout ();
 
-      struct reggroup *current_group = NULL;
-      if (TUI_DATA_WIN != NULL)
- current_group = TUI_DATA_WIN->current_group;
+      struct reggroup *current_group = TUI_DATA_WIN->current_group;
       if (strncmp (args, "next", len) == 0)
  match = tui_reg_next (current_group, gdbarch);
       else if (strncmp (args, "prev", len) == 0)
Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-Aarch64-m64, branch master

gdb-buildbot
Buildername:
        Ubuntu-Aarch64-m64

Worker:
        ubuntu-aarch64

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/8/builds/557

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        0f8d8876d98305671a19b5bf88f125d4d02c7e0f

Subject of commit:
        Remove NULL check from tui_reg_command

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.tui/empty.exp: split-regs: 90x40: box 1
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-i686, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-2

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/18/builds/622

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        0f8d8876d98305671a19b5bf88f125d4d02c7e0f

Subject of commit:
        Remove NULL check from tui_reg_command

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-cc-with-index, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/20/builds/622

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        0f8d8876d98305671a19b5bf88f125d4d02c7e0f

Subject of commit:
        Remove NULL check from tui_reg_command

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/3/builds/644

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        0f8d8876d98305671a19b5bf88f125d4d02c7e0f

Subject of commit:
        Remove NULL check from tui_reg_command

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-1

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/17/builds/620

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        0f8d8876d98305671a19b5bf88f125d4d02c7e0f

Subject of commit:
        Remove NULL check from tui_reg_command

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/24/builds/619

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        0f8d8876d98305671a19b5bf88f125d4d02c7e0f

Subject of commit:
        Remove NULL check from tui_reg_command

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-1

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/22/builds/619

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        0f8d8876d98305671a19b5bf88f125d4d02c7e0f

Subject of commit:
        Remove NULL check from tui_reg_command

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/0f/0f8d8876d98305671a19b5bf88f125d4d02c7e0f//xfail.table.gz>