[binutils-gdb] [PowerPC64] correct tprel offset limit

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] [PowerPC64] correct tprel offset limit

gdb-buildbot
*** TEST RESULTS FOR COMMIT 0b1474281c659919d9c63ccfd6891b9e9ed0fc9c ***

commit 0b1474281c659919d9c63ccfd6891b9e9ed0fc9c
Author:     Alan Modra <[hidden email]>
AuthorDate: Thu Jul 18 10:31:44 2019 +0930
Commit:     Alan Modra <[hidden email]>
CommitDate: Thu Jul 18 22:17:29 2019 +0930

    [PowerPC64] correct tprel offset limit
   
    I don't expect anyone will have hit this bug.  You'd need a TLS
    segment of 2G before you'd notice.
   
            * elf64-ppc.c (ppc64_elf_tls_optimize): Correct test for allowed
            range of tp-relative offsets.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 7d841e29e5..bbef105a2c 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2019-07-18  Alan Modra  <[hidden email]>
+
+ * elf64-ppc.c (ppc64_elf_tls_optimize): Correct test for allowed
+ range of tp-relative offsets.
+
 2019-07-15  Alan Modra  <[hidden email]>
 
  * elflink.c (_bfd_elf_fix_symbol_flags): If the def for an
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index d77cfdf9d2..9d3ba36c02 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -7734,9 +7734,8 @@ ppc64_elf_tls_optimize (struct bfd_link_info *info)
  {
   value += sym_sec->output_offset;
   value += sym_sec->output_section->vma;
-  value -= htab->elf.tls_sec->vma;
-  ok_tprel = (value + TP_OFFSET + ((bfd_vma) 1 << 31)
-      < (bfd_vma) 1 << 32);
+  value -= htab->elf.tls_sec->vma + TP_OFFSET;
+  ok_tprel = value + 0x80008000ULL < 1ULL << 32;
  }
     }
 
Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-i686, branch master

gdb-buildbot
Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/18/builds/332

Author:
        Alan Modra <[hidden email]>

Commit tested:
        0b1474281c659919d9c63ccfd6891b9e9ed0fc9c

Subject of commit:
        [PowerPC64] correct tprel offset limit

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/17/builds/329

Author:
        Alan Modra <[hidden email]>

Commit tested:
        0b1474281c659919d9c63ccfd6891b9e9ed0fc9c

Subject of commit:
        [PowerPC64] correct tprel offset limit

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/4/builds/329

Author:
        Alan Modra <[hidden email]>

Commit tested:
        0b1474281c659919d9c63ccfd6891b9e9ed0fc9c

Subject of commit:
        [PowerPC64] correct tprel offset limit

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-1

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/2/builds/331

Author:
        Alan Modra <[hidden email]>

Commit tested:
        0b1474281c659919d9c63ccfd6891b9e9ed0fc9c

Subject of commit:
        [PowerPC64] correct tprel offset limit

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c/

*** Diff to previous build ***
==============================================
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/24/builds/329

Author:
        Alan Modra <[hidden email]>

Commit tested:
        0b1474281c659919d9c63ccfd6891b9e9ed0fc9c

Subject of commit:
        [PowerPC64] correct tprel offset limit

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-2

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/22/builds/329

Author:
        Alan Modra <[hidden email]>

Commit tested:
        0b1474281c659919d9c63ccfd6891b9e9ed0fc9c

Subject of commit:
        [PowerPC64] correct tprel offset limit

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/0b/0b1474281c659919d9c63ccfd6891b9e9ed0fc9c//xfail.table.gz>