[binutils-gdb] Move dwarf2_read_addr_index declaration to dwarf2/read.h

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] Move dwarf2_read_addr_index declaration to dwarf2/read.h

gdb-buildbot
*** TEST RESULTS FOR COMMIT 450a1bfc7f60d4b37615a7d78aac83ca73cae159 ***

commit 450a1bfc7f60d4b37615a7d78aac83ca73cae159
Author:     Simon Marchi <[hidden email]>
AuthorDate: Tue Feb 25 23:38:26 2020 -0500
Commit:     Simon Marchi <[hidden email]>
CommitDate: Tue Feb 25 23:38:26 2020 -0500

    Move dwarf2_read_addr_index declaration to dwarf2/read.h
   
    The implementation is in dwarf2/read.c, so the declaration belongs in
    dwarf2/read.h.  Also, move the documentation there.
   
    gdb/ChangeLog:
   
            * dwarf2/loc.h (dwarf2_read_addr_index): Move...
            * dwarf2/read.h (dwarf2_read_addr_index): ... here.
            * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index cb3e1854ac..aa4b01bac3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2020-02-25  Simon Marchi  <[hidden email]>
+
+ * dwarf2/loc.h (dwarf2_read_addr_index): Move...
+ * dwarf2/read.h (dwarf2_read_addr_index): ... here.
+ * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
+
 2020-02-25  Andrew Burgess  <[hidden email]>
 
  * gdbtypes.c (create_array_type_with_stride): Handle negative
diff --git a/gdb/dwarf2/loc.h b/gdb/dwarf2/loc.h
index ab071c21b3..dfb6f05525 100644
--- a/gdb/dwarf2/loc.h
+++ b/gdb/dwarf2/loc.h
@@ -138,9 +138,6 @@ void dwarf2_compile_property_to_c (string_file *stream,
    CORE_ADDR address,
    struct symbol *sym);
 
-CORE_ADDR dwarf2_read_addr_index (struct dwarf2_per_cu_data *per_cu,
-  unsigned int addr_index);
-
 /* The symbol location baton types used by the DWARF-2 reader (i.e.
    SYMBOL_LOCATION_BATON for a LOC_COMPUTED symbol).  "struct
    dwarf2_locexpr_baton" is for a symbol with a single location
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 8c40ddb727..37d4af14ea 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -18867,14 +18867,10 @@ read_addr_index_from_leb128 (struct dwarf2_cu *cu, const gdb_byte *info_ptr,
   return read_addr_index (cu, addr_index);
 }
 
-/* Given an index in .debug_addr, fetch the value.
-   NOTE: This can be called during dwarf expression evaluation,
-   long after the debug information has been read, and thus per_cu->cu
-   may no longer exist.  */
+/* See read.h.  */
 
 CORE_ADDR
-dwarf2_read_addr_index (struct dwarf2_per_cu_data *per_cu,
- unsigned int addr_index)
+dwarf2_read_addr_index (dwarf2_per_cu_data *per_cu, unsigned int addr_index)
 {
   struct dwarf2_per_objfile *dwarf2_per_objfile = per_cu->dwarf2_per_objfile;
   struct dwarf2_cu *cu = per_cu->cu;
diff --git a/gdb/dwarf2/read.h b/gdb/dwarf2/read.h
index 640e19e4a0..a3ae412379 100644
--- a/gdb/dwarf2/read.h
+++ b/gdb/dwarf2/read.h
@@ -529,6 +529,14 @@ extern struct dwz_file *dwarf2_get_dwz_file
 struct type *dwarf2_get_die_type (cu_offset die_offset,
   struct dwarf2_per_cu_data *per_cu);
 
+/* Given an index in .debug_addr, fetch the value.
+   NOTE: This can be called during dwarf expression evaluation,
+   long after the debug information has been read, and thus per_cu->cu
+   may no longer exist.  */
+
+CORE_ADDR dwarf2_read_addr_index (dwarf2_per_cu_data *per_cu,
+  unsigned int addr_index);
+
 /* When non-zero, dump line number entries as they are read in.  */
 extern unsigned int dwarf_line_debug;
 
Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-cc-with-index, branch master

gdb-buildbot
Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/20/builds/2263

Author:
        Simon Marchi <[hidden email]>

Commit tested:
        450a1bfc7f60d4b37615a7d78aac83ca73cae159

Subject of commit:
        Move dwarf2_read_addr_index declaration to dwarf2/read.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159/

*** Diff to previous build ***
==============================================
new KFAIL: gdb.reverse/solib-precsave.exp: run to end of main
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-1

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/17/builds/2312

Author:
        Simon Marchi <[hidden email]>

Commit tested:
        450a1bfc7f60d4b37615a7d78aac83ca73cae159

Subject of commit:
        Move dwarf2_read_addr_index declaration to dwarf2/read.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/continue-all-already-running.exp: breakpoint hit
new FAIL: gdb.base/corefile-buildid.exp: exec sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: exec: info files
new FAIL: gdb.base/corefile-buildid.exp: shared sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: shared: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink exec sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink exec: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink shared sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink shared: info files
new UNRESOLVED: gdb.base/corefile.exp: attach: core file is cleared
new FAIL: gdb.base/corefile.exp: attach: with core
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "" "" : second pass: breakpoint foo in first file
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: breakpoint foo in first file
PASS -> FAIL: gdb.threads/gcore-stale-thread.exp: save a corefile
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/3/builds/2373

Author:
        Simon Marchi <[hidden email]>

Commit tested:
        450a1bfc7f60d4b37615a7d78aac83ca73cae159

Subject of commit:
        Move dwarf2_read_addr_index declaration to dwarf2/read.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print j
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/2/builds/2208

Author:
        Simon Marchi <[hidden email]>

Commit tested:
        450a1bfc7f60d4b37615a7d78aac83ca73cae159

Subject of commit:
        Move dwarf2_read_addr_index declaration to dwarf2/read.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/break-interp.exp: LDprelinkNOdebugSEP: BINprelinkNOdebugNOpieNO: INNER: symbol-less: entry point reached
new FAIL: gdb.base/break-interp.exp: LDprelinkNOdebugSEP: BINprelinkNOdebugNOpieYES: INNER: symbol-less: entry point reached
PASS -> FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: run to foo
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-1

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/4/builds/2208

Author:
        Simon Marchi <[hidden email]>

Commit tested:
        450a1bfc7f60d4b37615a7d78aac83ca73cae159

Subject of commit:
        Move dwarf2_read_addr_index declaration to dwarf2/read.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/corefile-buildid.exp: exec sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: exec: info files
new FAIL: gdb.base/corefile-buildid.exp: shared sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: shared: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink exec sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink exec: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink shared sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink shared: info files
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "" "" : second pass: breakpoint foo in first file
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: breakpoint foo in first file
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
new FAIL: gdb.threads/attach-into-signal.exp: threaded: thread apply 2 print $_siginfo.si_signo
UNRESOLVED -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
new FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: only inferior 1 left
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
new KFAIL: gdb.threads/watchthreads2.exp: gdb can drop watchpoints in multithreaded app
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/5/builds/2093

Author:
        Simon Marchi <[hidden email]>

Commit tested:
        450a1bfc7f60d4b37615a7d78aac83ca73cae159

Subject of commit:
        Move dwarf2_read_addr_index declaration to dwarf2/read.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.threads/linux-dp.exp: philosopher is distinct: 2
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

Sourceware - gdb-testers mailing list
In reply to this post by gdb-buildbot
Buildername:
        Ubuntu-Aarch64-native-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/19/builds/2124

Author:
        Simon Marchi <[hidden email]>

Commit tested:
        450a1bfc7f60d4b37615a7d78aac83ca73cae159

Subject of commit:
        Move dwarf2_read_addr_index declaration to dwarf2/read.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

Sourceware - gdb-testers mailing list
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-2

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/22/builds/2209

Author:
        Simon Marchi <[hidden email]>

Commit tested:
        450a1bfc7f60d4b37615a7d78aac83ca73cae159

Subject of commit:
        Move dwarf2_read_addr_index declaration to dwarf2/read.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: run to foo
PASS -> FAIL: gdb.gdb/unittest.exp: maintenance selftest
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/45/450a1bfc7f60d4b37615a7d78aac83ca73cae159//xfail.table.gz>