[binutils-gdb] Improve remote attach round-trips without btrace

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] Improve remote attach round-trips without btrace

gdb-buildbot
*** TEST RESULTS FOR COMMIT aedbe3bb9f03be12ad714adca1fefc391317bd94 ***

commit aedbe3bb9f03be12ad714adca1fefc391317bd94
Author:     Conrad Meyer <[hidden email]>
AuthorDate: Mon Aug 19 00:02:19 2019 -0700
Commit:     Pedro Alves <[hidden email]>
CommitDate: Tue Aug 20 15:06:37 2019 +0100

    Improve remote attach round-trips without btrace
   
    For remotes which do not support btrace at all, we can save several
    round trips for each thread.  This is especially significant when your
    remote is a kernel with 100s or 1000s of threads and latency is
    intercontinental.
   
    Previously, with target, remote, and infrun debugging enabled, one
    might see:
   
        Sending packet: $Hg18aee#43...Ack
        Packet received: OK
        Sending packet: $Hg186f7#eb...Ack
        Packet received: OK
        remote:target_xfer_partial (24, , 0x805454000, 0x0, 0x0, 4096) = -1, 0
   
    repeated for all non-exited threads.
   
    Afterwards, if the remote does not specify 'qXfer:btrace-conf:read+'
    in qSupported stub features, these unnecessary thread switches are
    avoided.
   
    gdb/ChangeLog:
   
            * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
            unnecessary thread walk if remote doesn't support the packet.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2dce609068..d9e676ac7c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-20  Conrad Meyer  <[hidden email]>
+
+ * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
+ unnecessary thread walk if remote doesn't support the packet.
+
 2019-08-19  Tom Tromey  <[hidden email]>
 
  * python/py-value.c (value_has_field): Fix indentation.
diff --git a/gdb/remote.c b/gdb/remote.c
index 7ea9cd4cf0..ae06c4ba79 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -13700,6 +13700,11 @@ remote_target::remote_btrace_maybe_reopen ()
   int warned = 0;
 #endif
 
+  /* Don't bother walking the entirety of the remote thread list when
+     we know the feature isn't supported by the remote.  */
+  if (packet_support (PACKET_qXfer_btrace_conf) != PACKET_ENABLE)
+    return;
+
   scoped_restore_current_thread restore_thread;
 
   for (thread_info *tp : all_non_exited_threads ())
Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-i686, branch master

gdb-buildbot
Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/18/builds/615

Author:
        Conrad Meyer <[hidden email]>

Commit tested:
        aedbe3bb9f03be12ad714adca1fefc391317bd94

Subject of commit:
        Improve remote attach round-trips without btrace

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/catch-syscall.exp: multiple targets: insert catch syscall on syscall 1 -- write on i386:x86-64
PASS -> FAIL: gdb.gdb/selftest.exp: backtrace through signal handler
new FAIL: gdb.python/py-finish-breakpoint2.exp: check FinishBreakpoint in catch
new FAIL: gdb.python/py-finish-breakpoint2.exp: check finish BP removal
new FAIL: gdb.python/py-finish-breakpoint2.exp: continue to second exception
new FAIL: gdb.python/py-finish-breakpoint2.exp: set FinishBP after the exception
new FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: a_base_ref with option deref_refs: deref_refs=true
new FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: a_base_ref with option deref_refs=True, static_members=False
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
new KFAIL: gdb.xml/tdesc-arch.exp: set tdesc filename tdesc-arch.xml
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-cc-with-index, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/20/builds/615

Author:
        Conrad Meyer <[hidden email]>

Commit tested:
        aedbe3bb9f03be12ad714adca1fefc391317bd94

Subject of commit:
        Improve remote attach round-trips without btrace

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-2

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/3/builds/637

Author:
        Conrad Meyer <[hidden email]>

Commit tested:
        aedbe3bb9f03be12ad714adca1fefc391317bd94

Subject of commit:
        Improve remote attach round-trips without btrace

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-1

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/2/builds/613

Author:
        Conrad Meyer <[hidden email]>

Commit tested:
        aedbe3bb9f03be12ad714adca1fefc391317bd94

Subject of commit:
        Improve remote attach round-trips without btrace

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94/

*** Diff to previous build ***
==============================================
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/17/builds/613

Author:
        Conrad Meyer <[hidden email]>

Commit tested:
        aedbe3bb9f03be12ad714adca1fefc391317bd94

Subject of commit:
        Improve remote attach round-trips without btrace

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/4/builds/612

Author:
        Conrad Meyer <[hidden email]>

Commit tested:
        aedbe3bb9f03be12ad714adca1fefc391317bd94

Subject of commit:
        Improve remote attach round-trips without btrace

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94/

*** Diff to previous build ***
==============================================
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-2

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/24/builds/612

Author:
        Conrad Meyer <[hidden email]>

Commit tested:
        aedbe3bb9f03be12ad714adca1fefc391317bd94

Subject of commit:
        Improve remote attach round-trips without btrace

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/corefile.exp: core-file warning-free
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-1

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/22/builds/612

Author:
        Conrad Meyer <[hidden email]>

Commit tested:
        aedbe3bb9f03be12ad714adca1fefc391317bd94

Subject of commit:
        Improve remote attach round-trips without btrace

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/ae/aedbe3bb9f03be12ad714adca1fefc391317bd94//xfail.table.gz>