[binutils-gdb] Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

sergiodj+buildbot-2
*** TEST RESULTS FOR COMMIT d4c2a405cb7535d25b88e9b8dad0e557242950ca ***

Author: Pedro Alves <[hidden email]>
Branch: master
Commit: d4c2a405cb7535d25b88e9b8dad0e557242950ca

Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

This patch fixes the regression covered by the test added by:

    commit 344420da6beac1e0b2f7964e7101f8dcdb509b0d
    Date: Thu Jan 4 03:30:37 2018 -0500
    Subject: Add "complete break ada" test to gdb.ada/complete.exp

The regression had been introduced by:

    commit b5ec771e60c1a0863e51eb491c85c674097e9e13
    Date:   Wed Nov 8 14:22:32 2017 +0000
    Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching

The gist of it is that linespec completion in Ada mode is generating
additional matches that should not appear in the match list
(internally generated symbols, or symbols that should be enclosed
between "<...>").  These extraneous entries have uppercase characters, such as:

    break ada__stringsS
    break ada__strings__R11s
    [etc]

These matches come from minimal symbols.  The problem is that Ada
minsyms end up with no language set (language_auto), and thus we end
up using the generic symbol name matcher for those instead of Ada's.
We already had a special case for in compare_symbol_name to handle
this, but it was limited to expressions, while the case at hand is
completing a linespec.  Fix this by applying the special case to
linespec completion as well.  I.e., remove the EXPRESSION check from
compare_symbol_name.  That alone turns out to not be sufficient still
-- GDB would still show a couple entries that shouldn't be there:

~~
    break ada__exceptions__exception_data__append_info_exception_name__2Xn
    break ada__exceptions__exception_data__exception_name_length__2Xn
~~

The reason is that these minimal symbols end up with their language
set to language_cplus / C++, because those encoded names manage to
demangle successfully as C++ symbols (using an old C++ mangling
scheme):

  $ echo ada__exceptions__exception_data__append_info_exception_name__2Xn | c++filt
  Xn::ada__exceptions__exception_data__append_info_exception_name(void)

It's unfortunate that Ada's encoding scheme doesn't start with some
unique prefix like "_Z" in the C++ Itanium ABI mangling scheme.  For
now, paper over that by treating C++ minsyms as Ada minsyms.

gdb/ChangeLog:
2018-01-10  Pedro Alves  <[hidden email]>

        PR gdb/22670
        * ada-lang.c (ada_collect_symbol_completion_matches): If the
        minsym's language is language_auto or language_cplus, pass down
        language_ada instead.
        * symtab.c (compare_symbol_name): Don't frob symbol language here.

gdb/testsuite/ChangeLog:
2018-01-10  Pedro Alves  <[hidden email]>

        PR gdb/22670
        * gdb.ada/complete.exp ("complete break ada"): Replace kfail with
        a fail.
Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-4

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/8485>

Commit(s) tested:
        d4c2a405cb7535d25b88e9b8dad0e557242950ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m32/d4/d4c2a405cb7535d25b88e9b8dad0e557242950ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail;hb=5d2ac30>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail.table;hb=5d2ac30>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-2

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/8489>

Commit(s) tested:
        d4c2a405cb7535d25b88e9b8dad0e557242950ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m32/d4/d4c2a405cb7535d25b88e9b8dad0e557242950ca/>

*** Diff to previous build ***
============================
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail;hb=4a056df>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail.table;hb=4a056df>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-i686, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/8524>

Commit(s) tested:
        d4c2a405cb7535d25b88e9b8dad0e557242950ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-i686/d4/d4c2a405cb7535d25b88e9b8dad0e557242950ca/>

*** Diff to previous build ***
============================
new FAIL: gdb.gdb/complaints.exp: breakpoint in captured_command_loop
new FAIL: gdb.gdb/complaints.exp: run until breakpoint at captured_command_loop
new FAIL: gdb.gdb/observer.exp: breakpoint in captured_main
new FAIL: gdb.gdb/observer.exp: run until breakpoint at captured_main
new FAIL: gdb.gdb/python-interrupts.exp: breakpoint in captured_command_loop
new FAIL: gdb.gdb/python-interrupts.exp: run until breakpoint at captured_command_loop
new FAIL: gdb.gdb/python-selftest.exp: breakpoint in captured_command_loop
new FAIL: gdb.gdb/python-selftest.exp: run until breakpoint at captured_command_loop
new FAIL: gdb.gdb/selftest.exp: breakpoint in captured_main
new FAIL: gdb.gdb/selftest.exp: run until breakpoint at captured_main
PASS -> FAIL: gdb.linespec/cpls-abi-tag.exp: test_abi_tag: completion: at tag: tab complete "b test_abi_tag_function[abi:"
PASS -> FAIL: gdb.linespec/cpls-abi-tag.exp: test_abi_tag: completion: at tag: cmd complete "b test_abi_tag_function[abi:"
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-i686/xfails/master/xfail;hb=e3bd253>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-i686/xfails/master/xfail.table;hb=e3bd253>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-cc-with-index, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-4

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/8438>

Commit(s) tested:
        d4c2a405cb7535d25b88e9b8dad0e557242950ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/d4/d4c2a405cb7535d25b88e9b8dad0e557242950ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail;hb=3e07033>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table;hb=3e07033>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-3

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/8528>

Commit(s) tested:
        d4c2a405cb7535d25b88e9b8dad0e557242950ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/d4/d4c2a405cb7535d25b88e9b8dad0e557242950ca/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.arch/amd64-disp-step-avx.exp: vex2: xmm0 has expected value before
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
new FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail;hb=f51a767>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table;hb=f51a767>



Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        fedora-x86-64-2

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/8483>

Commit(s) tested:
        d4c2a405cb7535d25b88e9b8dad0e557242950ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/d4/d4c2a405cb7535d25b88e9b8dad0e557242950ca/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.arch/amd64-disp-step-avx.exp: vex2: xmm0 has expected value before
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail;hb=05dfcb4>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table;hb=05dfcb4>



Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        ubuntu-trusty-aarch32-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-extended-gdbserver-m32/builds/2525>

Commit(s) tested:
        d4c2a405cb7535d25b88e9b8dad0e557242950ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-extended-gdbserver-m32/d4/d4c2a405cb7535d25b88e9b8dad0e557242950ca/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
PASS -> FAIL: gdb.gdb/unittest.exp: maintenance selftest
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=2: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=10: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=11: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=12: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=14: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=18: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=19: wait for stops
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
new FAIL: gdb.threads/queue-signal.exp: determine thread functions
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.



Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-AArch64-m64, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        ubuntu-aarch64-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-m64/builds/3939>

Commit(s) tested:
        d4c2a405cb7535d25b88e9b8dad0e557242950ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Ubuntu-AArch64-m64/d4/d4c2a405cb7535d25b88e9b8dad0e557242950ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-m64/xfails/master/xfail;hb=a85ec42>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-m64/xfails/master/xfail.table;hb=a85ec42>



Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        ubuntu-trusty-aarch32-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-gdbserver-m32/builds/2507>

Commit(s) tested:
        d4c2a405cb7535d25b88e9b8dad0e557242950ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-gdbserver-m32/d4/d4c2a405cb7535d25b88e9b8dad0e557242950ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail;hb=>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-native-gdbserver-m32/xfails/master/xfail.table;hb=>



Reply | Threaded
Open this post in threaded view
|

Failures on Ubuntu-AArch32-m32, branch master

sergiodj+buildbot-2
In reply to this post by sergiodj+buildbot-2
Buildslave:
        ubuntu-trusty-aarch32-1

Full Build URL:
        <http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-m32/builds/2526>

Commit(s) tested:
        d4c2a405cb7535d25b88e9b8dad0e557242950ca

Author(s) (in the same order as the commits):
        Pedro Alves <[hidden email]>

Subject:
        Fix gdb.ada/complete.exp's "complete break ada" test (PR gdb/22670)

Testsuite log (gdb.sum and gdb.log) URL(s):
        <http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-m32/d4/d4c2a405cb7535d25b88e9b8dad0e557242950ca/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-m32/xfails/master/xfail;hb=>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch32-m32/xfails/master/xfail.table;hb=>