[binutils-gdb] Change ARI to mention C++11, and remove some rules

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[binutils-gdb] Change ARI to mention C++11, and remove some rules

gdb-buildbot
*** TEST RESULTS FOR COMMIT 56f79b630766bb134400b4a8da43941cfc31c0c0 ***

commit 56f79b630766bb134400b4a8da43941cfc31c0c0
Author:     Tom Tromey <[hidden email]>
AuthorDate: Mon Jul 15 10:41:18 2019 -0600
Commit:     Tom Tromey <[hidden email]>
CommitDate: Fri Jul 19 09:37:00 2019 -0600

    Change ARI to mention C++11, and remove some rules
   
    I noticed that ARI mentions "ISO C 90", but now gdb uses C++11.  This
    patch updates some text to reflect this change.
   
    I also noticed that a few rules can be removed now.  ARGSUSED doesn't
    seem to be an issue any more (there's no code mentioning this and I
    doubt most of us even remember this convention); PARAMS was specific
    to K&R C; and __func__ is available in C++11.
   
    gdb/ChangeLog
    2019-07-19  Tom Tromey  <[hidden email]>
   
            * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
            (ARGSUSED, PARAMS, __func__): Remove rules.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2f73f30741..c5a102f315 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-07-19  Tom Tromey  <[hidden email]>
+
+ * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
+ (ARGSUSED, PARAMS, __func__): Remove rules.
+
 2019-07-19  Alan Hayward  <[hidden email]>
 
  * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 895654150b..4bd434c8fe 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -27,7 +27,7 @@ LC_ALL=C ; export LC_ALL
 
 # Permanent checks take the form:
 
-#     Do not use XXXX, ISO C 90 implies YYYY
+#     Do not use XXXX, C++11 implies YYYY
 #     Do not use XXXX, instead use YYYY''.
 
 # and should never be removed.
@@ -255,17 +255,6 @@ BEGIN {
 }
 
 
-# Things in comments
-
-BEGIN { doc["ARGSUSED"] = "\
-Do not use ARGSUSED, unnecessary"
-    category["ARGSUSED"] = ari_regression
-}
-/(^|[^_[:alnum:]])ARGSUSED([^_[:alnum:]]|$)/ {
-    fail("ARGSUSED")
-}
-
-
 # SNIP - Strip out comments - SNIP
 
 FNR == 1 {
@@ -433,27 +422,8 @@ FNR == 1 {
 cont_p { $0 = full_line $0; cont_p = 0; full_line = ""; }
 
 
-# GDB uses ISO C 90.  Check for any non pure ISO C 90 code
-
-BEGIN { doc["PARAMS"] = "\
-Do not use PARAMS(), ISO C 90 implies prototypes"
-    category["PARAMS"] = ari_regression
-}
-/(^|[^_[:alnum:]])PARAMS([^_[:alnum:]]|$)/ {
-    fail("PARAMS")
-}
-
-BEGIN { doc["__func__"] = "\
-Do not use __func__, ISO C 90 does not support this macro"
-    category["__func__"] = ari_regression
-    fix("__func__", "gdbsupport/gdb_assert.h", 1)
-}
-/(^|[^_[:alnum:]])__func__([^_[:alnum:]]|$)/ {
-    fail("__func__")
-}
-
 BEGIN { doc["__FUNCTION__"] = "\
-Do not use __FUNCTION__, ISO C 90 does not support this macro"
+Do not use __FUNCTION__, C++11 does not support this macro"
     category["__FUNCTION__"] = ari_regression
 }
 /(^|[^_[:alnum:]])__FUNCTION__([^_[:alnum:]]|$)/ {
@@ -470,7 +440,7 @@ autoconf tests"
 }
 
 BEGIN { doc["PTR"] = "\
-Do not use PTR, ISO C 90 implies `void *'\''"
+Do not use PTR, C++11 implies `void *'\''"
     category["PTR"] = ari_regression
     #fix("PTR", "gdb/utils.c", 6)
 }
@@ -816,7 +786,7 @@ unconditionally"
 }
 
 BEGIN { doc["bcmp"] = "\
-Do not use bcmp(), ISO C 90 implies memcmp()"
+Do not use bcmp(), C++11 implies memcmp()"
     category["bcmp"] = ari_regression
 }
 /(^|[^_[:alnum:]])bcmp[[:space:]]*\(/ {
@@ -824,7 +794,7 @@ Do not use bcmp(), ISO C 90 implies memcmp()"
 }
 
 BEGIN { doc["setlinebuf"] = "\
-Do not use setlinebuf(), ISO C 90 implies setvbuf()"
+Do not use setlinebuf(), C++11 implies setvbuf()"
     category["setlinebuf"] = ari_regression
 }
 /(^|[^_[:alnum:]])setlinebuf[[:space:]]*\(/ {
@@ -832,7 +802,7 @@ Do not use setlinebuf(), ISO C 90 implies setvbuf()"
 }
 
 BEGIN { doc["bcopy"] = "\
-Do not use bcopy(), ISO C 90 implies memcpy() and memmove()"
+Do not use bcopy(), C++11 implies memcpy() and memmove()"
     category["bcopy"] = ari_regression
 }
 /(^|[^_[:alnum:]])bcopy[[:space:]]*\(/ {
Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-i686, branch master

gdb-buildbot
Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/18/builds/347

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        56f79b630766bb134400b4a8da43941cfc31c0c0

Subject of commit:
        Change ARI to mention C++11, and remove some rules

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/56/56f79b630766bb134400b4a8da43941cfc31c0c0/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/56/56f79b630766bb134400b4a8da43941cfc31c0c0//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/56/56f79b630766bb134400b4a8da43941cfc31c0c0//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/17/builds/344

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        56f79b630766bb134400b4a8da43941cfc31c0c0

Subject of commit:
        Change ARI to mention C++11, and remove some rules

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/56/56f79b630766bb134400b4a8da43941cfc31c0c0/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/56/56f79b630766bb134400b4a8da43941cfc31c0c0//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/56/56f79b630766bb134400b4a8da43941cfc31c0c0//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

*** COMPILATION FAILED *** Failures on Fedora-x86_64-cc-with-index, branch master *** BREAKAGE ***

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-2

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/20/builds/346

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        56f79b630766bb134400b4a8da43941cfc31c0c0

Subject of commit:
        Change ARI to mention C++11, and remove some rules

*** FAILED to build GDB -- compile gdb ***
==============================================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    target-descriptions.o
  CXX    target-float.o
  CXX    target-memory.o
  CXX    target.o
  CXX    target/waitstatus.o
  CXX    test-target.o
  CXX    thread-iter.o
  CXX    thread.o
  CXX    tic6x-linux-tdep.o
  CXX    tic6x-tdep.o
  CXX    tid-parse.o
  CXX    tilegx-linux-tdep.o
  CXX    tilegx-tdep.o
  CXX    top.o
  CXX    tracefile-tfile.o
  CXX    tracefile.o
  CXX    tracepoint.o
  CXX    trad-frame.o
  CXX    tramp-frame.o
  CXX    tui/tui-command.o
  CXX    tui/tui-data.o
  CXX    tui/tui-disasm.o
  CXX    tui/tui-file.o
  CXX    tui/tui-hooks.o
  CXX    tui/tui-interp.o
  CXX    tui/tui-io.o
  CXX    tui/tui-layout.o
  CXX    tui/tui-out.o
  CXX    tui/tui-regs.o
  CXX    tui/tui-source.o
  CXX    tui/tui-stack.o
  CXX    tui/tui-win.o
  CXX    tui/tui-wingeneral.o
  CXX    tui/tui-winsource.o
  CXX    tui/tui.o
  CXX    type-stack.o
  CXX    typeprint.o
  CXX    ui-file.o
  CXX    ui-out.o
  CXX    ui-style.o
  CXX    unittests/array-view-selftests.o
  CXX    unittests/child-path-selftests.o
  CXX    unittests/cli-utils-selftests.o
  CXX    unittests/common-utils-selftests.o
  CXX    unittests/copy_bitwise-selftests.o
  CXX    unittests/environ-selftests.o
  CXX    unittests/format_pieces-selftests.o
  CXX    unittests/function-view-selftests.o
  CXX    unittests/lookup_name_info-selftests.o
  CXX    unittests/memory-map-selftests.o
  CXX    unittests/memrange-selftests.o
  CXX    unittests/mkdir-recursive-selftests.o
  CXX    unittests/observable-selftests.o
  CXX    unittests/offset-type-selftests.o
  CXX    unittests/optional-selftests.o
  CXX    unittests/parse-connection-spec-selftests.o
  CXX    unittests/ptid-selftests.o
  CXX    unittests/rsp-low-selftests.o
  CXX    unittests/scoped_fd-selftests.o
  CXX    unittests/scoped_mmap-selftests.o
  CXX    unittests/scoped_restore-selftests.o
  CXX    unittests/string_view-selftests.o
  CXX    unittests/style-selftests.o
  CXX    unittests/tracepoint-selftests.o
  CXX    unittests/unpack-selftests.o
  CXX    unittests/utils-selftests.o
  CXX    unittests/xml-utils-selftests.o
  CXX    user-regs.o
  CXX    utils.o
  CXX    v850-tdep.o
  CXX    valarith.o
  CXX    valops.o
  CXX    valprint.o
  CXX    value.o
  CXX    varobj.o
  CXX    vax-nbsd-tdep.o
  CXX    vax-tdep.o
  CXX    windows-tdep.o
  CXX    x86-linux-nat.o
  CXX    x86-nat.o
  CXX    x86-tdep.o
  CXX    xcoffread.o
  CXX    xml-support.o
  CXX    xml-syscall.o
  CXX    xml-tdesc.o
  CXX    xstormy16-tdep.o
  CXX    xtensa-config.o
  CXX    xtensa-linux-tdep.o
  CXX    xtensa-tdep.o
  GEN    init.c
  CXX    version.o
  CXX    xml-builtin.o
  CXX    init.o
  CXXLD  gdb

command timed out: 1200 seconds without output running [b'make', b'-j4', b'all'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1847.395931
==============================================

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-m64, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-3

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/3/builds/369

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        56f79b630766bb134400b4a8da43941cfc31c0c0

Subject of commit:
        Change ARI to mention C++11, and remove some rules

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/56/56f79b630766bb134400b4a8da43941cfc31c0c0/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/56/56f79b630766bb134400b4a8da43941cfc31c0c0//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/56/56f79b630766bb134400b4a8da43941cfc31c0c0//xfail.table.gz>

Reply | Threaded
Open this post in threaded view
|

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

gdb-buildbot
In reply to this post by gdb-buildbot
Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-4

Full Build URL:
        https://gdb-buildbot.osci.io/#builders/4/builds/344

Author:
        Tom Tromey <[hidden email]>

Commit tested:
        56f79b630766bb134400b4a8da43941cfc31c0c0

Subject of commit:
        Change ARI to mention C++11, and remove some rules

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/56/56f79b630766bb134400b4a8da43941cfc31c0c0/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/56/56f79b630766bb134400b4a8da43941cfc31c0c0//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/56/56f79b630766bb134400b4a8da43941cfc31c0c0//xfail.table.gz>