Updating lwip

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Updating lwip

Will Wagner
We are interested in updating to lwip 1.4.1. Has anyone already done any
work on this?

Have started looking at the difference between upstream 1.3.2 and what
is check in to ecos. There are quite a lot of differences, although most
of them are trivial renaming.

Does anyone know what changes were made to the lwip source and why. In
particular lost of the ppp code has had functions and variables renamed.

Any pointers for the porting process much appreciated.

Thanks
Will

--
------------------------------------------------------------------------
Will Wagner                                     [hidden email]
Development Manager                      Office Tel: +44 (0)20 7371 2032
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------


Reply | Threaded
Open this post in threaded view
|

Re: Updating lwip

Michael Jones
Will,

I was not around when this was ported, but I have an LwIP application with SNMP, Telnet, FTP, and HTTP, and I would be willing to test and help with some debugging. I think getting this updated is very high value.

Mike



On May 1, 2013, at 12:37 PM, Will Wagner <[hidden email]> wrote:

> We are interested in updating to lwip 1.4.1. Has anyone already done any work on this?
>
> Have started looking at the difference between upstream 1.3.2 and what is check in to ecos. There are quite a lot of differences, although most of them are trivial renaming.
>
> Does anyone know what changes were made to the lwip source and why. In particular lost of the ppp code has had functions and variables renamed.
>
> Any pointers for the porting process much appreciated.
>
> Thanks
> Will
>
> --
> ------------------------------------------------------------------------
> Will Wagner                                     [hidden email]
> Development Manager                      Office Tel: +44 (0)20 7371 2032
> Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
> ------------------------------------------------------------------------
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Updating lwip

John Dallaway-2
In reply to this post by Will Wagner
Hi Will

I am sure an upgrade of the eCos lwIP stack to the latest stable
upstream release would be welcomed by many eCos users.

On 01/05/13 19:37, Will Wagner wrote:

> Have started looking at the difference between upstream 1.3.2 and what
> is check in to ecos. There are quite a lot of differences, although most
> of them are trivial renaming.
>
> Does anyone know what changes were made to the lwip source and why. In
> particular lost of the ppp code has had functions and variables renamed.

The lwIP PPP code currently checked-in to the eCos repository was
contributed by Simon Kallweit. This would explain the substantial
PPP-related changes in your code comparison. It was always the intention
to migrate to the official lwIP PPP sources over time. Ref:

  http://ecos.sourceware.org/ml/ecos-discuss/2010-01/msg00057.html

As with all imports, it is important to minimise changes to the upstream
code as far as possible. That way, future imports become much easier.

John Dallaway
eCos maintainer
http://www.dallaway.org.uk/john
Reply | Threaded
Open this post in threaded view
|

Re: Updating lwip

Simon Kallweit
Hi Will,
Hi John,

I'm not actively using eCos anymore since about three years, when I quit
my job as an embedded developer and started studying computer science. I
just thought I'd give a shout so you know.

As far as I can remember, the changes in the PPP codebase were primarily
to get PPP running in sequential (non-threaded) mode, as the code in 1.3
was not fit for the task and we used eCos on a pretty limited platform
where we did not want to afford the overhead of using lwIP in threaded
mode. Also there might have been some additions to allow writing PPP
dumps in order to debug connection traces in wireshark, but I'm not a
100% sure if that was commited to the eCos repository at all. In lwIP
1.4 I think they refactored the PPP code to allow for proper handling in
sequential mode, so my hacks would get obsolete. I remember that I have
started porting a 1.4 release candidate back then, but never finished
the port. I can dig out the sources if this is of any help, but maybe
it's simpler to just go from the current lwIP release. Just let me know ..

Best regards,
Simon



On 5/2/13 6:29 PM, John Dallaway wrote:

> Hi Will
>
> I am sure an upgrade of the eCos lwIP stack to the latest stable
> upstream release would be welcomed by many eCos users.
>
> On 01/05/13 19:37, Will Wagner wrote:
>
>> Have started looking at the difference between upstream 1.3.2 and what
>> is check in to ecos. There are quite a lot of differences, although most
>> of them are trivial renaming.
>>
>> Does anyone know what changes were made to the lwip source and why. In
>> particular lost of the ppp code has had functions and variables renamed.
> The lwIP PPP code currently checked-in to the eCos repository was
> contributed by Simon Kallweit. This would explain the substantial
> PPP-related changes in your code comparison. It was always the intention
> to migrate to the official lwIP PPP sources over time. Ref:
>
>    http://ecos.sourceware.org/ml/ecos-discuss/2010-01/msg00057.html
>
> As with all imports, it is important to minimise changes to the upstream
> code as far as possible. That way, future imports become much easier.
>
> John Dallaway
> eCos maintainer
> http://www.dallaway.org.uk/john

Reply | Threaded
Open this post in threaded view
|

Re: Updating lwip

Will Wagner
Hi Simon & John,

Thanks for the feedback, it is useful for understanding the existing
changes.

So our plan for updating is as follows:
- move files according to ecos scheme. This is pretty straight forward,
a number of files are moved and the ipv6 code (that doesn't work) is
removed.
- drop all ppp changes and go with vanilla 1.4.1 ppp implementation
- drop lwip tests and keep the current ecos ones
- apply patches/changes made to 1.3.2 for ecos and all patches since to
1.4.1
- follow upgrading instructions for lwip. This will involve a few new
cdl options and changing a few functions.

After that is will just work :)

No idea how long this is going to take and it's not our top priority,
fitting it in when we get the chance. Will post some patches once we
have some progress.

Regards
Will

On 03/05/2013 09:49, Simon Kallweit wrote:

> Hi Will,
> Hi John,
>
> I'm not actively using eCos anymore since about three years, when I quit
> my job as an embedded developer and started studying computer science. I
> just thought I'd give a shout so you know.
>
> As far as I can remember, the changes in the PPP codebase were primarily
> to get PPP running in sequential (non-threaded) mode, as the code in 1.3
> was not fit for the task and we used eCos on a pretty limited platform
> where we did not want to afford the overhead of using lwIP in threaded
> mode. Also there might have been some additions to allow writing PPP
> dumps in order to debug connection traces in wireshark, but I'm not a
> 100% sure if that was commited to the eCos repository at all. In lwIP
> 1.4 I think they refactored the PPP code to allow for proper handling in
> sequential mode, so my hacks would get obsolete. I remember that I have
> started porting a 1.4 release candidate back then, but never finished
> the port. I can dig out the sources if this is of any help, but maybe
> it's simpler to just go from the current lwIP release. Just let me know ..
>
> Best regards,
> Simon
>
>
>
> On 5/2/13 6:29 PM, John Dallaway wrote:
>> Hi Will
>>
>> I am sure an upgrade of the eCos lwIP stack to the latest stable
>> upstream release would be welcomed by many eCos users.
>>
>> On 01/05/13 19:37, Will Wagner wrote:
>>
>>> Have started looking at the difference between upstream 1.3.2 and what
>>> is check in to ecos. There are quite a lot of differences, although most
>>> of them are trivial renaming.
>>>
>>> Does anyone know what changes were made to the lwip source and why. In
>>> particular lost of the ppp code has had functions and variables renamed.
>> The lwIP PPP code currently checked-in to the eCos repository was
>> contributed by Simon Kallweit. This would explain the substantial
>> PPP-related changes in your code comparison. It was always the intention
>> to migrate to the official lwIP PPP sources over time. Ref:
>>
>>    http://ecos.sourceware.org/ml/ecos-discuss/2010-01/msg00057.html
>>
>> As with all imports, it is important to minimise changes to the upstream
>> code as far as possible. That way, future imports become much easier.
>>
>> John Dallaway
>> eCos maintainer
>> http://www.dallaway.org.uk/john
>


--
------------------------------------------------------------------------
Will Wagner                                     [hidden email]
Development Manager                      Office Tel: +44 (0)20 7471 9224
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------