Trunk frozen starting tomorrow! No new features!

classic Classic list List threaded Threaded
53 messages Options
123
Reply | Threaded
Open this post in threaded view
|

Trunk frozen starting tomorrow! No new features!

Carlos O'Donell-4
H.J.,

I saw a recent post from you that the x32 work is now all checked into trunk.

Could you please confirm?

If x32 is ready to go I would like to go ahead with the v2 schedule [1]

Jeff,

Are your locale patches committed?

Paul,

Are all of your reviewed and acknowledged patches committed?

Ryan,

Are your Power math library fixes checked in?

Andreas,

Have you made progress on the bugs you pointed out earlier? I have the remaining blocker on my plate.

Community,

Are there any objections with freezing trunk starting tomorrow?

[2] http://sourceware.org/ml/libc-alpha/2012-05/msg00608.html

Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
[hidden email]
[hidden email]
+1 (613) 963 1026
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

David Miller-13
From: Carlos O'Donell <[hidden email]>
Date: Sun, 3 Jun 2012 21:11:23 -0400

> Are there any objections with freezing trunk starting tomorrow?

No objections from the sparc perspective.
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

H.J. Lu-30
In reply to this post by Carlos O'Donell-4
On Sun, Jun 3, 2012 at 6:11 PM, Carlos O'Donell
<[hidden email]> wrote:
> H.J.,
>
> I saw a recent post from you that the x32 work is now all checked into trunk.
>
> Could you please confirm?

I'd like to apply

http://sourceware.org/ml/libc-alpha/2012-06/msg00082.html

based on feedback from Roland:

http://sourceware.org/ml/libc-alpha/2012-05/msg02093.html

Also I'd like to finish the fix for

http://sourceware.org/bugzilla/show_bug.cgi?id=14117

I have submitted all patches and most of them have
been applied.  The remaining ones are on hjl/pr14117
branch.

--
H.J.
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Paul Eggert
In reply to this post by Carlos O'Donell-4
On 06/03/2012 06:11 PM, Carlos O'Donell wrote:
> Paul,
>
> Are all of your reviewed and acknowledged patches committed?

Yes, they're all in the trunk.
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Siddhesh Poyarekar
In reply to this post by Carlos O'Donell-4
On 4 June 2012 06:41, Carlos O'Donell <[hidden email]> wrote:
> Are there any objections with freezing trunk starting tomorrow?
>

I'm committing this today based on your feedback:

http://sourceware.org/ml/libc-alpha/2012-06/msg00085.html

I'd like it if someone could review the iconv segfault patch too so
that I can push it in:

http://sourceware.org/ml/libc-alpha/2012-05/msg01612.html

Both are bugfixes though, so the freeze probably does not count for them?


--
Siddhesh Poyarekar
http://siddhesh.in
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Adhemerval Zanella
In reply to this post by Carlos O'Donell-4
On 06/03/2012 10:11 PM, Carlos O'Donell wrote:
> Ryan,
>
> Are your Power math library fixes checked in?
>
I'd like to include two patches:

http://sourceware.org/ml/libc-alpha/2012-05/msg02062.html
http://sourceware.org/ml/libc-alpha/2012-05/msg02061.html

There are both for ldbl-128ibm and if someone could review I'll be grateful. I'm seeing also
an fail with 'fmod' with subnormals numbers after your additional tests on commit
c5bfe3d5ba29d36563f1e4bd4f8d7336093ee6fc that I plan to check today (I believe this will
be a fast fix).

I'm also seeing some unexpected underflows exceptions generated for csqrt, j0, j1, y0 and y1
also for ldbl-128ibm, but I don't think I will be able to fix them in time for 2.16.

--
Adhemerval Zanella Netto
  Software Engineer
  Linux Technology Center Brazil
  Toolchain / GLIBC on Power Architecture
  [hidden email] / [hidden email]
  +55 61 8642-9890

Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Carlos O'Donell-4
In reply to this post by H.J. Lu-30
On 6/3/2012 9:37 PM, H.J. Lu wrote:

> On Sun, Jun 3, 2012 at 6:11 PM, Carlos O'Donell
> <[hidden email]> wrote:
>> H.J.,
>>
>> I saw a recent post from you that the x32 work is now all checked into trunk.
>>
>> Could you please confirm?
>
> I'd like to apply
>
> http://sourceware.org/ml/libc-alpha/2012-06/msg00082.html
>
> based on feedback from Roland:
>
> http://sourceware.org/ml/libc-alpha/2012-05/msg02093.html
>
> Also I'd like to finish the fix for
>
> http://sourceware.org/bugzilla/show_bug.cgi?id=14117
>
> I have submitted all patches and most of them have
> been applied.  The remaining ones are on hjl/pr14117
> branch.
 
Just to be clear then, the only remaining patches for x32 are:

(1) Those patches to fix BZ #14117.

(2) The patch posted here:
http://sourceware.org/ml/libc-alpha/2012-05/msg02093.html

Is that correct?

Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
[hidden email]
[hidden email]
+1 (613) 963 1026
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Carlos O'Donell-4
In reply to this post by Paul Eggert
On 6/3/2012 11:27 PM, Paul Eggert wrote:
> On 06/03/2012 06:11 PM, Carlos O'Donell wrote:
>> Paul,
>>
>> Are all of your reviewed and acknowledged patches committed?
>
> Yes, they're all in the trunk.

Excellent. Thanks Paul.

Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
[hidden email]
[hidden email]
+1 (613) 963 1026
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Carlos O'Donell-4
In reply to this post by Siddhesh Poyarekar
On 6/3/2012 11:36 PM, Siddhesh Poyarekar wrote:
> On 4 June 2012 06:41, Carlos O'Donell <[hidden email]> wrote:
>> Are there any objections with freezing trunk starting tomorrow?
>>
>
> I'm committing this today based on your feedback:
>
> http://sourceware.org/ml/libc-alpha/2012-06/msg00085.html

This is already checked. Thanks.

> I'd like it if someone could review the iconv segfault patch too so
> that I can push it in:
>
> http://sourceware.org/ml/libc-alpha/2012-05/msg01612.html
>
> Both are bugfixes though, so the freeze probably does not count for them?
 
Just to be clear the change to support non-gcc compilers is *not* a bug fix, it is a new feature.

The IBM-930 conversion segfault *is* a bug fix and I would also like to see it fixed.

Please find someone to review the IBM-930 bug fix.

You may wish to ask Petr Baudis for review.

Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
[hidden email]
[hidden email]
+1 (613) 963 1026
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

H.J. Lu-30
In reply to this post by Carlos O'Donell-4
On Mon, Jun 4, 2012 at 6:22 AM, Carlos O'Donell
<[hidden email]> wrote:

> On 6/3/2012 9:37 PM, H.J. Lu wrote:
>> On Sun, Jun 3, 2012 at 6:11 PM, Carlos O'Donell
>> <[hidden email]> wrote:
>>> H.J.,
>>>
>>> I saw a recent post from you that the x32 work is now all checked into trunk.
>>>
>>> Could you please confirm?
>>
>> I'd like to apply
>>
>> http://sourceware.org/ml/libc-alpha/2012-06/msg00082.html
>>
>> based on feedback from Roland:
>>
>> http://sourceware.org/ml/libc-alpha/2012-05/msg02093.html
>>
>> Also I'd like to finish the fix for
>>
>> http://sourceware.org/bugzilla/show_bug.cgi?id=14117
>>
>> I have submitted all patches and most of them have
>> been applied.  The remaining ones are on hjl/pr14117
>> branch.
>
> Just to be clear then, the only remaining patches for x32 are:
>
> (1) Those patches to fix BZ #14117.

Yes.  I resubmitted them. The first one is at

http://sourceware.org/ml/libc-alpha/2012-06/msg00106.html

> (2) The patch posted here:
> http://sourceware.org/ml/libc-alpha/2012-05/msg02093.html
>
> Is that correct?

No.  The patch for sysdeps/unix/sysv/linux/x86/bits/environments.h
is at

http://sourceware.org/ml/libc-alpha/2012-06/msg00082.html

Thanks.

--
H.J.
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Ryan S. Arnold
In reply to this post by Carlos O'Donell-4
On Sun, Jun 3, 2012 at 8:11 PM, Carlos O'Donell
<[hidden email]> wrote:
> Ryan,
>
> Are your Power math library fixes checked in?

I'd like the fixes that Adhemerval pointed out:

http://sourceware.org/ml/libc-alpha/2012-05/msg02062.html
http://sourceware.org/ml/libc-alpha/2012-05/msg02061.html

Did Andreas Schwab's

Also,  Roland gave Tulio's platform header patch the OK to commit so
I'm going to do that today:

http://sourceware.org/ml/libc-alpha/2012-05/msg01928.html

Ryan S. Arnold
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Carlos O'Donell-4
On 6/4/2012 10:25 AM, Ryan S. Arnold wrote:
> On Sun, Jun 3, 2012 at 8:11 PM, Carlos O'Donell
> <[hidden email]> wrote:
>> Ryan,
>>
>> Are your Power math library fixes checked in?
>
> I'd like the fixes that Adhemerval pointed out:
>
> http://sourceware.org/ml/libc-alpha/2012-05/msg02062.html

This is OK to fix during the freeze.

> http://sourceware.org/ml/libc-alpha/2012-05/msg02061.html

This is also OK to fix during the freeze.

> Did Andreas Schwab's

???

> Also,  Roland gave Tulio's platform header patch the OK to commit so
> I'm going to do that today:
>
> http://sourceware.org/ml/libc-alpha/2012-05/msg01928.html

Please commit this ASAP.

Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
[hidden email]
[hidden email]
+1 (613) 963 1026
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Petr Baudis
In reply to this post by Carlos O'Donell-4
  Hi!

On Sun, Jun 03, 2012 at 09:11:23PM -0400, Carlos O'Donell wrote:
> Jeff,
>
> Are your locale patches committed?

  I can commit the weekday patch (not sure if there's any other
in the queue) if you wish.

                                Petr "Pasky" Baudis
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Carlos O'Donell-4
On 6/4/2012 10:58 AM, Petr Baudis wrote:

>   Hi!
>
> On Sun, Jun 03, 2012 at 09:11:23PM -0400, Carlos O'Donell wrote:
>> Jeff,
>>
>> Are your locale patches committed?
>
>   I can commit the weekday patch (not sure if there's any other
> in the queue) if you wish.
>
> Petr "Pasky" Baudis

Petr,

Please checkin the weekday patch ASAP.

Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
[hidden email]
[hidden email]
+1 (613) 963 1026
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Joseph Myers
In reply to this post by Adhemerval Zanella
On Mon, 4 Jun 2012, Adhemerval Zanella wrote:

> I'm also seeing some unexpected underflows exceptions generated for
> csqrt, j0, j1, y0 and y1 also for ldbl-128ibm, but I don't think I will
> be able to fix them in time for 2.16.

I'd advise adding appropriate UNDERFLOW_EXCEPTION_OK, with comments
referencing relevant bugs (existing or new), in that case.

I believe I understand the possible causes of spurious underflow in csqrt
(bug 14157), that on x86/x86_64 only appear for "double", but fixing them
(for all three implementations) will involve also adding new testcases for
some spurious underflow cases not currently covered by the testsuite - and
those cases may require ulps updates for all architectures, so meaning
they are best avoided during the freeze.

I do not know the causes of spurious underflows from Bessel functions (bug
14155), but I think that bug could reasonably be considered to cover the
long double cases as well.

--
Joseph S. Myers
[hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Andreas Jaeger-8
In reply to this post by Carlos O'Donell-4
On Sunday, June 03, 2012 21:11:23 Carlos O'Donell wrote:

> H.J.,
>
> I saw a recent post from you that the x32 work is now all checked into
> trunk.
>
> Could you please confirm?
>
> If x32 is ready to go I would like to go ahead with the v2 schedule
> [1]
>
> Jeff,
>
> Are your locale patches committed?
>
> Paul,
>
> Are all of your reviewed and acknowledged patches committed?
>
> Ryan,
>
> Are your Power math library fixes checked in?
>
> Andreas,
>
> Have you made progress on the bugs you pointed out earlier? I have the
> remaining blocker on my plate.

Sorr,y I've been out on vacation, I need a couple of days to figure out
the current state.

Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Andreas Jaeger-8
On Tuesday, June 12, 2012 12:53:52 Andreas Jaeger wrote:
> On Sunday, June 03, 2012 21:11:23 Carlos O'Donell wrote:
> > [...]
> > Andreas,
> >
> > Have you made progress on the bugs you pointed out earlier? I have
> > the remaining blocker on my plate.
>
> Sorr,y I've been out on vacation, I need a couple of days to figure
> out the current state.

Looking at my list from last time:
http://sourceware.org/bugzilla/show_bug.cgi?id=13594 - fixed in git
http://sourceware.org/bugzilla/show_bug.cgi?id=13579 - Carlos, you
wanted to look at this. Could you check it again, please? I think the
patch is fine...

http://sourceware.org/bugzilla/show_bug.cgi?id=13939 - contains a patch.
Who wants to review this malloc issue?

http://sourceware.org/bugzilla/show_bug.cgi?id=13882 - contains a patch.
Last time we discussed the bugs on the mailing list, Roland mentioned
that he wanted to review this later. Roland, could you do this now,
please? Or anybody else volunteering to review this bug in the dynamic
linker?

Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Roland McGrath-4
> http://sourceware.org/bugzilla/show_bug.cgi?id=13882 - contains a patch.

In fact it contains pointers to archives of this list, where Jeff posted
patches.

> Last time we discussed the bugs on the mailing list, Roland mentioned
> that he wanted to review this later. Roland, could you do this now,
> please? Or anybody else volunteering to review this bug in the dynamic
> linker?

I don't recall saying that and I don't think I have especially great
context on this stuff.  I think Jeff should just restart the review by
posting the minimal patch he wants to get in.


Thanks,
Roland

Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Andreas Jaeger-8
On 06/12/2012 07:44 PM, Roland McGrath wrote:

>> http://sourceware.org/bugzilla/show_bug.cgi?id=13882 - contains a patch.
>
> In fact it contains pointers to archives of this list, where Jeff posted
> patches.
>
>> Last time we discussed the bugs on the mailing list, Roland mentioned
>> that he wanted to review this later. Roland, could you do this now,
>> please? Or anybody else volunteering to review this bug in the dynamic
>> linker?
>
> I don't recall saying that and I don't think I have especially great
> context on this stuff.  I think Jeff should just restart the review by
> posting the minimal patch he wants to get in.

Good idea. Jeff, could you resend it with using uint16_t as Roland
suggested previously?

Roland, it seems I misunderstood your comments
(http://sourceware.org/ml/libc-alpha/2012-01/msg00087.html), sorry,

Andreas
--
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Reply | Threaded
Open this post in threaded view
|

Re: Trunk frozen starting tomorrow! No new features!

Jeff Law
In reply to this post by Roland McGrath-4
On 06/12/2012 11:44 AM, Roland McGrath wrote:

>> http://sourceware.org/bugzilla/show_bug.cgi?id=13882 - contains a patch.
>
> In fact it contains pointers to archives of this list, where Jeff posted
> patches.
>
>> Last time we discussed the bugs on the mailing list, Roland mentioned
>> that he wanted to review this later. Roland, could you do this now,
>> please? Or anybody else volunteering to review this bug in the dynamic
>> linker?
>
> I don't recall saying that and I don't think I have especially great
> context on this stuff.  I think Jeff should just restart the review by
> posting the minimal patch he wants to get in.
I'll do that.  Note that Uli introduced another instance of the broken
code not terribly long ago.  Basically we're fixing two things.  First
the sorting algorithm itself, second the char overflow issues.

Jeff
123