Small typo in iconv.m4

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Small typo in iconv.m4

Hafiz Abid Qadeer
Hi All,
I was investigating a character set related problem with windows hosted
GDB and I tracked it down to a typo in iconv.m4. This typo caused
libiconv detection to fail and related support was not built into gdb.

The problem is with the following line.
CPPFLAGS="$LIBS $INCICONV"
which should have been
CPPFLAGS="$CPPFLAGS $INCICONV"

OK to commit the attached patch?

2018-11-06  Hafiz Abid Qadeer  <[hidden email]>

        * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
        Append $INCICONV to it.
        * gcc/configure: Regenerate.
        * libcpp/configure: Likewise.
        * libstdc++-v3/configure: Likewise.
        * intl/configure: Likewise.

Thanks,
--
Hafiz Abid Qadeer
Mentor Embedded/CodeSourcery

iconv.patch (458 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Small typo in iconv.m4

Simon Marchi
On 2018-11-06 11:37, Hafiz Abid Qadeer wrote:

> Hi All,
> I was investigating a character set related problem with windows hosted
> GDB and I tracked it down to a typo in iconv.m4. This typo caused
> libiconv detection to fail and related support was not built into gdb.
>
> The problem is with the following line.
> CPPFLAGS="$LIBS $INCICONV"
> which should have been
> CPPFLAGS="$CPPFLAGS $INCICONV"
>
> OK to commit the attached patch?
>
> 2018-11-06  Hafiz Abid Qadeer  <[hidden email]>
>
> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
> Append $INCICONV to it.
> * gcc/configure: Regenerate.
> * libcpp/configure: Likewise.
> * libstdc++-v3/configure: Likewise.
> * intl/configure: Likewise.
>
> Thanks,

Seems good from my point of view, but I can't approve.

Simon
Reply | Threaded
Open this post in threaded view
|

Re: Small typo in iconv.m4

Eric Gallager
In reply to this post by Hafiz Abid Qadeer
On 11/7/18, Jeff Law <[hidden email]> wrote:

> On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote:
>> Hi All,
>> I was investigating a character set related problem with windows hosted
>> GDB and I tracked it down to a typo in iconv.m4. This typo caused
>> libiconv detection to fail and related support was not built into gdb.
>>
>> The problem is with the following line.
>> CPPFLAGS="$LIBS $INCICONV"
>> which should have been
>> CPPFLAGS="$CPPFLAGS $INCICONV"
>>
>> OK to commit the attached patch?
>>
>> 2018-11-06  Hafiz Abid Qadeer  <[hidden email]>
>>
>> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
>> Append $INCICONV to it.
>> * gcc/configure: Regenerate.
>> * libcpp/configure: Likewise.
>> * libstdc++-v3/configure: Likewise.
>> * intl/configure: Likewise.
>>
>> Thanks,
>>
> THanks.  I wasn't sure if you had commit privs, so I went ahead and
> installed the patch.
>
> Jeff
>

Does this have any effect on GCC bug 78251?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78251
Or any of the related bugs under "See Also" for that matter?
Reply | Threaded
Open this post in threaded view
|

Re: Small typo in iconv.m4

Jeff Law
On 11/9/18 10:57 AM, Eric Gallager wrote:

> On 11/7/18, Jeff Law <[hidden email]> wrote:
>> On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote:
>>> Hi All,
>>> I was investigating a character set related problem with windows hosted
>>> GDB and I tracked it down to a typo in iconv.m4. This typo caused
>>> libiconv detection to fail and related support was not built into gdb.
>>>
>>> The problem is with the following line.
>>> CPPFLAGS="$LIBS $INCICONV"
>>> which should have been
>>> CPPFLAGS="$CPPFLAGS $INCICONV"
>>>
>>> OK to commit the attached patch?
>>>
>>> 2018-11-06  Hafiz Abid Qadeer  <[hidden email]>
>>>
>>> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
>>> Append $INCICONV to it.
>>> * gcc/configure: Regenerate.
>>> * libcpp/configure: Likewise.
>>> * libstdc++-v3/configure: Likewise.
>>> * intl/configure: Likewise.
>>>
>>> Thanks,
>>>
>> THanks.  I wasn't sure if you had commit privs, so I went ahead and
>> installed the patch.
>>
>> Jeff
>>
>
> Does this have any effect on GCC bug 78251?
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78251
> Or any of the related bugs under "See Also" for that matter?
Certainly looks related.  Though I think we're still going to see
pollution, just in a slightly different way.

jeff