Simplify mi_continue_to

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Simplify mi_continue_to

Vladimir Prus-3

The MI test use a helper function mi_continue_to, that is troublesome to use. First one
has to set a breakpoint, and then use mi_continue_to passing it a bunch of parameters,
where in practice most of them end up being ".*".

At the same time, we have perfectly working mi_runto that needs just function name.
This patch refactor mi_continue_to to work just like mi_runto and simplifies the tests
that use mi_continue_to.

No regressions on x86, OK?

- Volodya

        Simplify usage of mi_continue_to.
        * lib/mi-support.exp (mi_runto_helper): Renamed
        from mi_runto, added new parameter 'run_or_continue'.
        (mi_runto): Use mi_runto_helper.
        (mi_continue_to): Accept just function name as parameter.
        Use mi_runto_helper.
        * gdb.mi/mi-var-cmd.exp: Adjust to changes.
        * gdb.mi/mi2-var-cmd.exp: Likewise.

mi_continue_to__gdb_mainline.diff (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Simplify mi_continue_to

Daniel Jacobowitz-2
On Tue, Dec 19, 2006 at 01:46:02PM +0300, Vladimir Prus wrote:

> No regressions on x86, OK?
>
> - Volodya
>
> Simplify usage of mi_continue_to.
> * lib/mi-support.exp (mi_runto_helper): Renamed
> from mi_runto, added new parameter 'run_or_continue'.
> (mi_runto): Use mi_runto_helper.
> (mi_continue_to): Accept just function name as parameter.
> Use mi_runto_helper.
> * gdb.mi/mi-var-cmd.exp: Adjust to changes.
> * gdb.mi/mi2-var-cmd.exp: Likewise.

OK, thanks.

--
Daniel Jacobowitz
CodeSourcery