Re: [PATCH v3 1/2] Initial PRU port for libgloss and newlib

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v3 1/2] Initial PRU port for libgloss and newlib

Jeff Johnston
Hi Dimitar,

Looks good.  A few things:

1. if the top-level configure.ac changes are already accepted by gcc, let
us know and
    we will sync, otherwise submit first to gcc as we keep in sync for
newlib
   (see the top-level MAINTAINERS file)

2. can you please confirm that you are the sole author of the added files
(excepting
    copied files with Red Hat/Cygnus licensing)  and that you have
    permission from your employer to submit them

3. please re-submit with the git patch as an e-mail attachment.  I will
regenerate
    the configuration files for you

Thanks,

-- Jeff J.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v3 1/2] Initial PRU port for libgloss and newlib

Dimitar Dimitrov
On Wed, 30 Oct 2019, 20:47:25 EET Jeff Johnston wrote:
> Hi Dimitar,
>
> Looks good.  A few things:
>
> 1. if the top-level configure.ac changes are already accepted by gcc, let
> us know and
>     we will sync, otherwise submit first to gcc as we keep in sync for
> newlib
>    (see the top-level MAINTAINERS file)
The configure.ac changes for PRU have already been merged in GCC. I'll let you
sync it from there. I have dropped the configure.ac change from my patch.

>
> 2. can you please confirm that you are the sole author of the added files
> (excepting
>     copied files with Red Hat/Cygnus licensing)  and that you have
>     permission from your employer to submit them
Yes, I am the sole author of those files. I have permission from my employer
to work on the GNU toolchain in my spare time.

>
> 3. please re-submit with the git patch as an e-mail attachment.  I will
> regenerate
>     the configuration files for you
I have attached the two patches to this email. Thank you for taking care of
the regeneration.

Thanks,
Dimitar


0001-Initial-PRU-port-for-libgloss-and-newlib.patch (46K) Download Attachment
0002-PRU-Align-libmath-to-PRU-ABI.patch (23K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v3 1/2] Initial PRU port for libgloss and newlib

Jeff Johnston
Hi Dimitar,

The patches have been pushed.

Thanks,

-- Jeff J.

On Wed, Oct 30, 2019 at 4:49 PM Dimitar Dimitrov <[hidden email]> wrote:

> On Wed, 30 Oct 2019, 20:47:25 EET Jeff Johnston wrote:
> > Hi Dimitar,
> >
> > Looks good.  A few things:
> >
> > 1. if the top-level configure.ac changes are already accepted by gcc,
> let
> > us know and
> >     we will sync, otherwise submit first to gcc as we keep in sync for
> > newlib
> >    (see the top-level MAINTAINERS file)
> The configure.ac changes for PRU have already been merged in GCC. I'll
> let you
> sync it from there. I have dropped the configure.ac change from my patch.
>
> >
> > 2. can you please confirm that you are the sole author of the added files
> > (excepting
> >     copied files with Red Hat/Cygnus licensing)  and that you have
> >     permission from your employer to submit them
> Yes, I am the sole author of those files. I have permission from my
> employer
> to work on the GNU toolchain in my spare time.
>
> >
> > 3. please re-submit with the git patch as an e-mail attachment.  I will
> > regenerate
> >     the configuration files for you
> I have attached the two patches to this email. Thank you for taking care
> of
> the regeneration.
>
> Thanks,
> Dimitar
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v3 1/2] Initial PRU port for libgloss and newlib

Dimitar Dimitrov
On Thu, 31 Oct 2019, 21:43:15 EET Jeff Johnston wrote:
> Hi Dimitar,
>
> The patches have been pushed.
>
Thank you. I tested and verified that the newlib GIT tree can now be built for
PRU. There are no regressions in GCC and newlib testsuites.

Regards,
Dimitar