Re: PATCH: Fix ia64 relaxation regression

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: PATCH: Fix ia64 relaxation regression

Alan Modra
On Tue, May 31, 2005 at 12:01:42PM -0700, H. J. Lu wrote:
> * elf-bfd.h (elf_link_hash_entry): Add the provide field.

No, this makes 17 single-bit fields, and increases the size of
struct elf_link_hash_entry on 32-bit targets.  Please do without this,
or remove one of the other bit-fields.

--
Alan Modra
IBM OzLabs - Linux Technology Centre

Reply | Threaded
Open this post in threaded view
|

Re: PATCH: Fix ia64 relaxation regression

H.J. Lu-27
On Wed, Jun 01, 2005 at 05:49:08PM +0930, Alan Modra wrote:
> On Tue, May 31, 2005 at 12:01:42PM -0700, H. J. Lu wrote:
> > * elf-bfd.h (elf_link_hash_entry): Add the provide field.
>
> No, this makes 17 single-bit fields, and increases the size of
> struct elf_link_hash_entry on 32-bit targets.  Please do without this,
> or remove one of the other bit-fields.
>

I don't see how I can remove one easily. The only possible one is
dynamic_def. But I am not sure if it is doable. Also I have another
patch:

http://sourceware.org/ml/binutils/2005-05/msg00199.html

to add one more field. I don't see I can keep the the bit fields to
16. I will keep it as my local change.


H.J.