Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

jiez
On 1/4/06, Jim Blandy <[hidden email]> wrote:

> On 12/27/05, Jie Zhang <[hidden email]> wrote:
> > This final part only contains one line change in src top level
> > configure, which will enable configure in gdb directory for bfin port.
>
> I think you want to post a patch to configure.in, not configure.
> (It's preferred to omit the patches to configure scripts generated
> from configure.in or configure.ac files when posting work for review.)
>  And the patch needs to go to [hidden email], as well as
> gdb-patches.
>
Here is the second patch, which is for configure.in, and also sent to
[hidden email]. Sorry for not sending the first one to
binutils mailing list.

> The actual content of the change looks straightforward to me.
>
If it's also OK for binutils, I'll commit it along with other Blackfin
gdb patches.

Thanks,
Jie

bfin-toplevel-2.diff (542 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

Nick Clifton
Hi Jie,

> Here is the second patch, which is for configure.in, and also sent to
> [hidden email]. Sorry for not sending the first one to
> binutils mailing list.
>
>> The actual content of the change looks straightforward to me.
>>
> If it's also OK for binutils, I'll commit it along with other Blackfin
> gdb patches.

It is OK for binutils.

Cheers
   Nick



Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

Daniel Jacobowitz-2
In reply to this post by jiez
On Wed, Jan 04, 2006 at 03:15:56PM +0800, Jie Zhang wrote:

> On 1/4/06, Jim Blandy <[hidden email]> wrote:
> > On 12/27/05, Jie Zhang <[hidden email]> wrote:
> > > This final part only contains one line change in src top level
> > > configure, which will enable configure in gdb directory for bfin port.
> >
> > I think you want to post a patch to configure.in, not configure.
> > (It's preferred to omit the patches to configure scripts generated
> > from configure.in or configure.ac files when posting work for review.)
> >  And the patch needs to go to [hidden email], as well as
> > gdb-patches.
> >
> Here is the second patch, which is for configure.in, and also sent to
> [hidden email]. Sorry for not sending the first one to
> binutils mailing list.
>
> > The actual content of the change looks straightforward to me.
> >
> If it's also OK for binutils, I'll commit it along with other Blackfin
> gdb patches.

Sounds good.

> * configure.in: Configure gdb directory for bfin.

You may already know this, but you should also mention the generated
files in the changelog:

        * configure: Regenerated.

And commit both.

--
Daniel Jacobowitz
CodeSourcery