Re: [PATCH] Add -lpwl to ppllibs.

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Sebastian Pop-2
Hi,

On Sun, Feb 27, 2011 at 03:38, Ralf Wildenhues <[hidden email]> wrote:

> * Sebastian Pop wrote on Sun, Feb 27, 2011 at 08:23:15AM CET:
>> On Sun, Feb 27, 2011 at 00:35, Ralf Wildenhues wrote:
>> > * Sebastian Pop wrote on Wed, Feb 23, 2011 at 09:47:07PM CET:
>> >> here is the updated patch with your remarks and the remarks from
>> >> Rainer.  We still have the libs in the same order: -lppl_c -lppl
>> >> $pwllib, and I will change the order following what Roberto says.
>> >
>> > Well, has Roberto replied yet?  The contents of the patch depend
>> > on the answer, and I'd rather review that version of the patch
>> > that is supposed to go in.
>> >
>> > The patch looks OK for the case that pwl doesn't depend on any
>> > of the other PPL libs.
>>
>> I have not yet received an answer for the question of whether PWL is
>> independent of PPL.
>
> He answered now.  So the patch is OK.
>
>> > Please remember that toplevel patches need to be synced to src.
>>
>> Am I supposed to commit the configure changes to a different place
>> than gcc trunk?
>
> Yes, to the src CVS repository, and Cc:ing binutils and gdb-patches
> at sourceware.org.  See
> http://gcc.gnu.org/codingconventions.html#upstream for details.
Here are the two patches that I committed to
svn+ssh://[hidden email]/svn/gcc
and synced to :ext:[hidden email]:/cvs/src

Sebastian

0001-Add-lisl-to-clooglibs.patch (2K) Download Attachment
0002-Add-lpwl-to-ppllibs.patch (11K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Richard Biener
On Wed, Mar 2, 2011 at 4:49 AM, Sebastian Pop <[hidden email]> wrote:

> Hi,
>
> On Sun, Feb 27, 2011 at 03:38, Ralf Wildenhues <[hidden email]> wrote:
>> * Sebastian Pop wrote on Sun, Feb 27, 2011 at 08:23:15AM CET:
>>> On Sun, Feb 27, 2011 at 00:35, Ralf Wildenhues wrote:
>>> > * Sebastian Pop wrote on Wed, Feb 23, 2011 at 09:47:07PM CET:
>>> >> here is the updated patch with your remarks and the remarks from
>>> >> Rainer.  We still have the libs in the same order: -lppl_c -lppl
>>> >> $pwllib, and I will change the order following what Roberto says.
>>> >
>>> > Well, has Roberto replied yet?  The contents of the patch depend
>>> > on the answer, and I'd rather review that version of the patch
>>> > that is supposed to go in.
>>> >
>>> > The patch looks OK for the case that pwl doesn't depend on any
>>> > of the other PPL libs.
>>>
>>> I have not yet received an answer for the question of whether PWL is
>>> independent of PPL.
>>
>> He answered now.  So the patch is OK.
>>
>>> > Please remember that toplevel patches need to be synced to src.
>>>
>>> Am I supposed to commit the configure changes to a different place
>>> than gcc trunk?
>>
>> Yes, to the src CVS repository, and Cc:ing binutils and gdb-patches
>> at sourceware.org.  See
>> http://gcc.gnu.org/codingconventions.html#upstream for details.
>
> Here are the two patches that I committed to
> svn+ssh://[hidden email]/svn/gcc
> and synced to :ext:[hidden email]:/cvs/src

This broke bootstrap for me.

gcc   -g -fkeep-inline-functions -DIN_GCC   -W -Wall -Wwrite-strings
-Wcast-qual -Wstrict-prototypes -Wmissing-prototypes
-Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -Wold-style-definition
-Wc++-compat -fno-common  -DHAVE_CONFIG_H  -o cc1 c-lang.o
c-family/stub-objc.o attribs.o c-errors.o c-decl.o c-typeck.o
c-convert.o c-aux-info.o c-objc-common.o c-parser.o tree-mudflap.o
c-family/c-common.o c-family/c-cppbuiltin.o c-family/c-dump.o
c-family/c-format.o c-family/c-gimplify.o c-family/c-lex.o
c-family/c-omp.o c-family/c-opts.o c-family/c-pch.o
c-family/c-ppoutput.o c-family/c-pragma.o c-family/c-pretty-print.o
c-family/c-semantics.o c-family/c-ada-spec.o i386-c.o \
          cc1-checksum.o main.o tree-browser.o libbackend.a
../libcpp/libcpp.a ../libdecnumber/libdecnumber.a ../libcpp/libcpp.a
../libiberty/libiberty.a ../libdecnumber/libdecnumber.a  -lcloog
-lmpc -lmpfr -lgmp -rdynamic -ldl  -L../zlib -lz
libbackend.a(graphite-ppl.o): In function `ppl_powerset_is_empty':
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:552: undefined
reference to `ppl_new_PIP_Problem_from_constraints'
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:553: undefined
reference to `ppl_PIP_Problem_is_satisfiable'
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:555: undefined
reference to `ppl_delete_PIP_Problem'
collect2: ld returned 1 exit status
make[3]: *** [cc1] Error 1
make[3]: *** Waiting for unfinished jobs....
libbackend.a(graphite-ppl.o): In function `ppl_powerset_is_empty':
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:552: undefined
reference to `ppl_new_PIP_Problem_from_constraints'
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:553: undefined
reference to `ppl_PIP_Problem_is_satisfiable'
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:555: undefined
reference to `ppl_delete_PIP_Problem'
collect2: ld returned 1 exit status
make[3]: *** [lto1] Error 1
rm gcov.pod cpp.pod gfdl.pod fsf-funding.pod gcc.pod
make[3]: Leaving directory `/home/abuild/rguenther/obj/gcc'
make[2]: *** [all-stage1-gcc] Error 2
make[2]: Leaving directory `/home/abuild/rguenther/obj'
make[1]: *** [stage1-bubble] Error 2
make[1]: Leaving directory `/home/abuild/rguenther/obj'
make: *** [all] Error 2

so it seems it broke some configure tests.  I have ppl-0.11 and cloog 0.15.10.

As you can see from the link line it doesn't link ppl at all.  ppllibs is empty
for me.

Please revert or fix ASAP.

Richard.

> Sebastian
>
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Paolo Carlini-3
On 03/02/2011 01:20 PM, Richard Guenther wrote:
> so it seems it broke some configure tests.  I have ppl-0.11 and cloog 0.15.10.
>  
I was about to send a message...

For the record, it broke the boostrap for me too. Until yesterday I used
to build successfully with ppl-0.11 and cloog-0.16.1 with
--enable-cloog-backend=isl. Today I see a lot of undefined references.
For the record, upgrading to ppl-0.11.2 doesn't help.

Paolo.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Jakub Jelinek
On Wed, Mar 02, 2011 at 01:45:01PM +0100, Paolo Carlini wrote:
> On 03/02/2011 01:20 PM, Richard Guenther wrote:
> > so it seems it broke some configure tests.  I have ppl-0.11 and cloog 0.15.10.
> >  
> I was about to send a message...
>
> For the record, it broke the boostrap for me too. Until yesterday I used
> to build successfully with ppl-0.11 and cloog-0.16.1 with
> --enable-cloog-backend=isl. Today I see a lot of undefined references.
> For the record, upgrading to ppl-0.11.2 doesn't help.

It also broke bootstrap with ppl-0.10.2 and cloog-ppl 0.15.7 (which before
didn't try to compile in graphite, now it does, except it doesn't link in
-lppl and uses unconditionally ppl 0.11+ functions).

        Jakub
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Sebastian Pop-2
In reply to this post by Richard Biener
On Wed, Mar 2, 2011 at 06:20, Richard Guenther
<[hidden email]> wrote:
> As you can see from the link line it doesn't link ppl at all.  ppllibs is empty
> for me.
>
> Please revert or fix ASAP.

Does the attached patch fix the problem you are seeing?

Thanks,
Sebastian

0001-Fix-configure-problem.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Richard Biener
On Wed, Mar 2, 2011 at 3:48 PM, Sebastian Pop <[hidden email]> wrote:
> On Wed, Mar 2, 2011 at 06:20, Richard Guenther
> <[hidden email]> wrote:
>> As you can see from the link line it doesn't link ppl at all.  ppllibs is empty
>> for me.
>>
>> Please revert or fix ASAP.
>
> Does the attached patch fix the problem you are seeing?

It seems to work for me (bootstrap is in stage2, HAVE_cloog is 1).

Richard.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Sebastian Pop-2
On Wed, Mar 2, 2011 at 09:01, Richard Guenther
<[hidden email]> wrote:

> On Wed, Mar 2, 2011 at 3:48 PM, Sebastian Pop <[hidden email]> wrote:
>> On Wed, Mar 2, 2011 at 06:20, Richard Guenther
>> <[hidden email]> wrote:
>>> As you can see from the link line it doesn't link ppl at all.  ppllibs is empty
>>> for me.
>>>
>>> Please revert or fix ASAP.
>>
>> Does the attached patch fix the problem you are seeing?
>
> It seems to work for me (bootstrap is in stage2, HAVE_cloog is 1).

Ok, thanks for checking.

So my theory is that you configured with "--with-ppl" with no arguments,
that sets the variable $with_ppl to the empty string, and so "x$with_ppl"
is not equal to "xyes" in that case.

Sebastian
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Richard Biener
On Wed, Mar 2, 2011 at 4:07 PM, Sebastian Pop <[hidden email]> wrote:

> On Wed, Mar 2, 2011 at 09:01, Richard Guenther
> <[hidden email]> wrote:
>> On Wed, Mar 2, 2011 at 3:48 PM, Sebastian Pop <[hidden email]> wrote:
>>> On Wed, Mar 2, 2011 at 06:20, Richard Guenther
>>> <[hidden email]> wrote:
>>>> As you can see from the link line it doesn't link ppl at all.  ppllibs is empty
>>>> for me.
>>>>
>>>> Please revert or fix ASAP.
>>>
>>> Does the attached patch fix the problem you are seeing?
>>
>> It seems to work for me (bootstrap is in stage2, HAVE_cloog is 1).
>
> Ok, thanks for checking.
>
> So my theory is that you configured with "--with-ppl" with no arguments,
> that sets the variable $with_ppl to the empty string, and so "x$with_ppl"
> is not equal to "xyes" in that case.

No, I configured with just ./configure --enable-languages=c

Richard.

> Sebastian
>
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Paolo Carlini-3
In reply to this post by Richard Biener
On 03/02/2011 04:01 PM, Richard Guenther wrote:
> It seems to work for me
>  
Likewise, with my usual simple configure line including only
--enable-cloog-backend=isl beyond trivial things.

Paolo.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Sebastian Pop-2
On Wed, Mar 2, 2011 at 09:15, Paolo Carlini <[hidden email]> wrote:
> On 03/02/2011 04:01 PM, Richard Guenther wrote:
>> It seems to work for me
>>
> Likewise, with my usual simple configure line including only
> --enable-cloog-backend=isl beyond trivial things.

I have committed the attached patch to gcc trunk.

Sebastian

0001-Fix-configure-problem.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add -lpwl to ppllibs.

Sebastian Pop-2
In reply to this post by Jakub Jelinek
On Wed, Mar 2, 2011 at 06:57, Jakub Jelinek <[hidden email]> wrote:
> It also broke bootstrap with ppl-0.10.2 and cloog-ppl 0.15.7 (which before

Unless you specify --disable-ppl-version-check, PPL version 0.11 or later
is required.

> didn't try to compile in graphite, now it does, except it doesn't link in
> -lppl and uses unconditionally ppl 0.11+ functions).

Jakub, I am not sure I addressed the concerns that you raised: could
you please let me know if the patch I committed is not enough to fix
the issue?

Thanks,
Sebastian