RFC: fix for two Mauve tests - gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java and gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

RFC: fix for two Mauve tests - gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java and gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java

Pavel Tisnovsky
Greetings,

I've made patch for two Mauve tests - gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java and
gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java.

This fix is based on the same issue which was fixed in the test javax/swing/Border/TitledBorder/constructors.java
(discussed here: http://www.cygwin.com/ml/mauve-discuss/2011-q3/msg00014.html)

diff -u -r1.1 getTitlePosition.java
--- gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java   10 Oct 2005 08:06:08 -0000      1.1
+++ gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java   15 Sep 2011 14:31:44 -0000
@@ -39,7 +39,7 @@
   public void test(TestHarness harness)
   {
     TitledBorder b = new TitledBorder(new EmptyBorder(1, 1, 1, 1));
-    harness.check(b.getTitlePosition(), TitledBorder.TOP);
+    harness.check(b.getTitlePosition(), TitledBorder.DEFAULT_POSITION);
     b.setTitlePosition(TitledBorder.BELOW_TOP);
     harness.check(b.getTitlePosition(), TitledBorder.BELOW_TOP);
   }
diff -u -r1.1 setTitlePosition.java
--- gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java   10 Oct 2005 08:06:09 -0000      1.1
+++ gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java   15 Sep 2011 14:31:44 -0000
@@ -39,7 +39,7 @@
   public void test(TestHarness harness)
   {
     TitledBorder b = new TitledBorder(new EmptyBorder(1, 1, 1, 1));
-    harness.check(b.getTitlePosition(), TitledBorder.TOP);
+    harness.check(b.getTitlePosition(), TitledBorder.DEFAULT_POSITION);
     b.setTitlePosition(TitledBorder.BELOW_BOTTOM);
     harness.check(b.getTitlePosition(), TitledBorder.BELOW_BOTTOM);
     boolean pass = false;


Can anybody please review this change?

Cheers
Pavel