[RFA/testsuite/ada] Add test with function returning "small" array of floats

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[RFA/testsuite/ada] Add test with function returning "small" array of floats

Joel Brobecker
Hello,

Following a question raised by Mark in:

        http://www.sourceware.org/ml/gdb-patches/2006-12/msg00312.html

I decided to add a test in gdb.ada/array_return to cover that case.

2006-12-26  Joel Brobecker  <[hidden email]>

        * gdb.ada/array_return/pck.ads (Small_Float_Vector): New type.
        (Create_Small_Float_Vector): New function.
        * gdb.ada/array_return/pck.adb (Create_Small_Float_Vector): Add
        function body.
        * gdb.ada/array_return/p.adb: Use new type and function from
        package Pck.
        * gdb.ada/array_return.exp: Add a test verifying that GDB is
        able to print the value returned by a function returning an
        array of float.

Tested on sparc64-solaris.  OK to apply?

Thank you,
--
Joel

float-array-return.diff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [RFA/testsuite/ada] Add test with function returning "small" array of floats

Mark Kettenis-6
> Date: Tue, 26 Dec 2006 09:52:33 +0400
> From: Joel Brobecker <[hidden email]>
>
> Hello,
>
> Following a question raised by Mark in:
>
>         http://www.sourceware.org/ml/gdb-patches/2006-12/msg00312.html
>
> I decided to add a test in gdb.ada/array_return to cover that case.
>
> 2006-12-26  Joel Brobecker  <[hidden email]>
>
>         * gdb.ada/array_return/pck.ads (Small_Float_Vector): New type.
>         (Create_Small_Float_Vector): New function.
>         * gdb.ada/array_return/pck.adb (Create_Small_Float_Vector): Add
>         function body.
>         * gdb.ada/array_return/p.adb: Use new type and function from
>         package Pck.
>         * gdb.ada/array_return.exp: Add a test verifying that GDB is
>         able to print the value returned by a function returning an
>         array of float.
>
> Tested on sparc64-solaris.  OK to apply?

Looks reasonable to me, but then I don't know any Ada.

Mark
Reply | Threaded
Open this post in threaded view
|

Re: [RFA/testsuite/ada] Add test with function returning "small" array of floats

Daniel Jacobowitz-2
On Tue, Dec 26, 2006 at 03:06:53PM +0100, Mark Kettenis wrote:
> > Tested on sparc64-solaris.  OK to apply?
>
> Looks reasonable to me, but then I don't know any Ada.

Ditto - Joel, I think you should go ahead.

--
Daniel Jacobowitz
CodeSourcery
Reply | Threaded
Open this post in threaded view
|

Re: [RFA/testsuite/ada] Add test with function returning "small" array of floats

Joel Brobecker
> On Tue, Dec 26, 2006 at 03:06:53PM +0100, Mark Kettenis wrote:
> > > Tested on sparc64-solaris.  OK to apply?
> >
> > Looks reasonable to me, but then I don't know any Ada.
>
> Ditto - Joel, I think you should go ahead.

Thank you! This is now checked in.

--
Joel