RFA: skip failing ld tests on arm-aout

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RFA: skip failing ld tests on arm-aout

Zack Weinberg

For some time, arm-aout has had several failures in the ld testsuite:

FAIL: ld-scripts/data
FAIL: ld-scripts/provide-1
FAIL: ld-scripts/provide-2
FAIL: ld-scripts/size-1

These all appear to have the same root cause: "objdump -s -j .text" on
an a.out executable will print the file header as part of the text
segment, which the .d file is not expecting.

Given how obsolete a.out is, I do not think it is worthwhile to try
either to make objdump not do that, or to parametrize the .d files.
This patch just marks those tests unsupported on a.out.  OK to apply?

zw

ld/testsuite:
        * ld-scripts/data.exp, ld-scripts/provide.exp: Skip all tests
        as UNSUPPORTED if is_aout_format.
        * ld-scripts/size.exp:  Likewise.  Properly mark tests
        UNSUPPORTED instead of just returning.

===================================================================
Index: ld/testsuite/ld-scripts/data.exp
--- ld/testsuite/ld-scripts/data.exp 12 May 2005 07:32:08 -0000 1.2
+++ ld/testsuite/ld-scripts/data.exp 31 May 2005 22:41:30 -0000
@@ -17,4 +17,11 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
 
+# An a.out "objdump -s -j .text" has the file header visible inside the
+# text segment, confusing run_dump_test.
+if {[is_aout_format]} {
+ unsupported data
+ return
+}
+
 run_dump_test data
===================================================================
Index: ld/testsuite/ld-scripts/provide.exp
--- ld/testsuite/ld-scripts/provide.exp 12 May 2005 07:32:08 -0000 1.3
+++ ld/testsuite/ld-scripts/provide.exp 31 May 2005 22:41:30 -0000
@@ -15,15 +15,20 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
+# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301,
+# USA.
 
-if [istarget "rs6000-*-aix*"] {
-    # Target maps .text and .data to other sections.
+# AIX maps .text and .data to other sections.
+# a.out objdump displays the file header inside the text segment,
+# confusing run_dump_test.
+
+if {[istarget "rs6000-*-aix*"] || [is_aout_format]} {
+    unsupported provide-1
+    unsupported provide-2
+    unsupported provide-3
     return
 }
 
-set testname "provide"
-
 run_dump_test provide-1
 run_dump_test provide-2
 setup_xfail *-*-*
===================================================================
Index: ld/testsuite/ld-scripts/size.exp
--- ld/testsuite/ld-scripts/size.exp 12 May 2005 07:32:08 -0000 1.3
+++ ld/testsuite/ld-scripts/size.exp 31 May 2005 22:41:30 -0000
@@ -16,19 +16,22 @@
 # Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
 #
 
-if [istarget "rs6000-*-aix*"] {
-    # Target maps .text and .data to other sections.
+# AIX maps .text and .data to other sections.
+# a.out objdump displays the file header inside the text segment,
+# confusing run_dump_test.
+
+if {[istarget "rs6000-*-aix*"] || [is_aout_format]} {
+    unsupported size-1
+    unsupported size-2
     return
 }
 
 run_dump_test size-1
 
-if ![is_elf_format] {
-    return
-}
-
-if [istarget "mips*-*-*"] {
-    # MIPS inserts a REGINFO PHDR
+# size-2 only works on ELF targets.
+# MIPS inserts a REGINFO PHDR
+if {![is_elf_format] || [istarget "mips*-*-*"]} {
+    unsupported size-2
     return
 }
 
Reply | Threaded
Open this post in threaded view
|

Re: RFA: skip failing ld tests on arm-aout

Nick Clifton
Hi Zack,

> ld/testsuite:
>         * ld-scripts/data.exp, ld-scripts/provide.exp: Skip all tests
>         as UNSUPPORTED if is_aout_format.
>         * ld-scripts/size.exp:  Likewise.  Properly mark tests
>         UNSUPPORTED instead of just returning.

Approved - please apply.

Cheers
   Nick