[RFA] gdb.mi/mi2-var-display.exp: fullname field testing

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[RFA] gdb.mi/mi2-var-display.exp: fullname field testing

Denis PILAT
I guess we forgot to test the presence of fullname field in the stop reason

OK for commit ?

--
Denis

2007-04-06  Denis Pilat  <[hidden email]>

        * gdb.mi/mi2-var-display.exp: Test for the fullname field.

Index: mi2-var-display.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-var-display.exp,v
retrieving revision 1.10
diff -u -p -r1.10 mi2-var-display.exp
--- mi2-var-display.exp 27 Feb 2007 21:45:34 -0000      1.10
+++ mi2-var-display.exp 6 Apr 2007 12:15:21 -0000
@@ -50,7 +50,7 @@ mi_gdb_test "200-break-insert $srcfile:$
 mi_run_cmd
 # The running part has been checked already by mi_run_cmd
 gdb_expect {
-    -re "\[\r\n\]*000\\*stopped,reason=\"breakpoint-hit\",bkptno=\"1\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"do_children_tests\",args=\\\[\\\],file=\".*var-cmd.c\",line=\"$line_dct_end\"\}\r\n$mi_gdb_prompt$" {
+    -re "\[\r\n\]*000\\*stopped,reason=\"breakpoint-hit\",bkptno=\"1\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"do_children_tests\",args=\\\[\\\],file=\".*var-cmd.c\",fullname=\"${fullname_syntax}${srcfile}\",line=\"$line_dct_end\"\}\r\n$mi_gdb_prompt$" {
        pass "run to do_children_tests"
     }
     -re ".*$mi_gdb_prompt$" {fail "run to do_children_tests (2)"}
@@ -334,7 +334,7 @@ mi_gdb_test "200-break-insert do_special

 send_gdb "-exec-continue\n"
 gdb_expect {
-    -re "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=\"breakpoint-hit\",bkptno=\"2\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"do_special_tests\",args=\\\[\\\],file=\".*var-cmd.c\",line=\"$line_dst_a_1\"\}\r\n$mi_gdb_prompt$" {
+    -re "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=\"breakpoint-hit\",bkptno=\"2\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"do_special_tests\",args=\\\[\\\],file=\".*var-cmd.c\",fullname=\"${fullname_syntax}${srcfile}\",line=\"$line_dst_a_1\"\}\r\n$mi_gdb_prompt$" {
        pass "continue to do_special_tests"
     }
     timeout {


Reply | Threaded
Open this post in threaded view
|

Re: [RFA] gdb.mi/mi2-var-display.exp: fullname field testing

Nick Roberts
 >  # The running part has been checked already by mi_run_cmd
 >  gdb_expect {
 > -    -re "\[\r\n\]*000\\*stopped,reason=\"breakpoint-hit\",bkptno=\"1\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"do_children_tests\",args=\\\[\\\],file=\".*var-cmd.c\",line=\"$line_dct_end\"\}\r\n$mi_gdb_prompt$" {
 > +    -re "\[\r\n\]*000\\*stopped,reason=\"breakpoint-hit\",bkptno=\"1\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"do_children_tests\",args=\\\[\\\],file=\".*var-cmd.c\",fullname=\"${fullname_syntax}${srcfile}\",line=\"$line_dct_end\"\}\r\n$mi_gdb_prompt$" {
 >         pass "run to do_children_tests"

I guess this didn't fail before because .* is greedy, and therefore matched up
to the second var-cmd.c in the fullname field.  It would be nice to use
non-greedy expressions, normally .*?, but this don't seem to work with
Dejagnu.

--
Nick                                           http://www.inet.net.nz/~nickrob
Reply | Threaded
Open this post in threaded view
|

Re: [RFA] gdb.mi/mi2-var-display.exp: fullname field testing

Daniel Jacobowitz-2
In reply to this post by Denis PILAT
On Fri, Apr 06, 2007 at 02:29:37PM +0200, Denis PILAT wrote:
> I guess we forgot to test the presence of fullname field in the stop reason

> OK for commit ?


> 2007-04-06  Denis Pilat  <[hidden email]>

> * gdb.mi/mi2-var-display.exp: Test for the fullname field.

This is OK, thanks.

--
Daniel Jacobowitz
CodeSourcery
Reply | Threaded
Open this post in threaded view
|

Re: [RFA] gdb.mi/mi2-var-display.exp: fullname field testing

Denis PILAT

>> * gdb.mi/mi2-var-display.exp: Test for the fullname field.
>>    
>
> This is OK, thanks.
>  
Just commited !
--
Denis