[RFA] Fix all compiler warnings on AIX

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[RFA] Fix all compiler warnings on AIX

Joel Brobecker
Hello,

The attached patch fixes all the compilation warnings on AIX
(which have been aborting the build since -Werror was introduced).

2005-10-27  Joel Brobecker  <[hidden email]>

        Mostly from Eric Botcazou <[hidden email]>
        * rs6000-core.c: ANSIfy all function definitions.
        Add missing function prototypes.
        (ptr_to_uint): New type.
        (rs6000coff_core_p): Use it as intermediate step in casts.
        (rs6000coff_core_file_matches_executable_p): Likewise.
        * xcoff-target.h (rs6000coff_core_p): Fix prototype.
        (rs6000coff_core_file_matches_executable_p): Likewise.

Fixes the build failure. Tested on ppc-aix 5.1 by running the
various testsuites first with a version of binutils were rs6000-core
was built without -Werror, and then after having rebuilt it normally
but with the patch applied.

Adding the prototypes is the part I added to Eric's patch. I wasn't
exactly sure where to add them, so I just added them around the begining
of the same file.

OK to apply?

Thanks,
--
Joel

bfd_aix-2.diff (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [RFA] Fix all compiler warnings on AIX

Alan Modra
On Thu, Oct 27, 2005 at 06:07:44PM -0700, Joel Brobecker wrote:

> 2005-10-27  Joel Brobecker  <[hidden email]>
>
>         Mostly from Eric Botcazou <[hidden email]>
>         * rs6000-core.c: ANSIfy all function definitions.
>         Add missing function prototypes.
>         (ptr_to_uint): New type.
>         (rs6000coff_core_p): Use it as intermediate step in casts.
>         (rs6000coff_core_file_matches_executable_p): Likewise.
>         * xcoff-target.h (rs6000coff_core_p): Fix prototype.
>         (rs6000coff_core_file_matches_executable_p): Likewise.

OK.

--
Alan Modra
IBM OzLabs - Linux Technology Centre
Reply | Threaded
Open this post in threaded view
|

Re: [RFA] Fix all compiler warnings on AIX

Joel Brobecker
> > 2005-10-27  Joel Brobecker  <[hidden email]>
> >
> >         Mostly from Eric Botcazou <[hidden email]>
> >         * rs6000-core.c: ANSIfy all function definitions.
> >         Add missing function prototypes.
> >         (ptr_to_uint): New type.
> >         (rs6000coff_core_p): Use it as intermediate step in casts.
> >         (rs6000coff_core_file_matches_executable_p): Likewise.
> >         * xcoff-target.h (rs6000coff_core_p): Fix prototype.
> >         (rs6000coff_core_file_matches_executable_p): Likewise.
>
> OK.

Thank you! Checked in.

--
Joel