Patch for handling spaces in directory name

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for handling spaces in directory name

Trevor Harmon
There's a bug in docbook-tools 0.6.14: If the directory containing  
the DocBook file to be processed has a space in it, the scripts will  
fail.

I've attached a patch that fixes this bug. Basically, all I did was  
put quotes around shell variables. However, I did have to make a more  
substantial change: The SGML_FILE variable had to be factored out of  
SGML_ARGUMENTS so that it could be quoted.

Could someone with commit rights please take a look at this patch and  
apply it? Thanks,

Trevor


docbook-directory-with-spaces.patch (8K) Download Attachment
smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch for handling spaces in directory name

ebischoff (Bugzilla)
Le Jeudi 15 Juin 2006 20:38, Trevor Harmon a écrit :

> There's a bug in docbook-tools 0.6.14: If the directory containing
> the DocBook file to be processed has a space in it, the scripts will
> fail.
>
> I've attached a patch that fixes this bug. Basically, all I did was
> put quotes around shell variables. However, I did have to make a more
> substantial change: The SGML_FILE variable had to be factored out of
> SGML_ARGUMENTS so that it could be quoted.
>
> Could someone with commit rights please take a look at this patch and
> apply it? Thanks,

Tim? Are you still alive?


--
Concombre : "Alors, qu'est-ce que tu aimes dans la vie ?"
Chourave :  "J'aime médire."
(Le concombre masqué, Mandriva)
Reply | Threaded
Open this post in threaded view
|

Re: Patch for handling spaces in directory name

Trevor Harmon
On Jun 15, 2006, at 10:21 PM, Éric Bischoff wrote:

> Le Jeudi 15 Juin 2006 20:38, Trevor Harmon a écrit :
>> There's a bug in docbook-tools 0.6.14: If the directory containing
>> the DocBook file to be processed has a space in it, the scripts will
>> fail.
>>
>> I've attached a patch that fixes this bug. Basically, all I did was
>> put quotes around shell variables. However, I did have to make a more
>> substantial change: The SGML_FILE variable had to be factored out of
>> SGML_ARGUMENTS so that it could be quoted.
>>
>> Could someone with commit rights please take a look at this patch and
>> apply it? Thanks,
>
> Tim? Are you still alive?

Hmm... apparently not. Is there someone else who could review the  
patch and commit it to the repo?

Trevor

Reply | Threaded
Open this post in threaded view
|

Re: Patch for handling spaces in directory name

ebischoff (Bugzilla)
Le Mardi 27 Juin 2006 21:36, Trevor Harmon a écrit :
> > Tim? Are you still alive?
>
> Hmm... apparently not. Is there someone else who could review the
> patch and commit it to the repo?

I think I still have write access to the repository... I could try.


--
Si on ne peut pas toujours compter sur ses amis, on peut toujours compter son
or.
(Donjon de Naheulbeuk)
Reply | Threaded
Open this post in threaded view
|

Re: Patch for handling spaces in directory name

ebischoff (Bugzilla)
In reply to this post by Trevor Harmon
Le Mardi 27 Juin 2006 21:36, Trevor Harmon a écrit :
> > Tim? Are you still alive?
>
> Hmm... apparently not. Is there someone else who could review the
> patch and commit it to the repo?

Hmmm. We are having a big problem. I have no more copy of the repository here.
I don't remind the instructions to connect to the CVS repository (there was
something with EXPORT CVS_RSH=ssh, as far as I can remember), nor my
password(s). Somehow that's quite normal, since I'm not the maintainer
anymore.

We have to hope that Tim is just on vacation now and that he will return soon.

Otherwise we will have to engage in a painful process: write to redhat to
explain the situation, get new access to the repository or move away the
project from their repository, etc.

I have found another email address for Tim. Perharps it will work better?

--
Si on ne peut pas toujours compter sur ses amis, on peut toujours compter son
or.
(Donjon de Naheulbeuk)
Reply | Threaded
Open this post in threaded view
|

Re: Patch for handling spaces in directory name

Tim Waugh
On Wed, 2006-06-28 at 19:20 +0200, Éric Bischoff wrote:

> We have to hope that Tim is just on vacation now and that he will return soon.

I'm still here -- just a bit swamped at the moment.

Tim.
*/


signature.asc (196 bytes) Download Attachment