[PING] [PATCH] [D] Re-apply change for handling non-local references in nested functions

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PING] [PATCH] [D] Re-apply change for handling non-local references in nested functions

Iain Buclaw
Another belated ping, again I'll go ahead with it as its trivial/obvious.

---
Hi,

This was first applied by Pierre-Marie back in February (see
63e43d3aedb8b1112899c2d0ad74cbbee687e5d6), but my re-write of d-exp.y
was written about 6 months earlier, and I subsequently missed it when
backporting upstream changes.

This reapplies that change.

Regards
Iain

dlang-nonlocal.patch (914 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PING] [PATCH] [D] Re-apply change for handling non-local references in nested functions

Pedro Alves-7
On 10/06/2015 05:52 PM, Iain Buclaw wrote:

> Another belated ping, again I'll go ahead with it as its trivial/obvious.
>
> ---
> Hi,
>
> This was first applied by Pierre-Marie back in February (see
> 63e43d3aedb8b1112899c2d0ad74cbbee687e5d6), but my re-write of d-exp.y
> was written about 6 months earlier, and I subsequently missed it when
> backporting upstream changes.
>
> This reapplies that change.
>

In these cases, I really see no need to wait for pre-commit review.
You should feel comfortable to go ahead immediately.

Thanks,
Pedro Alves