[PATCH v3] [D] Don't recursively look for a symbol in all imports of imported modules.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v3] [D] Don't recursively look for a symbol in all imports of imported modules.

Iain Buclaw
Hi,

Third time's a charm.  This time I've removed the x86-specific dwarf
assembly file and replaced it with Dwarf::assemble as per Pedro's
suggestion. (Thanks!)

Tested, and confirmed that without the patch, the circular test given
loops forever.

Regards,
Iain.

---

dlang-searchimports-3.patch (8K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v3] [D] Don't recursively look for a symbol in all imports of imported modules.

Pedro Alves-7
On 02/22/2016 01:20 AM, Iain Buclaw wrote:
> Hi,
>
> Third time's a charm.  This time I've removed the x86-specific dwarf
> assembly file and replaced it with Dwarf::assemble as per Pedro's
> suggestion. (Thanks!)
>

Excellent, thanks for doing this.

> Tested, and confirmed that without the patch, the circular test given
> loops forever.

LGTM.

Thanks,
Pedro Alves