[PATCH] opcodes/nfp: Fix disassembly of crc[] with swapped operands.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] opcodes/nfp: Fix disassembly of crc[] with swapped operands.

Francois H. Theron

The decoding of the CRC operation in alu instructions was using bits
from the instruction word directly, instead of srcA which would be
different if the swap bit was set.

Signed-off-by: Francois H. Theron <[hidden email]>
---
 binutils/ChangeLog                            |   4 +++
 binutils/testsuite/binutils-all/nfp/test1.d   |  32 +++++++++++++++---
 .../binutils-all/nfp/test1_nfp6000.nffw       | Bin 9880 -> 10128 bytes
 opcodes/ChangeLog                             |   4 +++
 opcodes/nfp-dis.c                             |  12 +++----
 5 files changed, 42 insertions(+), 10 deletions(-)


0001-opcodes-nfp-Fix-disassembly-of-crc-with-swapped-oper.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] opcodes/nfp: Fix disassembly of crc[] with swapped operands.

Nick Clifton
Hi Francois,

> The decoding of the CRC operation in alu instructions was using bits
> from the instruction word directly, instead of srcA which would be
> different if the swap bit was set.
 
Approved - please apply.

Cheers
  Nick