[PATCH] libanl: properly cleanup if first helper thread creation failed (bug 22927)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] libanl: properly cleanup if first helper thread creation failed (bug 22927)

Andreas Schwab
        [BZ #22927]
        * resolv/gai_misc.c (__gai_enqueue_request): Don't crash if
        creating the first helper thread failed.
---
 resolv/gai_misc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/resolv/gai_misc.c b/resolv/gai_misc.c
index e7c3b63cc5..80a2cff835 100644
--- a/resolv/gai_misc.c
+++ b/resolv/gai_misc.c
@@ -261,8 +261,11 @@ __gai_enqueue_request (struct gaicb *gaicbp)
       /* We cannot create a thread in the moment and there is
  also no thread running.  This is a problem.  `errno' is
  set to EAGAIN if this is only a temporary problem.  */
-      assert (lastp->next == newp);
-      lastp->next = NULL;
+      assert (requests == newp || lastp->next == newp);
+      if (lastp != NULL)
+ lastp->next = NULL;
+      else
+ requests = NULL;
       requests_tail = lastp;
 
       newp->next = freelist;
--
2.19.1


--
Andreas Schwab, SUSE Labs, [hidden email]
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] libanl: properly cleanup if first helper thread creation failed (bug 22927)

Florian Weimer-5
* Andreas Schwab:

> [BZ #22927]
> * resolv/gai_misc.c (__gai_enqueue_request): Don't crash if
> creating the first helper thread failed.

Looks okay to me.  Thanks.

Florian