[PATCH] fix build problem in powerpc soft-fp

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] fix build problem in powerpc soft-fp

Steven Munroe
This patch fixes a build problem associated with a missing target caused
by the resent feholdexcpt() fixes.



2007-06-01  Steven Munroe  <[hidden email]>

        * sysdeps/powerpc/nofpu/fe_mask.c: New File.
        * sysdeps/powerpc/nofpu/fe_nomask.c: New File.


diff -urN libc25-cvstip-20070510/ports-cvstip-20070510/sysdeps/powerpc/nofpu/fe_mask.c libc25/ports/sysdeps/powerpc/nofpu/fe_mask.c
--- libc25-cvstip-20070510/ports-cvstip-20070510/sysdeps/powerpc/nofpu/fe_mask.c Wed Dec 31 18:00:00 1969
+++ libc25/ports/sysdeps/powerpc/nofpu/fe_mask.c Thu May 24 14:18:13 2007
@@ -0,0 +1,2 @@
+/* empty implementation for soft-fp */
+
diff -urN libc25-cvstip-20070510/ports-cvstip-20070510/sysdeps/powerpc/nofpu/fe_nomask.c libc25/ports/sysdeps/powerpc/nofpu/fe_nomask.c
--- libc25-cvstip-20070510/ports-cvstip-20070510/sysdeps/powerpc/nofpu/fe_nomask.c Wed Dec 31 18:00:00 1969
+++ libc25/ports/sysdeps/powerpc/nofpu/fe_nomask.c Thu May 24 14:18:30 2007
@@ -0,0 +1,2 @@
+/* empty implementation for soft-fp */
+
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fix build problem in powerpc soft-fp

Daniel Jacobowitz-2
On Fri, Jun 01, 2007 at 05:40:48PM -0500, Steven Munroe wrote:
> This patch fixes a build problem associated with a missing target caused
> by the resent feholdexcpt() fixes.

What are these needed for?  fe_mask is added to libm-support by
sysdeps/powerpc/fpu/Makefile and a nofpu build shouldn't ever see
that.

--
Daniel Jacobowitz
CodeSourcery
Reply | Threaded
Open this post in threaded view
|

[PATCH] fix build problem in powerpc soft-fp

Steven Munroe
Daniel Jacobowitz wrote:

> On Fri, Jun 01, 2007 at 05:40:48PM -0500, Steven Munroe wrote:
>  
>> This patch fixes a build problem associated with a missing target caused
>> by the resent feholdexcpt() fixes.
>>    
>
> What are these needed for?  fe_mask is added to libm-support by
> sysdeps/powerpc/fpu/Makefile and a nofpu build shouldn't ever see
> that.
>  
Ok, fe_nomask is not needed at all for soft-fp, so this patch removes
fe_nomask from the ./nofpu/Makefile.



2007-06-07  Steven Munroe  <[hidden email]>

        * sysdeps/powerpc/nofpu/Makefile: Remove fe_nomask from libm-support.

diff -urN dummy-libc/ports-cvstip-20070606/sysdeps/powerpc/nofpu/Makefile libc25/ports/sysdeps/powerpc/nofpu/Makefile
--- dummy-libc/ports-cvstip-20070606/sysdeps/powerpc/nofpu/Makefile 2006-11-22 09:13:11.000000000 -0600
+++ libc25/ports/sysdeps/powerpc/nofpu/Makefile 2007-06-07 09:53:05.708240976 -0500
@@ -6,7 +6,7 @@
 endif
 
 ifeq ($(subdir),math)
-libm-support += fenv_const fe_nomask
+libm-support += fenv_const
 CPPFLAGS += -I../soft-fp/
 # The follow CFLAGS are a work around for GCC Bugzilla Bug 29253
 # "expand_abs wrong default code for floating point"
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fix build problem in powerpc soft-fp

Daniel Jacobowitz-2
On Thu, Jun 07, 2007 at 02:48:23PM -0500, Steven Munroe wrote:

> Daniel Jacobowitz wrote:
> > On Fri, Jun 01, 2007 at 05:40:48PM -0500, Steven Munroe wrote:
> >  
> >> This patch fixes a build problem associated with a missing target caused
> >> by the resent feholdexcpt() fixes.
> >>    
> >
> > What are these needed for?  fe_mask is added to libm-support by
> > sysdeps/powerpc/fpu/Makefile and a nofpu build shouldn't ever see
> > that.
> >  
>
> Ok, fe_nomask is not needed at all for soft-fp, so this patch removes
> fe_nomask from the ./nofpu/Makefile.

Sorry I dropped the ball on this.  I checked in your patch.

--
Daniel Jacobowitz
CodeSourcery