[PATCH] elf: Link sotruss-lib.so with BIND_NOW for --enable-bind-now

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] elf: Link sotruss-lib.so with BIND_NOW for --enable-bind-now

Florian Weimer-5
The audit module itself can be linked with BIND_NOW; it does not
affect its functionality.

This should complete the leftovers from commit
2d6ab5df3b675e96ee587ae6a8c2ce004c6b1ba9 ("Document and fix
--enable-bind-now [BZ #21015]").

2019-04-25  Florian Weimer  <[hidden email]>

        elf: Link sotruss-lib.so with BIND_NOW for --enable-bind-now.
        * elf/Makefile (LDFLAGS-sotruss-lib.so): Set.

diff --git a/elf/Makefile b/elf/Makefile
index 0b4a877880..4895489208 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -125,6 +125,7 @@ install-others += $(inst_auditdir)/sotruss-lib.so
 install-bin-script += sotruss
 generated += sotruss
 libof-sotruss-lib = extramodules
+LDFLAGS-sotruss-lib.so += $(z-now-$(bind-now))
 $(objpfx)sotruss-lib.so: $(objpfx)sotruss-lib.os
  $(build-module-asneeded)
 $(objpfx)sotruss-lib.so: $(common-objpfx)libc.so $(objpfx)ld.so \
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] elf: Link sotruss-lib.so with BIND_NOW for --enable-bind-now

Carlos O'Donell-5
On 4/25/19 3:42 PM, Florian Weimer wrote:
> The audit module itself can be linked with BIND_NOW; it does not
> affect its functionality.

Agreed.

Reviewed-by: Carlos O'Donell <[hidden email]>

> This should complete the leftovers from commit
> 2d6ab5df3b675e96ee587ae6a8c2ce004c6b1ba9 ("Document and fix
> --enable-bind-now [BZ #21015]").
>
> 2019-04-25  Florian Weimer  <[hidden email]>
>
> elf: Link sotruss-lib.so with BIND_NOW for --enable-bind-now.
> * elf/Makefile (LDFLAGS-sotruss-lib.so): Set.
>
> diff --git a/elf/Makefile b/elf/Makefile
> index 0b4a877880..4895489208 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -125,6 +125,7 @@ install-others += $(inst_auditdir)/sotruss-lib.so
>   install-bin-script += sotruss
>   generated += sotruss
>   libof-sotruss-lib = extramodules
> +LDFLAGS-sotruss-lib.so += $(z-now-$(bind-now))

OK.

>   $(objpfx)sotruss-lib.so: $(objpfx)sotruss-lib.os
>   $(build-module-asneeded)
>   $(objpfx)sotruss-lib.so: $(common-objpfx)libc.so $(objpfx)ld.so \
>


--
Cheers,
Carlos.