[PATCH] build.xml tweak to select-java targets

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] build.xml tweak to select-java targets

Jamison Hope
The attached patch tweaks the -maybe-select-java* targets to have both
"if" and "unless" attributes.  This ensures that only one of them is
enabled at a time, so the preprocessing only happens once.

Currently (without this patch), if building with JDK 1.7, the
preprocessor first edits all the files to set up for JAVA6, then again
for JAVA7.  If building with JDK 1.8, it preprocesses three times, for
JAVA6, then JAVA7, then JAVA8.

The extra steps are harmless, in that they cancel each other out, but
they affect file modification times, making javac recompile files that
it didn't really need to.

--
Jamison Hope
The PTR Group
www.theptrgroup.com



build-xml-java-selection.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] build.xml tweak to select-java targets

Per Bothner


On 06/02/2015 04:45 PM, Jamison Hope wrote:
> The attached patch tweaks the -maybe-select-java* targets to have both
> "if" and "unless" attributes.  This ensures that only one of them is
> enabled at a time, so the preprocessing only happens once.

Thanks - checked in.
--
        --Per Bothner
[hidden email]   http://per.bothner.com/