[PATCH] build.xml fix for ScriptEngineFactory classes

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] build.xml fix for ScriptEngineFactory classes

Jamison Hope
It would appear that since -select-java-non-android is invoked via
antcall, which acts like a sub-shell, definitions within that target do
not persist.  So then when these properties are referenced in other
targets, the Wrong Thing happens.  In particular, the Java 6
ScriptEngineFactory classes are not built in the java-classes and
xml-classes targets because the definition of has-java6 has gone out of
scope.

The attached patch moves the definitions of the has-java{2,4,5,6,7,8}
properties out of the -select-java-non-android target up to top-level.

Unrelatedly, it adds gnu/q2/lang/ to java-classes.

--
Jamison Hope
The PTR Group
www.theptrgroup.com



build-xml.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] build.xml fix for ScriptEngineFactory classes

Per Bothner


On 05/19/2015 09:38 AM, Jamison Hope wrote:

> It would appear that since -select-java-non-android is invoked via
> antcall, which acts like a sub-shell, definitions within that target do
> not persist.  So then when these properties are referenced in other
> targets, the Wrong Thing happens.  In particular, the Java 6
> ScriptEngineFactory classes are not built in the java-classes and
> xml-classes targets because the definition of has-java6 has gone out of
> scope.
>
> The attached patch moves the definitions of the has-java{2,4,5,6,7,8}
> properties out of the -select-java-non-android target up to top-level.
>
> Unrelatedly, it adds gnu/q2/lang/ to java-classes.

Thanks.  I checked this in.
--
        --Per Bothner
[hidden email]   http://per.bothner.com/