[PATCH] Use correct conversion specifications in template string

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Use correct conversion specifications in template string

jiez
I'll commit this patch in a short time. It's a simple fix. The code
explains itself well.

Jie

bfin-gas.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Use correct conversion specifications in template string

Nick Clifton
Hi Jie,

> I'll commit this patch in a short time. It's a simple fix. The code
> explains itself well.

This is OK this time, but in the future, do please include a short
description of what the patch does.  Even if it is obvious.  Even if the
ChangeLog entry says it all.  That way we do not need to download and
open the attachment in order to see what your patch does.

Cheers
   Nick


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Use correct conversion specifications in template string

jiez
On 1/21/06, Nick Clifton <[hidden email]> wrote:

> Hi Jie,
>
> > I'll commit this patch in a short time. It's a simple fix. The code
> > explains itself well.
>
> This is OK this time, but in the future, do please include a short
> description of what the patch does.  Even if it is obvious.  Even if the
> ChangeLog entry says it all.  That way we do not need to download and
> open the attachment in order to see what your patch does.
>
Sorry. I thought everyone uses some email client with text attachment
preview, like Mozilla Thunderbird. Would it be also OK to include such
simple patch inline in email?

Thanks,
Jie
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Use correct conversion specifications in template string

Eric Christopher-2
>>
> Sorry. I thought everyone uses some email client with text attachment
> preview, like Mozilla Thunderbird. Would it be also OK to include such
> simple patch inline in email?

Still have quite a few mutt users on the lists :)

However, yes, it's ok to put patches inline.

-eric
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Use correct conversion specifications in template string

Nick Clifton
In reply to this post by jiez
Hi Jie,

>> This is OK this time, but in the future, do please include a short
>> description of what the patch does.  Even if it is obvious.  Even if the
>> ChangeLog entry says it all.  That way we do not need to download and
>> open the attachment in order to see what your patch does.
>>
> Sorry. I thought everyone uses some email client with text attachment
> preview, like Mozilla Thunderbird.

I actually use Thunderbird, but it does not automatically open
attachments for me, I still have to click on it in order for it to be
opened/downloaded/saved.

> Would it be also OK to include such simple patch inline in email?

Certainly.  Plus do not let me discourage you from using attachments,
especially for larger patches.  All I am asking is that if you do use an
attachment, please include a short description of it in the main body of
your message.

Cheers
   Nick


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Use correct conversion specifications in template string

jiez
Hi Nick,

Nick Clifton wrote:
>> Would it be also OK to include such simple patch inline in email?
>
> Certainly.  Plus do not let me discourage you from using attachments,
> especially for larger patches.  All I am asking is that if you do use an
> attachment, please include a short description of it in the main body of
> your message.
>
I see.

Thanks,
Jie